Revert "Sanitize cursor theme name and size in GTK and Wayland" [chromium/src : main]

1 view
Skip to first unread message

Antonio Alphonse (Gerrit)

unread,
Aug 3, 2026, 11:12:27 AM (10 days ago) Aug 3
to rubber-...@appspot.gserviceaccount.com, android-bu...@system.gserviceaccount.com, Yichen Zhou, Chromium LUCI CQ, Thomas Anderson, Sadrul Chowdhury, chromium...@chromium.org, Henrique Ferreiro, max+watc...@igalia.com, ozone-...@chromium.org, nickdiego+wa...@igalia.com
Attention needed from Thomas Anderson and Yichen Zhou

Antonio Alphonse voted Code-Review+1

Code-Review+1
Open in Gerrit

Related details

Attention is currently required from:
  • Thomas Anderson
  • Yichen Zhou
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement is not satisfiedCode-Owners
  • requirement is not satisfiedCode-Review
  • requirement is not satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: I6f07bbbf369e363a159be7c200a7a2d0909550e8
Gerrit-Change-Number: 8186301
Gerrit-PatchSet: 1
Gerrit-Owner: Antonio Alphonse <alph...@google.com>
Gerrit-Reviewer: Antonio Alphonse <alph...@google.com>
Gerrit-Reviewer: Chromium LUCI CQ <chromiu...@luci-project-accounts.iam.gserviceaccount.com>
Gerrit-Reviewer: Thomas Anderson <thomasa...@chromium.org>
Gerrit-Reviewer: Yichen Zhou <yic...@chromium.org>
Gerrit-CC: Henrique Ferreiro <hfer...@igalia.com>
Gerrit-CC: Sadrul Chowdhury <sad...@chromium.org>
Gerrit-Attention: Yichen Zhou <yic...@chromium.org>
Gerrit-Attention: Thomas Anderson <thomasa...@chromium.org>
Gerrit-Comment-Date: Mon, 03 Aug 2026 15:12:08 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
satisfied_requirement
unsatisfied_requirement
open
diffy

rubber-stamper@appspot.gserviceaccount.com (Gerrit)

unread,
Aug 3, 2026, 11:13:18 AM (10 days ago) Aug 3
to Antonio Alphonse, android-bu...@system.gserviceaccount.com, Yichen Zhou, Chromium LUCI CQ, Thomas Anderson, Sadrul Chowdhury, chromium...@chromium.org, Henrique Ferreiro, max+watc...@igalia.com, ozone-...@chromium.org, nickdiego+wa...@igalia.com
Attention needed from Thomas Anderson and Yichen Zhou

Related details

Attention is currently required from:
  • Thomas Anderson
  • Yichen Zhou
Submit Requirements:
    • requirement satisfiedCode-Coverage
    • requirement is not satisfiedCode-Owners
    • requirement satisfiedCode-Review
    • requirement satisfiedReview-Enforcement
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: comment
    Gerrit-Project: chromium/src
    Gerrit-Branch: main
    Gerrit-Change-Id: I6f07bbbf369e363a159be7c200a7a2d0909550e8
    Gerrit-Change-Number: 8186301
    Gerrit-PatchSet: 1
    Gerrit-Owner: Antonio Alphonse <alph...@google.com>
    Gerrit-Reviewer: Antonio Alphonse <alph...@google.com>
    Gerrit-Reviewer: Chromium LUCI CQ <chromiu...@luci-project-accounts.iam.gserviceaccount.com>
    Gerrit-Reviewer: Thomas Anderson <thomasa...@chromium.org>
    Gerrit-Reviewer: Yichen Zhou <yic...@chromium.org>
    Gerrit-CC: Henrique Ferreiro <hfer...@igalia.com>
    Gerrit-CC: Sadrul Chowdhury <sad...@chromium.org>
    Gerrit-Attention: Yichen Zhou <yic...@chromium.org>
    Gerrit-Attention: Thomas Anderson <thomasa...@chromium.org>
    Gerrit-Comment-Date: Mon, 03 Aug 2026 15:13:05 +0000
    Gerrit-HasComments: No
    Gerrit-Has-Labels: Yes
    satisfied_requirement
    unsatisfied_requirement
    open
    diffy

    Antonio Alphonse (Gerrit)

    unread,
    Aug 3, 2026, 11:14:07 AM (10 days ago) Aug 3
    to rubber-...@appspot.gserviceaccount.com, android-bu...@system.gserviceaccount.com, Yichen Zhou, Chromium LUCI CQ, Thomas Anderson, Sadrul Chowdhury, chromium...@chromium.org, Henrique Ferreiro, max+watc...@igalia.com, ozone-...@chromium.org, nickdiego+wa...@igalia.com
    Attention needed from Thomas Anderson and Yichen Zhou

    Antonio Alphonse voted

    Auto-Submit+1
    Code-Review+0
    Gerrit-Comment-Date: Mon, 03 Aug 2026 15:13:58 +0000
    Gerrit-HasComments: No
    Gerrit-Has-Labels: Yes
    satisfied_requirement
    unsatisfied_requirement
    open
    diffy

    Antonio Alphonse (Gerrit)

    unread,
    Aug 3, 2026, 11:16:00 AM (10 days ago) Aug 3
    to rubber-...@appspot.gserviceaccount.com, android-bu...@system.gserviceaccount.com, Yichen Zhou, Chromium LUCI CQ, Thomas Anderson, Sadrul Chowdhury, chromium...@chromium.org, Henrique Ferreiro, max+watc...@igalia.com, ozone-...@chromium.org, nickdiego+wa...@igalia.com
    Attention needed from Thomas Anderson and Yichen Zhou

    Antonio Alphonse voted Owners-Override+1

    Owners-Override+1
    Open in Gerrit

    Related details

    Attention is currently required from:
    • Thomas Anderson
    • Yichen Zhou
    Submit Requirements:
    • requirement satisfiedCode-Coverage
    • requirement satisfiedCode-Owners
    • requirement satisfiedCode-Review
    • requirement satisfiedReview-Enforcement
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: comment
    Gerrit-Project: chromium/src
    Gerrit-Branch: main
    Gerrit-Change-Id: I6f07bbbf369e363a159be7c200a7a2d0909550e8
    Gerrit-Change-Number: 8186301
    Gerrit-PatchSet: 1
    Gerrit-Owner: Antonio Alphonse <alph...@google.com>
    Gerrit-Reviewer: Antonio Alphonse <alph...@google.com>
    Gerrit-Reviewer: Chromium LUCI CQ <chromiu...@luci-project-accounts.iam.gserviceaccount.com>
    Gerrit-Reviewer: Thomas Anderson <thomasa...@chromium.org>
    Gerrit-Reviewer: Yichen Zhou <yic...@chromium.org>
    Gerrit-CC: Henrique Ferreiro <hfer...@igalia.com>
    Gerrit-CC: Sadrul Chowdhury <sad...@chromium.org>
    Gerrit-Attention: Yichen Zhou <yic...@chromium.org>
    Gerrit-Attention: Thomas Anderson <thomasa...@chromium.org>
    Gerrit-Comment-Date: Mon, 03 Aug 2026 15:15:49 +0000
    Gerrit-HasComments: No
    Gerrit-Has-Labels: Yes
    satisfied_requirement
    open
    diffy

    Antonio Alphonse (Gerrit)

    unread,
    Aug 3, 2026, 11:30:24 AM (10 days ago) Aug 3
    to rubber-...@appspot.gserviceaccount.com, android-bu...@system.gserviceaccount.com, Yichen Zhou, Chromium LUCI CQ, Thomas Anderson, Sadrul Chowdhury, chromium...@chromium.org, Henrique Ferreiro, max+watc...@igalia.com, ozone-...@chromium.org, nickdiego+wa...@igalia.com
    Attention needed from Thomas Anderson and Yichen Zhou

    Antonio Alphonse voted Commit-Queue+2

    Commit-Queue+2
    Gerrit-Comment-Date: Mon, 03 Aug 2026 15:30:17 +0000
    Gerrit-HasComments: No
    Gerrit-Has-Labels: Yes
    satisfied_requirement
    open
    diffy

    Antonio Alphonse (Gerrit)

    unread,
    Aug 3, 2026, 12:40:34 PM (10 days ago) Aug 3
    to rubber-...@appspot.gserviceaccount.com, android-bu...@system.gserviceaccount.com, Yichen Zhou, Chromium LUCI CQ, Thomas Anderson, Sadrul Chowdhury, chromium...@chromium.org, Henrique Ferreiro, max+watc...@igalia.com, ozone-...@chromium.org, nickdiego+wa...@igalia.com
    Gerrit-Comment-Date: Mon, 03 Aug 2026 16:40:23 +0000
    Gerrit-HasComments: No
    Gerrit-Has-Labels: Yes
    satisfied_requirement
    open
    diffy

    Chromium LUCI CQ (Gerrit)

    unread,
    Aug 3, 2026, 1:10:58 PM (10 days ago) Aug 3
    to Antonio Alphonse, rubber-...@appspot.gserviceaccount.com, android-bu...@system.gserviceaccount.com, Yichen Zhou, Thomas Anderson, Sadrul Chowdhury, chromium...@chromium.org, Henrique Ferreiro, max+watc...@igalia.com, ozone-...@chromium.org, nickdiego+wa...@igalia.com

    Chromium LUCI CQ submitted the change

    Change information

    Commit message:
    Revert "Sanitize cursor theme name and size in GTK and Wayland"

    This reverts commit 283ac1ef12df16eb0256a4d5ce83477b5afba061.

    Reason for revert: Shards are failing on this unittest.

    Failure Link: https://chromium-swarm.appspot.com/task?id=79e075a72882a310&w=true

    Original change's description:
    > Sanitize cursor theme name and size in GTK and Wayland
    >
    > This change extends GtkSettingsSetProperty interceptor and GtkUi to
    > sanitize gtk-cursor-theme-name and gtk-cursor-theme-size at write-time,
    > preventing unsanitized cursor theme names from being set in GTK
    > settings.
    >
    > It also introduces unified ui::IsValidCursorThemeName and
    > ui::IsValidCursorThemeSize validation helpers in //ui/base/cursor, and
    > adds validation to WaylandCursorFactory to ensure invalid or
    > path-traversing cursor theme names are rejected before calling
    > wl_cursor_theme_load.
    >
    > Change-Id: Ibe8a3ce208d76d2e724902424491a6116d4352f6
    > Fixed: 540289900
    > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/8164559
    > Reviewed-by: Yichen Zhou <yic...@chromium.org>
    > Commit-Queue: Thomas Anderson <thomasa...@chromium.org>
    > Cr-Commit-Position: refs/heads/main@{#1670761}
    Bug: 540289900
    Change-Id: I6f07bbbf369e363a159be7c200a7a2d0909550e8
    Commit-Queue: Antonio Alphonse <alph...@google.com>
    Auto-Submit: Antonio Alphonse <alph...@google.com>
    Owners-Override: Antonio Alphonse <alph...@google.com>
    Cr-Commit-Position: refs/heads/main@{#1672739}
    Files:
    • M ui/base/cursor/cursor_factory.cc
    • M ui/base/cursor/cursor_factory.h
    • M ui/base/cursor/cursor_unittest.cc
    • M ui/base/x/x11_cursor_loader.cc
    • M ui/gtk/gtk_ui.cc
    • M ui/gtk/gtk_ui.h
    • M ui/gtk/gtk_util.cc
    • M ui/gtk/gtk_util.h
    • M ui/gtk/gtk_util_unittest.cc
    • M ui/ozone/platform/wayland/host/wayland_cursor_factory.cc
    Change size: M
    Delta: 10 files changed, 7 insertions(+), 161 deletions(-)
    Branch: refs/heads/main
    Submit Requirements:
    Open in Gerrit
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: merged
    Gerrit-Project: chromium/src
    Gerrit-Branch: main
    Gerrit-Change-Id: I6f07bbbf369e363a159be7c200a7a2d0909550e8
    Gerrit-Change-Number: 8186301
    Gerrit-PatchSet: 2
    open
    diffy
    satisfied_requirement
    Reply all
    Reply to author
    Forward
    0 new messages