ozone/wayland: Initialize WaylandBufferManagerGpu with bug fix ids [chromium/src : main]

0 views
Skip to first unread message

Eriko Kurimoto (Gerrit)

unread,
Sep 11, 2023, 10:44:33 PM9/11/23
to crostin...@chromium.org, ipc-securi...@chromium.org, ozone-...@chromium.org, yhanada+...@chromium.org

Attention is currently required from: Eliot Courtney, Eriko Kurimoto, Mitsuru Oshima.

Eriko Kurimoto uploaded patch set #8 to this change.

View Change

ozone/wayland: Initialize WaylandBufferManagerGpu with bug fix ids

This CL lets WaylandBufferManagerConenctor initialize
WaylandBufferManagerGpu with bug fix ids.

Bug fix ids are sent from the server asynchronously and stored in
zaura_shell, so it needs to wait until all bug fix ids are sent. We can confirm all bug fix ids are sent by receiving `bug_fix_done` event.

Bug: 1480226
Change-Id: Ie525d7912f3a47cd1278fcd5379b03122cb798f3
---
M ui/ozone/platform/wayland/gpu/wayland_buffer_manager_gpu.cc
M ui/ozone/platform/wayland/gpu/wayland_buffer_manager_gpu.h
M ui/ozone/platform/wayland/gpu/wayland_overlay_manager_unittest.cc
M ui/ozone/platform/wayland/gpu/wayland_surface_factory_unittest.cc
M ui/ozone/platform/wayland/host/wayland_buffer_manager_connector.cc
M ui/ozone/platform/wayland/host/wayland_buffer_manager_connector.h
M ui/ozone/platform/wayland/host/wayland_buffer_manager_host.cc
M ui/ozone/platform/wayland/host/wayland_buffer_manager_host.h
M ui/ozone/platform/wayland/host/wayland_window_unittest.cc
M ui/ozone/platform/wayland/host/wayland_zaura_shell.cc
M ui/ozone/platform/wayland/host/wayland_zaura_shell.h
M ui/ozone/platform/wayland/host/wayland_zaura_shell_unittest.cc
M ui/ozone/platform/wayland/host/wayland_zcr_color_manager_unittest.cc
M ui/ozone/platform/wayland/mojom/wayland_buffer_manager.mojom
M ui/ozone/platform/wayland/test/test_zaura_shell.cc
M ui/ozone/platform/wayland/test/test_zaura_shell.h
M ui/ozone/platform/wayland/wayland_buffer_manager_unittest.cc
17 files changed, 229 insertions(+), 32 deletions(-)

To view, visit change 4856179. To unsubscribe, or for help writing mail filters, visit settings.

Gerrit-MessageType: newpatchset
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: Ie525d7912f3a47cd1278fcd5379b03122cb798f3
Gerrit-Change-Number: 4856179
Gerrit-PatchSet: 8
Gerrit-Owner: Eriko Kurimoto <elk...@chromium.org>
Gerrit-Reviewer: Eliot Courtney <edcou...@chromium.org>
Gerrit-Reviewer: Eriko Kurimoto <elk...@chromium.org>
Gerrit-Reviewer: Mitsuru Oshima <osh...@chromium.org>
Gerrit-CC: Kramer Ge <fang...@chromium.org>
Gerrit-Attention: Eliot Courtney <edcou...@chromium.org>
Gerrit-Attention: Mitsuru Oshima <osh...@chromium.org>
Gerrit-Attention: Eriko Kurimoto <elk...@chromium.org>

Eriko Kurimoto (Gerrit)

unread,
Sep 11, 2023, 10:46:39 PM9/11/23
to crostin...@chromium.org, ipc-securi...@chromium.org, ozone-...@chromium.org, yhanada+...@chromium.org

Attention is currently required from: Eliot Courtney, Eriko Kurimoto, Mitsuru Oshima.

Eriko Kurimoto uploaded patch set #9 to this change.

View Change

The following approvals got outdated and were removed: Commit-Queue+1 by Eriko Kurimoto

Gerrit-PatchSet: 9
Gerrit-Owner: Eriko Kurimoto <elk...@chromium.org>
Gerrit-Reviewer: Eliot Courtney <edcou...@chromium.org>
Gerrit-Reviewer: Eriko Kurimoto <elk...@chromium.org>
Gerrit-Reviewer: Mitsuru Oshima <osh...@chromium.org>
Gerrit-CC: Kramer Ge <fang...@chromium.org>

Eriko Kurimoto (Gerrit)

unread,
Sep 11, 2023, 10:47:34 PM9/11/23
to crostin...@chromium.org, ipc-securi...@chromium.org, ozone-...@chromium.org, yhanada+...@chromium.org, Tricium, Eliot Courtney, Mitsuru Oshima, Chromium LUCI CQ, chromium...@chromium.org

Attention is currently required from: Eliot Courtney, Mitsuru Oshima.

Patch set 9:Commit-Queue +1

View Change

1 comment:

To view, visit change 4856179. To unsubscribe, or for help writing mail filters, visit settings.

Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: Ie525d7912f3a47cd1278fcd5379b03122cb798f3
Gerrit-Change-Number: 4856179
Gerrit-PatchSet: 9
Gerrit-Owner: Eriko Kurimoto <elk...@chromium.org>
Gerrit-Reviewer: Eliot Courtney <edcou...@chromium.org>
Gerrit-Reviewer: Eriko Kurimoto <elk...@chromium.org>
Gerrit-Reviewer: Mitsuru Oshima <osh...@chromium.org>
Gerrit-CC: Kramer Ge <fang...@chromium.org>
Gerrit-Attention: Eliot Courtney <edcou...@chromium.org>
Gerrit-Attention: Mitsuru Oshima <osh...@chromium.org>
Gerrit-Comment-Date: Tue, 12 Sep 2023 02:47:24 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes

Eriko Kurimoto (Gerrit)

unread,
Sep 11, 2023, 11:28:45 PM9/11/23
to crostin...@chromium.org, ipc-securi...@chromium.org, ozone-...@chromium.org, yhanada+...@chromium.org

Attention is currently required from: Eliot Courtney, Eriko Kurimoto, Mitsuru Oshima.

Eriko Kurimoto uploaded patch set #11 to this change.

View Change

The following approvals got outdated and were removed: Commit-Queue+1 by Eriko Kurimoto

ozone/wayland: Initialize WaylandBufferManagerGpu with bug fix ids

This CL lets WaylandBufferManagerConnector initialize

WaylandBufferManagerGpu with bug fix ids.

Bug fix ids are sent from the server asynchronously and stored in
zaura_shell, so it needs to wait until all bug fix ids are sent. We can confirm all bug fix ids are sent by receiving `bug_fix_done` event.

Bug: 1480226
Change-Id: Ie525d7912f3a47cd1278fcd5379b03122cb798f3
---
M ui/ozone/platform/wayland/gpu/wayland_buffer_manager_gpu.cc
M ui/ozone/platform/wayland/gpu/wayland_buffer_manager_gpu.h
M ui/ozone/platform/wayland/gpu/wayland_overlay_manager_unittest.cc
M ui/ozone/platform/wayland/gpu/wayland_surface_factory_unittest.cc
M ui/ozone/platform/wayland/host/wayland_buffer_manager_connector.cc
M ui/ozone/platform/wayland/host/wayland_buffer_manager_connector.h
M ui/ozone/platform/wayland/host/wayland_buffer_manager_host.cc
M ui/ozone/platform/wayland/host/wayland_buffer_manager_host.h
M ui/ozone/platform/wayland/host/wayland_window_unittest.cc
M ui/ozone/platform/wayland/host/wayland_zaura_shell.cc
M ui/ozone/platform/wayland/host/wayland_zaura_shell.h
M ui/ozone/platform/wayland/host/wayland_zaura_shell_unittest.cc
M ui/ozone/platform/wayland/host/wayland_zcr_color_manager_unittest.cc
M ui/ozone/platform/wayland/mojom/wayland_buffer_manager.mojom
M ui/ozone/platform/wayland/test/test_zaura_shell.cc
M ui/ozone/platform/wayland/test/test_zaura_shell.h
M ui/ozone/platform/wayland/wayland_buffer_manager_unittest.cc
17 files changed, 227 insertions(+), 32 deletions(-)

To view, visit change 4856179. To unsubscribe, or for help writing mail filters, visit settings.

Gerrit-MessageType: newpatchset
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: Ie525d7912f3a47cd1278fcd5379b03122cb798f3
Gerrit-Change-Number: 4856179
Gerrit-PatchSet: 11
Gerrit-Owner: Eriko Kurimoto <elk...@chromium.org>
Gerrit-Reviewer: Eliot Courtney <edcou...@chromium.org>
Gerrit-Reviewer: Eriko Kurimoto <elk...@chromium.org>
Gerrit-Reviewer: Mitsuru Oshima <osh...@chromium.org>
Gerrit-CC: Kramer Ge <fang...@chromium.org>
Gerrit-Attention: Eliot Courtney <edcou...@chromium.org>
Gerrit-Attention: Mitsuru Oshima <osh...@chromium.org>
Gerrit-Attention: Eriko Kurimoto <elk...@chromium.org>

Eliot Courtney (Gerrit)

unread,
Sep 12, 2023, 2:30:59 AM9/12/23
to Eriko Kurimoto, crostin...@chromium.org, ipc-securi...@chromium.org, ozone-...@chromium.org, yhanada+...@chromium.org, Tricium, Mitsuru Oshima, Chromium LUCI CQ, chromium...@chromium.org

Attention is currently required from: Eriko Kurimoto, Mitsuru Oshima.

View Change

5 comments:

  • File ui/ozone/platform/wayland/gpu/wayland_surface_factory_unittest.cc:

    • Patch Set #10, Line 202: kBugFixId

      in general nice to give a descriptive name for bug constants, like kBugFreezeTimer or something like that

  • File ui/ozone/platform/wayland/host/wayland_buffer_manager_host.h:

  • File ui/ozone/platform/wayland/host/wayland_zaura_shell.cc:

    • Patch Set #11, Line 29: std::vector<uint32_t> ConvertFlatSetIntoVector(

      nit: can you just call vector with begin(), end()?

  • File ui/ozone/platform/wayland/test/test_zaura_shell.h:

    • Patch Set #11, Line 33: MaybeSendAllBugFixesSent

      nit: I think we don't need 'maybe' here, since it's not deciding based on current state, it's just about protocol version.

To view, visit change 4856179. To unsubscribe, or for help writing mail filters, visit settings.

Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: Ie525d7912f3a47cd1278fcd5379b03122cb798f3
Gerrit-Change-Number: 4856179
Gerrit-PatchSet: 11
Gerrit-Owner: Eriko Kurimoto <elk...@chromium.org>
Gerrit-Reviewer: Eliot Courtney <edcou...@chromium.org>
Gerrit-Reviewer: Eriko Kurimoto <elk...@chromium.org>
Gerrit-Reviewer: Mitsuru Oshima <osh...@chromium.org>
Gerrit-CC: Kramer Ge <fang...@chromium.org>
Gerrit-Attention: Mitsuru Oshima <osh...@chromium.org>
Gerrit-Attention: Eriko Kurimoto <elk...@chromium.org>
Gerrit-Comment-Date: Tue, 12 Sep 2023 06:30:49 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No

Eriko Kurimoto (Gerrit)

unread,
Sep 13, 2023, 1:30:04 AM9/13/23
to crostin...@chromium.org, ipc-securi...@chromium.org, ozone-...@chromium.org, yhanada+...@chromium.org

Attention is currently required from: Eriko Kurimoto, Mitsuru Oshima.

Eriko Kurimoto uploaded patch set #12 to this change.

View Change

ozone/wayland: Initialize WaylandBufferManagerGpu with bug fix ids
17 files changed, 232 insertions(+), 37 deletions(-)

To view, visit change 4856179. To unsubscribe, or for help writing mail filters, visit settings.

Gerrit-MessageType: newpatchset
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: Ie525d7912f3a47cd1278fcd5379b03122cb798f3
Gerrit-Change-Number: 4856179
Gerrit-PatchSet: 12

Eriko Kurimoto (Gerrit)

unread,
Sep 13, 2023, 1:30:15 AM9/13/23
to crostin...@chromium.org, ipc-securi...@chromium.org, ozone-...@chromium.org, yhanada+...@chromium.org, Tricium, Eliot Courtney, Mitsuru Oshima, Chromium LUCI CQ, chromium...@chromium.org

Attention is currently required from: Eliot Courtney, Mitsuru Oshima.

Patch set 12:Commit-Queue +1

View Change

5 comments:

  • File ui/ozone/platform/wayland/gpu/wayland_surface_factory_unittest.cc:

    • in general nice to give a descriptive name for bug constants, like kBugFreezeTimer or something like […]

      Done

  • File ui/ozone/platform/wayland/host/wayland_buffer_manager_host.h:

    • Done

    • Done

  • File ui/ozone/platform/wayland/host/wayland_zaura_shell.cc:

    • Patch Set #11, Line 29: std::vector<uint32_t> ConvertFlatSetIntoVector(

      nit: can you just call vector with begin(), end()?

    • Done

  • File ui/ozone/platform/wayland/test/test_zaura_shell.h:

    • nit: I think we don't need 'maybe' here, since it's not deciding based on current state, it's just a […]

      Updating MaybeSendBugFixes naming as well.

To view, visit change 4856179. To unsubscribe, or for help writing mail filters, visit settings.

Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: Ie525d7912f3a47cd1278fcd5379b03122cb798f3
Gerrit-Change-Number: 4856179
Gerrit-PatchSet: 12
Gerrit-Owner: Eriko Kurimoto <elk...@chromium.org>
Gerrit-Reviewer: Eliot Courtney <edcou...@chromium.org>
Gerrit-Reviewer: Eriko Kurimoto <elk...@chromium.org>
Gerrit-Reviewer: Mitsuru Oshima <osh...@chromium.org>
Gerrit-CC: Kramer Ge <fang...@chromium.org>
Gerrit-Attention: Eliot Courtney <edcou...@chromium.org>
Gerrit-Attention: Mitsuru Oshima <osh...@chromium.org>
Gerrit-Comment-Date: Wed, 13 Sep 2023 05:30:02 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Comment-In-Reply-To: Eliot Courtney <edcou...@chromium.org>

Eliot Courtney (Gerrit)

unread,
Sep 13, 2023, 1:41:54 AM9/13/23
to Eriko Kurimoto, crostin...@chromium.org, ipc-securi...@chromium.org, ozone-...@chromium.org, yhanada+...@chromium.org, Tricium, Mitsuru Oshima, Chromium LUCI CQ, chromium...@chromium.org

Attention is currently required from: Eriko Kurimoto, Mitsuru Oshima.

View Change

3 comments:

  • Commit Message:

    • Patch Set #12, Line 13: zaura_shell, so it needs to wait until all bug fix ids are sent. We can confirm all bug fix ids are sent by receiving `bug_fix_done` event.

      nit: fix wrapping

  • File ui/ozone/platform/wayland/gpu/wayland_surface_factory_unittest.cc:

    • Patch Set #12, Line 202: kFreezeTimerBugId

      nit: unless there is already a convention otherwise, it's probably better to say kBugId* since then all the bug id constants will sort next to eachother + be easier to read (IMO)

  • File ui/ozone/platform/wayland/test/test_zaura_shell.h:

    • Updating MaybeSendBugFixes naming as well.

      I see there's another function called MaybeSendCompositorVersion, it would have been okay to push back based on the file convention IMO.

To view, visit change 4856179. To unsubscribe, or for help writing mail filters, visit settings.

Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: Ie525d7912f3a47cd1278fcd5379b03122cb798f3
Gerrit-Change-Number: 4856179
Gerrit-PatchSet: 12
Gerrit-Owner: Eriko Kurimoto <elk...@chromium.org>
Gerrit-Reviewer: Eliot Courtney <edcou...@chromium.org>
Gerrit-Reviewer: Eriko Kurimoto <elk...@chromium.org>
Gerrit-Reviewer: Mitsuru Oshima <osh...@chromium.org>
Gerrit-CC: Kramer Ge <fang...@chromium.org>
Gerrit-Attention: Mitsuru Oshima <osh...@chromium.org>
Gerrit-Attention: Eriko Kurimoto <elk...@chromium.org>
Gerrit-Comment-Date: Wed, 13 Sep 2023 05:41:40 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Eliot Courtney <edcou...@chromium.org>
Comment-In-Reply-To: Eriko Kurimoto <elk...@chromium.org>

Eliot Courtney (Gerrit)

unread,
Sep 13, 2023, 1:42:23 AM9/13/23
to Eriko Kurimoto, crostin...@chromium.org, ipc-securi...@chromium.org, ozone-...@chromium.org, yhanada+...@chromium.org, Tricium, Mitsuru Oshima, Chromium LUCI CQ, chromium...@chromium.org

Attention is currently required from: Eriko Kurimoto, Mitsuru Oshima.

Patch set 12:Code-Review +1

View Change

1 comment:

  • Patchset:

    • Patch Set #12:

      please wait for review from oshima@, plus you are missing some owners

To view, visit change 4856179. To unsubscribe, or for help writing mail filters, visit settings.

Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: Ie525d7912f3a47cd1278fcd5379b03122cb798f3
Gerrit-Change-Number: 4856179
Gerrit-PatchSet: 12
Gerrit-Owner: Eriko Kurimoto <elk...@chromium.org>
Gerrit-Reviewer: Eliot Courtney <edcou...@chromium.org>
Gerrit-Reviewer: Eriko Kurimoto <elk...@chromium.org>
Gerrit-Reviewer: Mitsuru Oshima <osh...@chromium.org>
Gerrit-CC: Kramer Ge <fang...@chromium.org>
Gerrit-Attention: Mitsuru Oshima <osh...@chromium.org>
Gerrit-Attention: Eriko Kurimoto <elk...@chromium.org>
Gerrit-Comment-Date: Wed, 13 Sep 2023 05:42:11 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes

Eriko Kurimoto (Gerrit)

unread,
Sep 13, 2023, 1:43:13 AM9/13/23
to Chromium IPC Reviews, crostin...@chromium.org, ipc-securi...@chromium.org, ozone-...@chromium.org, yhanada+...@chromium.org, Eliot Courtney, Mitsuru Oshima

Attention is currently required from: Chromium IPC Reviews, Mitsuru Oshima.

Eriko Kurimoto would like Chromium IPC Reviews to review this change.

View Change

ozone/wayland: Initialize WaylandBufferManagerGpu with bug fix ids

This CL lets WaylandBufferManagerConnector initialize
WaylandBufferManagerGpu with bug fix ids.

Bug fix ids are sent from the server asynchronously and stored in
zaura_shell, so it needs to wait until all bug fix ids are sent. We can confirm all bug fix ids are sent by receiving `bug_fix_done` event.

Bug: 1480226
Change-Id: Ie525d7912f3a47cd1278fcd5379b03122cb798f3
---
M ui/ozone/platform/wayland/gpu/wayland_buffer_manager_gpu.cc
M ui/ozone/platform/wayland/gpu/wayland_buffer_manager_gpu.h
M ui/ozone/platform/wayland/gpu/wayland_overlay_manager_unittest.cc
M ui/ozone/platform/wayland/gpu/wayland_surface_factory_unittest.cc
M ui/ozone/platform/wayland/host/wayland_buffer_manager_connector.cc
M ui/ozone/platform/wayland/host/wayland_buffer_manager_connector.h
M ui/ozone/platform/wayland/host/wayland_buffer_manager_host.cc
M ui/ozone/platform/wayland/host/wayland_buffer_manager_host.h
M ui/ozone/platform/wayland/host/wayland_window_unittest.cc
M ui/ozone/platform/wayland/host/wayland_zaura_shell.cc
M ui/ozone/platform/wayland/host/wayland_zaura_shell.h
M ui/ozone/platform/wayland/host/wayland_zaura_shell_unittest.cc
M ui/ozone/platform/wayland/host/wayland_zcr_color_manager_unittest.cc
M ui/ozone/platform/wayland/mojom/wayland_buffer_manager.mojom
M ui/ozone/platform/wayland/test/test_zaura_shell.cc
M ui/ozone/platform/wayland/test/test_zaura_shell.h
M ui/ozone/platform/wayland/wayland_buffer_manager_unittest.cc
17 files changed, 232 insertions(+), 37 deletions(-)


To view, visit change 4856179. To unsubscribe, or for help writing mail filters, visit settings.

Gerrit-MessageType: newchange
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: Ie525d7912f3a47cd1278fcd5379b03122cb798f3
Gerrit-Change-Number: 4856179
Gerrit-PatchSet: 12
Gerrit-Owner: Eriko Kurimoto <elk...@chromium.org>
Gerrit-Reviewer: Chromium IPC Reviews <chrome-ip...@google.com>
Gerrit-Reviewer: Eliot Courtney <edcou...@chromium.org>
Gerrit-Reviewer: Eriko Kurimoto <elk...@chromium.org>
Gerrit-Reviewer: Mitsuru Oshima <osh...@chromium.org>
Gerrit-CC: Kramer Ge <fang...@chromium.org>
Gerrit-Attention: Chromium IPC Reviews <chrome-ip...@google.com>
Gerrit-Attention: Mitsuru Oshima <osh...@chromium.org>

gwsq (Gerrit)

unread,
Sep 13, 2023, 1:47:07 AM9/13/23
to Giovanni Ortuno Urquidi, crostin...@chromium.org, ipc-securi...@chromium.org, ozone-...@chromium.org, yhanada+...@chromium.org, Eriko Kurimoto, Chromium IPC Reviews, Eliot Courtney, Mitsuru Oshima

Attention is currently required from: Chromium IPC Reviews, Giovanni Ortuno Urquidi, Mitsuru Oshima.

gwsq would like Giovanni Ortuno Urquidi to review this change authored by Eriko Kurimoto.

Gerrit-Reviewer: Giovanni Ortuno Urquidi <ort...@chromium.org>
Gerrit-Reviewer: Mitsuru Oshima <osh...@chromium.org>
Gerrit-CC: Kramer Ge <fang...@chromium.org>
Gerrit-Attention: Giovanni Ortuno Urquidi <ort...@chromium.org>

gwsq (Gerrit)

unread,
Sep 13, 2023, 1:47:11 AM9/13/23
to crostin...@chromium.org, ipc-securi...@chromium.org, ozone-...@chromium.org, yhanada+...@chromium.org, Chromium IPC Reviews, Eriko Kurimoto, Giovanni Ortuno Urquidi, Eliot Courtney, Mitsuru Oshima

Attention is currently required from: Giovanni Ortuno Urquidi, Mitsuru Oshima.

Eriko Kurimoto has uploaded this change for review.

Gerrit-Reviewer: Eliot Courtney <edcou...@chromium.org>
Gerrit-Reviewer: Eriko Kurimoto <elk...@chromium.org>
Gerrit-Reviewer: Giovanni Ortuno Urquidi <ort...@chromium.org>
Gerrit-Reviewer: Mitsuru Oshima <osh...@chromium.org>
Gerrit-CC: Chromium IPC Reviews <chrome-ip...@google.com>
Gerrit-CC: Kramer Ge <fang...@chromium.org>
Gerrit-Attention: Giovanni Ortuno Urquidi <ort...@chromium.org>
Gerrit-Attention: Mitsuru Oshima <osh...@chromium.org>

gwsq (Gerrit)

unread,
Sep 13, 2023, 1:47:20 AM9/13/23
to Eriko Kurimoto, crostin...@chromium.org, ipc-securi...@chromium.org, ozone-...@chromium.org, yhanada+...@chromium.org, Chromium IPC Reviews, Giovanni Ortuno Urquidi, Eliot Courtney, Tricium, Mitsuru Oshima, Chromium LUCI CQ, chromium...@chromium.org

Attention is currently required from: Giovanni Ortuno Urquidi, Mitsuru Oshima.

From googleclient/chrome/chromium_gwsq/ipc/config.gwsq:
IPC: ort...@chromium.org

📎 It looks like you’re making a possibly security-sensitive change! 📎 IPC security review isn’t a rubberstamp, so your friendly security reviewer will need a fair amount of context to review your CL effectively. Please review your CL description and code comments to make sure they provide context for someone unfamiliar with your project/area. Pay special attention to where data comes from and which processes it flows between (and their privilege levels). Feel free to point your security reviewer at design docs, bugs, or other links if you can’t reasonably make a self-contained CL description. (Also see https://cbea.ms/git-commit/).

IPC reviewer(s): ort...@chromium.org


Reviewer source(s):
ort...@chromium.org is from context(googleclient/chrome/chromium_gwsq/ipc/config.gwsq)

View Change

    To view, visit change 4856179. To unsubscribe, or for help writing mail filters, visit settings.

    Gerrit-MessageType: comment
    Gerrit-Project: chromium/src
    Gerrit-Branch: main
    Gerrit-Change-Id: Ie525d7912f3a47cd1278fcd5379b03122cb798f3
    Gerrit-Change-Number: 4856179
    Gerrit-PatchSet: 12
    Gerrit-Owner: Eriko Kurimoto <elk...@chromium.org>
    Gerrit-Reviewer: Eliot Courtney <edcou...@chromium.org>
    Gerrit-Reviewer: Eriko Kurimoto <elk...@chromium.org>
    Gerrit-Reviewer: Giovanni Ortuno Urquidi <ort...@chromium.org>
    Gerrit-Reviewer: Mitsuru Oshima <osh...@chromium.org>
    Gerrit-CC: Chromium IPC Reviews <chrome-ip...@google.com>
    Gerrit-CC: Kramer Ge <fang...@chromium.org>
    Gerrit-CC: gwsq
    Gerrit-Attention: Giovanni Ortuno Urquidi <ort...@chromium.org>
    Gerrit-Attention: Mitsuru Oshima <osh...@chromium.org>
    Gerrit-Comment-Date: Wed, 13 Sep 2023 05:47:09 +0000
    Gerrit-HasComments: No
    Gerrit-Has-Labels: No

    Giovanni Ortuno Urquidi (Gerrit)

    unread,
    Sep 13, 2023, 1:50:17 AM9/13/23
    to Eriko Kurimoto, crostin...@chromium.org, ipc-securi...@chromium.org, ozone-...@chromium.org, yhanada+...@chromium.org, Chromium IPC Reviews, Giovanni Ortuno Urquidi, Eliot Courtney, Tricium, Mitsuru Oshima, Chromium LUCI CQ, chromium...@chromium.org

    Attention is currently required from: Eriko Kurimoto, Mitsuru Oshima.

    View Change

    2 comments:

    • Patchset:

    • File ui/ozone/platform/wayland/mojom/wayland_buffer_manager.mojom:

      • Patch Set #12, Line 100: interface WaylandBufferManagerGpu {

        IIUC, this interface is implemented by the GPU and used by the browser. Is that correct? If so, could we add a comment to clarify?

    To view, visit change 4856179. To unsubscribe, or for help writing mail filters, visit settings.

    Gerrit-MessageType: comment
    Gerrit-Project: chromium/src
    Gerrit-Branch: main
    Gerrit-Change-Id: Ie525d7912f3a47cd1278fcd5379b03122cb798f3
    Gerrit-Change-Number: 4856179
    Gerrit-PatchSet: 12
    Gerrit-Owner: Eriko Kurimoto <elk...@chromium.org>
    Gerrit-Reviewer: Eliot Courtney <edcou...@chromium.org>
    Gerrit-Reviewer: Eriko Kurimoto <elk...@chromium.org>
    Gerrit-Reviewer: Giovanni Ortuno Urquidi <ort...@chromium.org>
    Gerrit-Reviewer: Mitsuru Oshima <osh...@chromium.org>
    Gerrit-CC: Chromium IPC Reviews <chrome-ip...@google.com>
    Gerrit-CC: Kramer Ge <fang...@chromium.org>
    Gerrit-CC: gwsq
    Gerrit-Attention: Mitsuru Oshima <osh...@chromium.org>
    Gerrit-Attention: Eriko Kurimoto <elk...@chromium.org>
    Gerrit-Comment-Date: Wed, 13 Sep 2023 05:50:03 +0000
    Gerrit-HasComments: Yes
    Gerrit-Has-Labels: No

    Eriko Kurimoto (Gerrit)

    unread,
    Sep 13, 2023, 1:51:34 AM9/13/23
    to crostin...@chromium.org, ipc-securi...@chromium.org, ozone-...@chromium.org, yhanada+...@chromium.org

    Attention is currently required from: Eriko Kurimoto, Mitsuru Oshima.

    Eriko Kurimoto uploaded patch set #13 to this change.

    To view, visit change 4856179. To unsubscribe, or for help writing mail filters, visit settings.

    Gerrit-MessageType: newpatchset
    Gerrit-Project: chromium/src
    Gerrit-Branch: main
    Gerrit-Change-Id: Ie525d7912f3a47cd1278fcd5379b03122cb798f3
    Gerrit-Change-Number: 4856179
    Gerrit-PatchSet: 13

    Eriko Kurimoto (Gerrit)

    unread,
    Sep 13, 2023, 2:03:21 AM9/13/23
    to crostin...@chromium.org, ipc-securi...@chromium.org, ozone-...@chromium.org, yhanada+...@chromium.org

    Attention is currently required from: Eriko Kurimoto, Mitsuru Oshima.

    Eriko Kurimoto uploaded patch set #14 to this change.

    View Change

    The following approvals got outdated and were removed: Commit-Queue+1 by Eriko Kurimoto

    ozone/wayland: Initialize WaylandBufferManagerGpu with bug fix ids
    17 files changed, 234 insertions(+), 40 deletions(-)

    To view, visit change 4856179. To unsubscribe, or for help writing mail filters, visit settings.

    Gerrit-MessageType: newpatchset
    Gerrit-Project: chromium/src
    Gerrit-Branch: main
    Gerrit-Change-Id: Ie525d7912f3a47cd1278fcd5379b03122cb798f3
    Gerrit-Change-Number: 4856179
    Gerrit-PatchSet: 14

    Eriko Kurimoto (Gerrit)

    unread,
    Sep 13, 2023, 2:03:33 AM9/13/23
    to crostin...@chromium.org, ipc-securi...@chromium.org, ozone-...@chromium.org, yhanada+...@chromium.org, Chromium IPC Reviews, Giovanni Ortuno Urquidi, Eliot Courtney, Tricium, Mitsuru Oshima, Chromium LUCI CQ, chromium...@chromium.org

    Attention is currently required from: Giovanni Ortuno Urquidi, Mitsuru Oshima.

    Patch set 14:Commit-Queue +1

    View Change

    3 comments:

    • Commit Message:

      • Patch Set #12, Line 13: zaura_shell, so it needs to wait until all bug fix ids are sent. We can confirm all bug fix ids are sent by receiving `bug_fix_done` event.

        nit: fix wrapping

        Done

    • File ui/ozone/platform/wayland/gpu/wayland_surface_factory_unittest.cc:

      • nit: unless there is already a convention otherwise, it's probably better to say kBugId* since then […]

        Done

    • File ui/ozone/platform/wayland/mojom/wayland_buffer_manager.mojom:

      •  this interface is implemented by the GPU and used by the browser. Is that correct? 

        Yes, it's correct.
        Added a comment for clarification.

    To view, visit change 4856179. To unsubscribe, or for help writing mail filters, visit settings.

    Gerrit-MessageType: comment
    Gerrit-Project: chromium/src
    Gerrit-Branch: main
    Gerrit-Change-Id: Ie525d7912f3a47cd1278fcd5379b03122cb798f3
    Gerrit-Change-Number: 4856179
    Gerrit-PatchSet: 14
    Gerrit-Owner: Eriko Kurimoto <elk...@chromium.org>
    Gerrit-Reviewer: Eliot Courtney <edcou...@chromium.org>
    Gerrit-Reviewer: Eriko Kurimoto <elk...@chromium.org>
    Gerrit-Reviewer: Giovanni Ortuno Urquidi <ort...@chromium.org>
    Gerrit-Reviewer: Mitsuru Oshima <osh...@chromium.org>
    Gerrit-CC: Chromium IPC Reviews <chrome-ip...@google.com>
    Gerrit-CC: Kramer Ge <fang...@chromium.org>
    Gerrit-CC: gwsq
    Gerrit-Attention: Giovanni Ortuno Urquidi <ort...@chromium.org>
    Gerrit-Attention: Mitsuru Oshima <osh...@chromium.org>
    Gerrit-Comment-Date: Wed, 13 Sep 2023 06:03:19 +0000
    Gerrit-HasComments: Yes
    Gerrit-Has-Labels: Yes
    Comment-In-Reply-To: Eliot Courtney <edcou...@chromium.org>
    Comment-In-Reply-To: Giovanni Ortuno Urquidi <ort...@chromium.org>

    Mitsuru Oshima (Gerrit)

    unread,
    Sep 13, 2023, 4:21:00 AM9/13/23
    to Eriko Kurimoto, crostin...@chromium.org, ipc-securi...@chromium.org, ozone-...@chromium.org, yhanada+...@chromium.org, Chromium IPC Reviews, Giovanni Ortuno Urquidi, Eliot Courtney, Tricium, Chromium LUCI CQ, chromium...@chromium.org

    Attention is currently required from: Eriko Kurimoto, Giovanni Ortuno Urquidi.

    Patch set 14:Code-Review +1

    View Change

    2 comments:

    • File ui/ozone/platform/wayland/host/wayland_zaura_shell.cc:

      • Patch Set #14, Line 124: bug_fix_ids_.end());

        bug_fix_ids_ should probably be just vector to avoid conversions. (flat set is vector internally anyway)

    • File ui/ozone/platform/wayland/test/test_zaura_shell.cc:

    To view, visit change 4856179. To unsubscribe, or for help writing mail filters, visit settings.

    Gerrit-MessageType: comment
    Gerrit-Project: chromium/src
    Gerrit-Branch: main
    Gerrit-Change-Id: Ie525d7912f3a47cd1278fcd5379b03122cb798f3
    Gerrit-Change-Number: 4856179
    Gerrit-PatchSet: 14
    Gerrit-Owner: Eriko Kurimoto <elk...@chromium.org>
    Gerrit-Reviewer: Eliot Courtney <edcou...@chromium.org>
    Gerrit-Reviewer: Eriko Kurimoto <elk...@chromium.org>
    Gerrit-Reviewer: Giovanni Ortuno Urquidi <ort...@chromium.org>
    Gerrit-Reviewer: Mitsuru Oshima <osh...@chromium.org>
    Gerrit-CC: Chromium IPC Reviews <chrome-ip...@google.com>
    Gerrit-CC: Kramer Ge <fang...@chromium.org>
    Gerrit-CC: gwsq
    Gerrit-Attention: Giovanni Ortuno Urquidi <ort...@chromium.org>
    Gerrit-Attention: Eriko Kurimoto <elk...@chromium.org>
    Gerrit-Comment-Date: Wed, 13 Sep 2023 08:20:49 +0000
    Gerrit-HasComments: Yes
    Gerrit-Has-Labels: Yes

    Eriko Kurimoto (Gerrit)

    unread,
    Sep 13, 2023, 9:48:28 AM9/13/23
    to crostin...@chromium.org, ipc-securi...@chromium.org, ozone-...@chromium.org, yhanada+...@chromium.org

    Attention is currently required from: Eriko Kurimoto, Giovanni Ortuno Urquidi.

    Eriko Kurimoto uploaded patch set #15 to this change.

    View Change

    ozone/wayland: Initialize WaylandBufferManagerGpu with bug fix ids


    This CL lets WaylandBufferManagerConnector initialize
    WaylandBufferManagerGpu with bug fix ids.

    Bug fix ids are sent from the server asynchronously and stored in
    zaura_shell, so it needs to wait until all bug fix ids are sent. We can
    confirm all bug fix ids are sent by receiving `bug_fix_done` event.

    Bug: 1480226
    Change-Id: Ie525d7912f3a47cd1278fcd5379b03122cb798f3
    ---
    M ui/ozone/platform/wayland/gpu/wayland_buffer_manager_gpu.cc
    M ui/ozone/platform/wayland/gpu/wayland_buffer_manager_gpu.h
    M ui/ozone/platform/wayland/gpu/wayland_overlay_manager_unittest.cc
    M ui/ozone/platform/wayland/gpu/wayland_surface_factory_unittest.cc
    M ui/ozone/platform/wayland/host/wayland_buffer_manager_connector.cc
    M ui/ozone/platform/wayland/host/wayland_buffer_manager_connector.h
    M ui/ozone/platform/wayland/host/wayland_buffer_manager_host.cc
    M ui/ozone/platform/wayland/host/wayland_buffer_manager_host.h
    M ui/ozone/platform/wayland/host/wayland_window_unittest.cc
    M ui/ozone/platform/wayland/host/wayland_zaura_shell.cc
    M ui/ozone/platform/wayland/host/wayland_zaura_shell.h
    M ui/ozone/platform/wayland/host/wayland_zaura_shell_unittest.cc
    M ui/ozone/platform/wayland/host/wayland_zcr_color_manager_unittest.cc
    M ui/ozone/platform/wayland/mojom/wayland_buffer_manager.mojom
    M ui/ozone/platform/wayland/test/test_zaura_shell.cc
    M ui/ozone/platform/wayland/test/test_zaura_shell.h
    M ui/ozone/platform/wayland/wayland_buffer_manager_unittest.cc
    17 files changed, 233 insertions(+), 44 deletions(-)

    To view, visit change 4856179. To unsubscribe, or for help writing mail filters, visit settings.

    Gerrit-MessageType: newpatchset
    Gerrit-Project: chromium/src
    Gerrit-Branch: main
    Gerrit-Change-Id: Ie525d7912f3a47cd1278fcd5379b03122cb798f3
    Gerrit-Change-Number: 4856179
    Gerrit-PatchSet: 15

    Eriko Kurimoto (Gerrit)

    unread,
    Sep 13, 2023, 9:52:40 AM9/13/23
    to crostin...@chromium.org, ipc-securi...@chromium.org, ozone-...@chromium.org, yhanada+...@chromium.org, Mitsuru Oshima, Chromium IPC Reviews, Giovanni Ortuno Urquidi, Eliot Courtney, Tricium, Chromium LUCI CQ, chromium...@chromium.org

    Attention is currently required from: Giovanni Ortuno Urquidi, Mitsuru Oshima.

    Patch set 15:Commit-Queue +1

    View Change

    3 comments:

    • Patchset:

      • Oshima +1ed. PTAL again.

    • File ui/ozone/platform/wayland/host/wayland_zaura_shell.cc:

      • bug_fix_ids_ should probably be just vector to avoid conversions. […]

        Agree, changing it to vector.
        (In theory, HasBugFix uses lookup and it's faster on flat_set, but we can assume the bug fix ids are small so it's fine).

    • File ui/ozone/platform/wayland/test/test_zaura_shell.cc:

      • GlobalObject::Bind may set a version, so it's needed. (I also added it in OnBind call)

    To view, visit change 4856179. To unsubscribe, or for help writing mail filters, visit settings.

    Gerrit-MessageType: comment
    Gerrit-Project: chromium/src
    Gerrit-Branch: main
    Gerrit-Change-Id: Ie525d7912f3a47cd1278fcd5379b03122cb798f3
    Gerrit-Change-Number: 4856179
    Gerrit-PatchSet: 15
    Gerrit-Owner: Eriko Kurimoto <elk...@chromium.org>
    Gerrit-Reviewer: Eliot Courtney <edcou...@chromium.org>
    Gerrit-Reviewer: Eriko Kurimoto <elk...@chromium.org>
    Gerrit-Reviewer: Giovanni Ortuno Urquidi <ort...@chromium.org>
    Gerrit-Reviewer: Mitsuru Oshima <osh...@chromium.org>
    Gerrit-CC: Chromium IPC Reviews <chrome-ip...@google.com>
    Gerrit-CC: Kramer Ge <fang...@chromium.org>
    Gerrit-CC: gwsq
    Gerrit-Attention: Giovanni Ortuno Urquidi <ort...@chromium.org>
    Gerrit-Attention: Mitsuru Oshima <osh...@chromium.org>
    Gerrit-Comment-Date: Wed, 13 Sep 2023 13:52:23 +0000
    Gerrit-HasComments: Yes
    Gerrit-Has-Labels: Yes
    Comment-In-Reply-To: Giovanni Ortuno Urquidi <ort...@chromium.org>
    Comment-In-Reply-To: Mitsuru Oshima <osh...@chromium.org>

    Eliot Courtney (Gerrit)

    unread,
    Sep 13, 2023, 9:56:45 AM9/13/23
    to Eriko Kurimoto, crostin...@chromium.org, ipc-securi...@chromium.org, ozone-...@chromium.org, yhanada+...@chromium.org, Mitsuru Oshima, Chromium IPC Reviews, Giovanni Ortuno Urquidi, Tricium, Chromium LUCI CQ, chromium...@chromium.org

    Attention is currently required from: Eriko Kurimoto, Giovanni Ortuno Urquidi, Mitsuru Oshima.

    Patch set 15:Code-Review +1

    View Change

    2 comments:

    • Patchset:

    • File ui/ozone/platform/wayland/host/wayland_zaura_shell.cc:

      • Agree, changing it to vector. […]

        flat_set is implemented using a vector, so this makes no difference. flat_set lookup is a linear scan, just like vector. the reason to use flat_set over vector is for semantic reasons + guaranteeing uniqueness

        in general, use vector

    To view, visit change 4856179. To unsubscribe, or for help writing mail filters, visit settings.

    Gerrit-MessageType: comment
    Gerrit-Project: chromium/src
    Gerrit-Branch: main
    Gerrit-Change-Id: Ie525d7912f3a47cd1278fcd5379b03122cb798f3
    Gerrit-Change-Number: 4856179
    Gerrit-PatchSet: 15
    Gerrit-Owner: Eriko Kurimoto <elk...@chromium.org>
    Gerrit-Reviewer: Eliot Courtney <edcou...@chromium.org>
    Gerrit-Reviewer: Eriko Kurimoto <elk...@chromium.org>
    Gerrit-Reviewer: Giovanni Ortuno Urquidi <ort...@chromium.org>
    Gerrit-Reviewer: Mitsuru Oshima <osh...@chromium.org>
    Gerrit-CC: Chromium IPC Reviews <chrome-ip...@google.com>
    Gerrit-CC: Kramer Ge <fang...@chromium.org>
    Gerrit-CC: gwsq
    Gerrit-Attention: Giovanni Ortuno Urquidi <ort...@chromium.org>
    Gerrit-Attention: Mitsuru Oshima <osh...@chromium.org>
    Gerrit-Attention: Eriko Kurimoto <elk...@chromium.org>
    Gerrit-Comment-Date: Wed, 13 Sep 2023 13:56:31 +0000
    Gerrit-HasComments: Yes
    Gerrit-Has-Labels: Yes
    Comment-In-Reply-To: Mitsuru Oshima <osh...@chromium.org>
    Comment-In-Reply-To: Eriko Kurimoto <elk...@chromium.org>

    Eliot Courtney (Gerrit)

    unread,
    Sep 13, 2023, 10:00:15 AM9/13/23
    to Eriko Kurimoto, crostin...@chromium.org, ipc-securi...@chromium.org, ozone-...@chromium.org, yhanada+...@chromium.org, Mitsuru Oshima, Chromium IPC Reviews, Giovanni Ortuno Urquidi, Tricium, Chromium LUCI CQ, chromium...@chromium.org

    Attention is currently required from: Eriko Kurimoto, Giovanni Ortuno Urquidi, Mitsuru Oshima.

    View Change

    1 comment:

    • File ui/ozone/platform/wayland/host/wayland_zaura_shell.cc:

      • flat_set is implemented using a vector, so this makes no difference. […]

        quick correction, I checked and chromium's flat_set uses binary search for find ( think I was thinking of small_map). for this size of data it will be slower than linear scan most likely

    To view, visit change 4856179. To unsubscribe, or for help writing mail filters, visit settings.

    Gerrit-MessageType: comment
    Gerrit-Project: chromium/src
    Gerrit-Branch: main
    Gerrit-Change-Id: Ie525d7912f3a47cd1278fcd5379b03122cb798f3
    Gerrit-Change-Number: 4856179
    Gerrit-PatchSet: 15
    Gerrit-Owner: Eriko Kurimoto <elk...@chromium.org>
    Gerrit-Reviewer: Eliot Courtney <edcou...@chromium.org>
    Gerrit-Reviewer: Eriko Kurimoto <elk...@chromium.org>
    Gerrit-Reviewer: Giovanni Ortuno Urquidi <ort...@chromium.org>
    Gerrit-Reviewer: Mitsuru Oshima <osh...@chromium.org>
    Gerrit-CC: Chromium IPC Reviews <chrome-ip...@google.com>
    Gerrit-CC: Kramer Ge <fang...@chromium.org>
    Gerrit-CC: gwsq
    Gerrit-Attention: Giovanni Ortuno Urquidi <ort...@chromium.org>
    Gerrit-Attention: Mitsuru Oshima <osh...@chromium.org>
    Gerrit-Attention: Eriko Kurimoto <elk...@chromium.org>
    Gerrit-Comment-Date: Wed, 13 Sep 2023 14:00:00 +0000
    Gerrit-HasComments: Yes
    Gerrit-Has-Labels: No
    Comment-In-Reply-To: Eliot Courtney <edcou...@chromium.org>

    Eriko Kurimoto (Gerrit)

    unread,
    Sep 13, 2023, 10:02:37 AM9/13/23
    to crostin...@chromium.org, ipc-securi...@chromium.org, ozone-...@chromium.org, yhanada+...@chromium.org, Mitsuru Oshima, Chromium IPC Reviews, Giovanni Ortuno Urquidi, Eliot Courtney, Tricium, Chromium LUCI CQ, chromium...@chromium.org

    Attention is currently required from: Giovanni Ortuno Urquidi, Mitsuru Oshima.

    View Change

    1 comment:

    • File ui/ozone/platform/wayland/host/wayland_zaura_shell.cc:

      • flat_set stored data as a sorted vector, so theoritically faster, but does not mean much on this length and also it's sorted anyway in this usage.

    To view, visit change 4856179. To unsubscribe, or for help writing mail filters, visit settings.

    Gerrit-MessageType: comment
    Gerrit-Project: chromium/src
    Gerrit-Branch: main
    Gerrit-Change-Id: Ie525d7912f3a47cd1278fcd5379b03122cb798f3
    Gerrit-Change-Number: 4856179
    Gerrit-PatchSet: 15
    Gerrit-Owner: Eriko Kurimoto <elk...@chromium.org>
    Gerrit-Reviewer: Eliot Courtney <edcou...@chromium.org>
    Gerrit-Reviewer: Eriko Kurimoto <elk...@chromium.org>
    Gerrit-Reviewer: Giovanni Ortuno Urquidi <ort...@chromium.org>
    Gerrit-Reviewer: Mitsuru Oshima <osh...@chromium.org>
    Gerrit-CC: Chromium IPC Reviews <chrome-ip...@google.com>
    Gerrit-CC: Kramer Ge <fang...@chromium.org>
    Gerrit-CC: gwsq
    Gerrit-Attention: Giovanni Ortuno Urquidi <ort...@chromium.org>
    Gerrit-Attention: Mitsuru Oshima <osh...@chromium.org>
    Gerrit-Comment-Date: Wed, 13 Sep 2023 14:02:21 +0000

    Eriko Kurimoto (Gerrit)

    unread,
    Sep 13, 2023, 10:03:52 AM9/13/23
    to crostin...@chromium.org, ipc-securi...@chromium.org, ozone-...@chromium.org, yhanada+...@chromium.org, Mitsuru Oshima, Chromium IPC Reviews, Giovanni Ortuno Urquidi, Eliot Courtney, Tricium, Chromium LUCI CQ, chromium...@chromium.org

    Attention is currently required from: Giovanni Ortuno Urquidi, Mitsuru Oshima.

    View Change

    1 comment:

    • File ui/ozone/platform/wayland/host/wayland_zaura_shell.cc:

      • ops, sorry cross comments.

      • for this size of data it will be slower than linear scan most likely

      • That's true. std::vector sounds better.

    To view, visit change 4856179. To unsubscribe, or for help writing mail filters, visit settings.

    Gerrit-MessageType: comment
    Gerrit-Project: chromium/src
    Gerrit-Branch: main
    Gerrit-Change-Id: Ie525d7912f3a47cd1278fcd5379b03122cb798f3
    Gerrit-Change-Number: 4856179
    Gerrit-PatchSet: 15
    Gerrit-Owner: Eriko Kurimoto <elk...@chromium.org>
    Gerrit-Reviewer: Eliot Courtney <edcou...@chromium.org>
    Gerrit-Reviewer: Eriko Kurimoto <elk...@chromium.org>
    Gerrit-Reviewer: Giovanni Ortuno Urquidi <ort...@chromium.org>
    Gerrit-Reviewer: Mitsuru Oshima <osh...@chromium.org>
    Gerrit-CC: Chromium IPC Reviews <chrome-ip...@google.com>
    Gerrit-CC: Kramer Ge <fang...@chromium.org>
    Gerrit-CC: gwsq
    Gerrit-Attention: Giovanni Ortuno Urquidi <ort...@chromium.org>
    Gerrit-Attention: Mitsuru Oshima <osh...@chromium.org>
    Gerrit-Comment-Date: Wed, 13 Sep 2023 14:03:34 +0000

    Eriko Kurimoto (Gerrit)

    unread,
    Sep 13, 2023, 10:57:22 AM9/13/23
    to crostin...@chromium.org, ipc-securi...@chromium.org, ozone-...@chromium.org, yhanada+...@chromium.org

    Attention is currently required from: Eriko Kurimoto, Giovanni Ortuno Urquidi, Mitsuru Oshima.

    Eriko Kurimoto uploaded patch set #16 to this change.

    View Change

    17 files changed, 232 insertions(+), 44 deletions(-)

    To view, visit change 4856179. To unsubscribe, or for help writing mail filters, visit settings.

    Gerrit-MessageType: newpatchset
    Gerrit-Project: chromium/src
    Gerrit-Branch: main
    Gerrit-Change-Id: Ie525d7912f3a47cd1278fcd5379b03122cb798f3
    Gerrit-Change-Number: 4856179
    Gerrit-PatchSet: 16
    Gerrit-Owner: Eriko Kurimoto <elk...@chromium.org>
    Gerrit-Reviewer: Eliot Courtney <edcou...@chromium.org>
    Gerrit-Reviewer: Eriko Kurimoto <elk...@chromium.org>
    Gerrit-Reviewer: Giovanni Ortuno Urquidi <ort...@chromium.org>
    Gerrit-Reviewer: Mitsuru Oshima <osh...@chromium.org>
    Gerrit-CC: Chromium IPC Reviews <chrome-ip...@google.com>
    Gerrit-CC: Kramer Ge <fang...@chromium.org>
    Gerrit-CC: gwsq
    Gerrit-Attention: Giovanni Ortuno Urquidi <ort...@chromium.org>
    Gerrit-Attention: Mitsuru Oshima <osh...@chromium.org>
    Gerrit-Attention: Eriko Kurimoto <elk...@chromium.org>

    Giovanni Ortuno Urquidi (Gerrit)

    unread,
    Sep 13, 2023, 9:43:57 PM9/13/23
    to Eriko Kurimoto, crostin...@chromium.org, ipc-securi...@chromium.org, ozone-...@chromium.org, yhanada+...@chromium.org, Giovanni Ortuno Urquidi, Mitsuru Oshima, Chromium IPC Reviews, Eliot Courtney, Tricium, Chromium LUCI CQ, chromium...@chromium.org

    Attention is currently required from: Eriko Kurimoto, Mitsuru Oshima.

    Patch set 16:Code-Review +1

    View Change

      To view, visit change 4856179. To unsubscribe, or for help writing mail filters, visit settings.

      Gerrit-MessageType: comment
      Gerrit-Project: chromium/src
      Gerrit-Branch: main
      Gerrit-Change-Id: Ie525d7912f3a47cd1278fcd5379b03122cb798f3
      Gerrit-Change-Number: 4856179
      Gerrit-PatchSet: 16
      Gerrit-Owner: Eriko Kurimoto <elk...@chromium.org>
      Gerrit-Reviewer: Eliot Courtney <edcou...@chromium.org>
      Gerrit-Reviewer: Eriko Kurimoto <elk...@chromium.org>
      Gerrit-Reviewer: Giovanni Ortuno Urquidi <ort...@chromium.org>
      Gerrit-Reviewer: Mitsuru Oshima <osh...@chromium.org>
      Gerrit-CC: Chromium IPC Reviews <chrome-ip...@google.com>
      Gerrit-CC: Kramer Ge <fang...@chromium.org>
      Gerrit-CC: gwsq
      Gerrit-Attention: Mitsuru Oshima <osh...@chromium.org>
      Gerrit-Attention: Eriko Kurimoto <elk...@chromium.org>
      Gerrit-Comment-Date: Thu, 14 Sep 2023 01:43:46 +0000
      Gerrit-HasComments: No
      Gerrit-Has-Labels: Yes

      Eriko Kurimoto (Gerrit)

      unread,
      Sep 13, 2023, 11:05:21 PM9/13/23
      to crostin...@chromium.org, ipc-securi...@chromium.org, ozone-...@chromium.org, yhanada+...@chromium.org

      Attention is currently required from: Eriko Kurimoto, Mitsuru Oshima.

      Eriko Kurimoto uploaded patch set #18 to this change.

      View Change

      17 files changed, 246 insertions(+), 44 deletions(-)

      To view, visit change 4856179. To unsubscribe, or for help writing mail filters, visit settings.

      Gerrit-MessageType: newpatchset
      Gerrit-Project: chromium/src
      Gerrit-Branch: main
      Gerrit-Change-Id: Ie525d7912f3a47cd1278fcd5379b03122cb798f3
      Gerrit-Change-Number: 4856179
      Gerrit-PatchSet: 18

      Eriko Kurimoto (Gerrit)

      unread,
      Sep 13, 2023, 11:08:21 PM9/13/23
      to crostin...@chromium.org, ipc-securi...@chromium.org, ozone-...@chromium.org, yhanada+...@chromium.org, Giovanni Ortuno Urquidi, Mitsuru Oshima, Chromium IPC Reviews, Eliot Courtney, Tricium, Chromium LUCI CQ, chromium...@chromium.org

      Attention is currently required from: Eriko Kurimoto, Mitsuru Oshima.

      Patch set 19:Commit-Queue +2

      View Change

        To view, visit