[ozone] Remove ClientNativePixmapFactory from NativePixmapGLBindingTest [chromium/src : main]
0 views
Skip to first unread message
Saifuddin Hitawala (Gerrit)
Mar 19, 2026, 11:05:50 AMMar 19
to Colin Blundell, Chromium LUCI CQ, chromium...@chromium.org, ozone-...@chromium.org
Attention needed from Colin Blundell
Saifuddin Hitawala added 1 comment![]( "Open in Gerrit")
Patchset-level comments
Related details
Attention is currently required from:
- Colin Blundell
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Colin Blundell (Gerrit)
Mar 19, 2026, 11:07:47 AMMar 19
to Saifuddin Hitawala, Colin Blundell, Chromium LUCI CQ, chromium...@chromium.org, ozone-...@chromium.org
Attention needed from Saifuddin Hitawala
Colin Blundell voted and added 1 comment![]( "Open in Gerrit")
Votes added by Colin Blundell
| Code-Review | +1 |
1 comment
Patchset-level comments
Attention is currently required from:
- Saifuddin Hitawala
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Saifuddin Hitawala (Gerrit)
Mar 19, 2026, 11:31:40 AMMar 19
to Colin Blundell, Chromium LUCI CQ, chromium...@chromium.org, ozone-...@chromium.org
Saifuddin Hitawala voted and added 1 comment![]( "Open in Gerrit")
Votes added by Saifuddin Hitawala
| Commit-Queue | +2 |
1 comment
Patchset-level comments
Saifuddin Hitawala . resolved
Thanks for the review!
Related details
Attention set is empty
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Chromium LUCI CQ (Gerrit)
Mar 19, 2026, 11:35:26 AMMar 19
to Saifuddin Hitawala, Colin Blundell, chromium...@chromium.org, ozone-...@chromium.org
Chromium LUCI CQ submitted the change![]( "Open in Gerrit")
Change information
Commit message:
[ozone] Remove ClientNativePixmapFactory from NativePixmapGLBindingTest
Opportunistic clean-up from FuchsiaVideoDecoder work [1] where found
out that ClientNativePixmapFactory is not used.
ClientNativePixmapFactory is also not used here in
NativePixmapGLBindingTest and can be removed.
[1] https://chromium-review.googlesource.com/c/chromium/src/+/7680193
Bug: 492116792
Change-Id: I04f1acfb527232361c2c9e3975b0d7961e625794
Commit-Queue: Saifuddin Hitawala <hita...@chromium.org>
Reviewed-by: Colin Blundell <blun...@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1601995}
Files:
- M ui/ozone/gl/native_pixmap_gl_binding_unittest.cc
Change size: XS
Delta: 1 file changed, 1 insertion(+), 5 deletions(-)
Branch: refs/heads/main
Submit Requirements:
Code-Review: +1 by Colin Blundell
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Reply all
Reply to author
Forward
0 new messages