IWYU native_widget_types.h (and native_window_types.h) includes [chromium/src : main]

0 views
Skip to first unread message

Mitsuru Oshima (Gerrit)

unread,
Sep 1, 2025, 12:57:06 AM (7 days ago) Sep 1
to Chromium LUCI CQ, Jun Ishiguro, AyeAye, chromium...@chromium.org, (Julie)Jeongeun Kim, Nikhil Nayunigari, abigailbk...@google.com, chadduffin+w...@chromium.org, chromeos-kio...@google.com, chromium-a...@chromium.org, dtseng...@chromium.org, ejcaruso+wa...@chromium.org, extension...@chromium.org, francisjp...@google.com, hirokisa...@chromium.org, hsuregan+wa...@chromium.org, jackshira+w...@google.com, jiajunz+wa...@google.com, jonmann+wa...@chromium.org, josiah...@chromium.org, katie...@chromium.org, khorimoto+w...@chromium.org, kyungjunle...@google.com, max+watc...@igalia.com, nektar...@chromium.org, net-r...@chromium.org, nickdiego+wa...@igalia.com, ozone-...@chromium.org, rrsilva+wat...@google.com, stevenjb+wa...@chromium.org, yuzo+...@chromium.org
Attention needed from Jun Ishiguro

Mitsuru Oshima voted Commit-Queue+1

Commit-Queue+1
Open in Gerrit

Related details

Attention is currently required from:
  • Jun Ishiguro
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement satisfiedCode-Owners
  • requirement is not satisfiedCode-Review
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: I54fc58e56fedb6e933579631287aad8a2c0b26de
Gerrit-Change-Number: 6904967
Gerrit-PatchSet: 3
Gerrit-Owner: Mitsuru Oshima <osh...@chromium.org>
Gerrit-Reviewer: Jun Ishiguro <ju...@google.com>
Gerrit-Reviewer: Mitsuru Oshima <osh...@chromium.org>
Gerrit-CC: (Julie)Jeongeun Kim <je_jul...@chromium.org>
Gerrit-CC: Akihiro Ota <akihi...@chromium.org>
Gerrit-CC: Nikhil Nayunigari <nikh...@google.com>
Gerrit-Attention: Jun Ishiguro <ju...@google.com>
Gerrit-Comment-Date: Mon, 01 Sep 2025 04:56:56 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
satisfied_requirement
unsatisfied_requirement
open
diffy

Jun Ishiguro (Gerrit)

unread,
Sep 1, 2025, 1:22:52 AM (7 days ago) Sep 1
to Mitsuru Oshima, Chromium LUCI CQ, AyeAye, chromium...@chromium.org, (Julie)Jeongeun Kim, Nikhil Nayunigari, abigailbk...@google.com, chadduffin+w...@chromium.org, chromeos-kio...@google.com, chromium-a...@chromium.org, dtseng...@chromium.org, ejcaruso+wa...@chromium.org, extension...@chromium.org, francisjp...@google.com, hirokisa...@chromium.org, hsuregan+wa...@chromium.org, jackshira+w...@google.com, jiajunz+wa...@google.com, jonmann+wa...@chromium.org, josiah...@chromium.org, katie...@chromium.org, khorimoto+w...@chromium.org, kyungjunle...@google.com, max+watc...@igalia.com, nektar...@chromium.org, net-r...@chromium.org, nickdiego+wa...@igalia.com, ozone-...@chromium.org, rrsilva+wat...@google.com, stevenjb+wa...@chromium.org, yuzo+...@chromium.org
Attention needed from Mitsuru Oshima

Jun Ishiguro voted and added 1 comment

Votes added by Jun Ishiguro

Code-Review+1

1 comment

Patchset-level comments
File-level comment, Patchset 3 (Latest):
Jun Ishiguro . resolved

LGTM

Open in Gerrit

Related details

Attention is currently required from:
  • Mitsuru Oshima
Submit Requirements:
    • requirement satisfiedCode-Coverage
    • requirement satisfiedCode-Owners
    • requirement satisfiedCode-Review
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: comment
    Gerrit-Project: chromium/src
    Gerrit-Branch: main
    Gerrit-Change-Id: I54fc58e56fedb6e933579631287aad8a2c0b26de
    Gerrit-Change-Number: 6904967
    Gerrit-PatchSet: 3
    Gerrit-Owner: Mitsuru Oshima <osh...@chromium.org>
    Gerrit-Reviewer: Jun Ishiguro <ju...@google.com>
    Gerrit-Reviewer: Mitsuru Oshima <osh...@chromium.org>
    Gerrit-CC: (Julie)Jeongeun Kim <je_jul...@chromium.org>
    Gerrit-CC: Akihiro Ota <akihi...@chromium.org>
    Gerrit-CC: Nikhil Nayunigari <nikh...@google.com>
    Gerrit-Attention: Mitsuru Oshima <osh...@chromium.org>
    Gerrit-Comment-Date: Mon, 01 Sep 2025 05:22:16 +0000
    Gerrit-HasComments: Yes
    Gerrit-Has-Labels: Yes
    satisfied_requirement
    open
    diffy

    Mitsuru Oshima (Gerrit)

    unread,
    Sep 1, 2025, 1:56:56 AM (7 days ago) Sep 1
    to Jun Ishiguro, Chromium LUCI CQ, AyeAye, chromium...@chromium.org, (Julie)Jeongeun Kim, Nikhil Nayunigari, abigailbk...@google.com, chadduffin+w...@chromium.org, chromeos-kio...@google.com, chromium-a...@chromium.org, dtseng...@chromium.org, ejcaruso+wa...@chromium.org, extension...@chromium.org, francisjp...@google.com, hirokisa...@chromium.org, hsuregan+wa...@chromium.org, jackshira+w...@google.com, jiajunz+wa...@google.com, jonmann+wa...@chromium.org, josiah...@chromium.org, katie...@chromium.org, khorimoto+w...@chromium.org, kyungjunle...@google.com, max+watc...@igalia.com, nektar...@chromium.org, net-r...@chromium.org, nickdiego+wa...@igalia.com, ozone-...@chromium.org, rrsilva+wat...@google.com, stevenjb+wa...@chromium.org, yuzo+...@chromium.org

    Mitsuru Oshima voted Commit-Queue+2

    Commit-Queue+2
    Open in Gerrit

    Related details

    Attention set is empty
    Submit Requirements:
    • requirement satisfiedCode-Coverage
    • requirement satisfiedCode-Owners
    • requirement satisfiedCode-Review
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: comment
    Gerrit-Project: chromium/src
    Gerrit-Branch: main
    Gerrit-Change-Id: I54fc58e56fedb6e933579631287aad8a2c0b26de
    Gerrit-Change-Number: 6904967
    Gerrit-PatchSet: 4
    Gerrit-Owner: Mitsuru Oshima <osh...@chromium.org>
    Gerrit-Reviewer: Jun Ishiguro <ju...@google.com>
    Gerrit-Reviewer: Mitsuru Oshima <osh...@chromium.org>
    Gerrit-CC: (Julie)Jeongeun Kim <je_jul...@chromium.org>
    Gerrit-CC: Akihiro Ota <akihi...@chromium.org>
    Gerrit-CC: Nikhil Nayunigari <nikh...@google.com>
    Gerrit-Comment-Date: Mon, 01 Sep 2025 05:56:43 +0000
    Gerrit-HasComments: No
    Gerrit-Has-Labels: Yes
    satisfied_requirement
    open
    diffy

    Chromium LUCI CQ (Gerrit)

    unread,
    Sep 1, 2025, 2:09:57 AM (7 days ago) Sep 1
    to Mitsuru Oshima, Jun Ishiguro, AyeAye, Akihiro Ota, chromium...@chromium.org, (Julie)Jeongeun Kim, Nikhil Nayunigari, abigailbk...@google.com, chadduffin+w...@chromium.org, chromeos-kio...@google.com, chromium-a...@chromium.org, dtseng...@chromium.org, ejcaruso+wa...@chromium.org, extension...@chromium.org, francisjp...@google.com, hirokisa...@chromium.org, hsuregan+wa...@chromium.org, jackshira+w...@google.com, jiajunz+wa...@google.com, jonmann+wa...@chromium.org, josiah...@chromium.org, katie...@chromium.org, khorimoto+w...@chromium.org, kyungjunle...@google.com, max+watc...@igalia.com, nektar...@chromium.org, net-r...@chromium.org, nickdiego+wa...@igalia.com, ozone-...@chromium.org, rrsilva+wat...@google.com, stevenjb+wa...@chromium.org, yuzo+...@chromium.org

    Chromium LUCI CQ submitted the change

    Unreviewed changes

    3 is the latest approved patch-set.
    No files were changed between the latest approved patch-set and the submitted one.

    Change information

    Commit message:
    IWYU native_widget_types.h (and native_window_types.h) includes

    c/b/ash, ui (except ui/views) and javascript_dialog_extensions_client
    AX-Relnotes: n/a.
    Bug: 440644556
    Change-Id: I54fc58e56fedb6e933579631287aad8a2c0b26de
    Commit-Queue: Mitsuru Oshima <osh...@chromium.org>
    Reviewed-by: Jun Ishiguro <ju...@google.com>
    Cr-Commit-Position: refs/heads/main@{#1509002}
    Files:
    • M chrome/browser/ash/accessibility/sticky_keys_browsertest.cc
    • M chrome/browser/ash/app_mode/test/kiosk_browsertest.cc
    • M chrome/browser/ash/net/system_proxy_manager.cc
    • M chrome/browser/ash/power/ml/user_activity_ukm_logger_impl.cc
    • M extensions/components/javascript_dialog_extensions_client/javascript_dialog_extension_client_impl.cc
    • M ui/base/test/skia_gold_pixel_diff_unittest.cc
    • M ui/display/screen_unittest.cc
    • M ui/ozone/platform/wayland/host/wayland_cursor_shape.cc
    • M ui/ozone/platform/wayland/host/wayland_toplevel_window.cc
    • M ui/ozone/platform/wayland/host/wayland_window_factory.cc
    Change size: S
    Delta: 10 files changed, 0 insertions(+), 10 deletions(-)
    Branch: refs/heads/main
    Submit Requirements:
    • requirement satisfiedCode-Review: +1 by Jun Ishiguro
    Open in Gerrit
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: merged
    Gerrit-Project: chromium/src
    Gerrit-Branch: main
    Gerrit-Change-Id: I54fc58e56fedb6e933579631287aad8a2c0b26de
    Gerrit-Change-Number: 6904967
    Gerrit-PatchSet: 5
    Gerrit-Owner: Mitsuru Oshima <osh...@chromium.org>
    Gerrit-Reviewer: Chromium LUCI CQ <chromiu...@luci-project-accounts.iam.gserviceaccount.com>
    Gerrit-Reviewer: Jun Ishiguro <ju...@google.com>
    Gerrit-Reviewer: Mitsuru Oshima <osh...@chromium.org>
    Gerrit-CC: (Julie)Jeongeun Kim <je_jul...@chromium.org>
    Gerrit-CC: Akihiro Ota <akihi...@chromium.org>
    open
    diffy
    satisfied_requirement
    Reply all
    Reply to author
    Forward
    0 new messages