[ozone] Use NativePixmapUsage in WaylandSurfaceFactory [chromium/src : main]
0 views
Skip to first unread message
Saifuddin Hitawala (Gerrit)
Aug 29, 2025, 10:48:10 AM (10 days ago) Aug 29
to Vasiliy Telezhnikov, Chromium LUCI CQ, chromium...@chromium.org, max+watc...@igalia.com, nickdiego+wa...@igalia.com, ozone-...@chromium.org
Attention needed from Vasiliy Telezhnikov
Saifuddin Hitawala voted and added 1 comment![]( "Open in Gerrit")
Votes added by Saifuddin Hitawala
| Commit-Queue | +1 |
1 comment
Patchset-level comments
Related details
Attention is currently required from:
- Vasiliy Telezhnikov
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Vasiliy Telezhnikov (Gerrit)
Aug 29, 2025, 11:00:59 AM (10 days ago) Aug 29
to Saifuddin Hitawala, Chromium LUCI CQ, chromium...@chromium.org, max+watc...@igalia.com, nickdiego+wa...@igalia.com, ozone-...@chromium.org
Attention needed from Saifuddin Hitawala
Vasiliy Telezhnikov voted and added 1 comment![]( "Open in Gerrit")
Votes added by Vasiliy Telezhnikov
| Code-Review | +1 |
1 comment
Patchset-level comments
Attention is currently required from:
- Saifuddin Hitawala
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Saifuddin Hitawala (Gerrit)
Aug 29, 2025, 11:03:05 AM (10 days ago) Aug 29
to Kramer Ge, Vasiliy Telezhnikov, Chromium LUCI CQ, chromium...@chromium.org, max+watc...@igalia.com, nickdiego+wa...@igalia.com, ozone-...@chromium.org
Attention needed from Kramer Ge
Saifuddin Hitawala added 1 comment![]( "Open in Gerrit")
Patchset-level comments
Attention is currently required from:
- Kramer Ge
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Kramer Ge (Gerrit)
Aug 29, 2025, 12:55:20 PM (10 days ago) Aug 29
to Saifuddin Hitawala, Vasiliy Telezhnikov, Chromium LUCI CQ, chromium...@chromium.org, max+watc...@igalia.com, nickdiego+wa...@igalia.com, ozone-...@chromium.org
Attention needed from Saifuddin Hitawala
Kramer Ge voted and added 2 comments![]( "Open in Gerrit")
Votes added by Kramer Ge
| Code-Review | +1 |
2 comments
Patchset-level comments
Kramer Ge . resolved
+1 % nit
File ui/ozone/public/native_pixmap_usage_utils.cc
Line 46, Patchset 1 (Latest):
const std::pair<NativePixmapUsage, const char*> kUsages[] = {Kramer Ge . unresolved
Should be `static` to save space?
Related details
Attention is currently required from:
- Saifuddin Hitawala
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
No-Unresolved-Comments
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Saifuddin Hitawala (Gerrit)
Aug 29, 2025, 2:10:48 PM (10 days ago) Aug 29
to Vasiliy Telezhnikov, Chromium LUCI CQ, chromium...@chromium.org, max+watc...@igalia.com, nickdiego+wa...@igalia.com, ozone-...@chromium.org
Saifuddin Hitawala voted and added 2 comments![]( "Open in Gerrit")
Votes added by Saifuddin Hitawala
| Commit-Queue | +2 |
2 comments
Patchset-level comments
File ui/ozone/public/native_pixmap_usage_utils.cc
Line 46, Patchset 1:
const std::pair<NativePixmapUsage, const char*> kUsages[] = {Kramer Ge . resolved
Should be `static` to save space?
Saifuddin Hitawala
Sounds good, updated to make it static.
Related details
Attention set is empty
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Chromium LUCI CQ (Gerrit)
Aug 29, 2025, 3:05:50 PM (10 days ago) Aug 29
to Saifuddin Hitawala, Kramer Ge, Vasiliy Telezhnikov, chromium...@chromium.org, max+watc...@igalia.com, nickdiego+wa...@igalia.com, ozone-...@chromium.org
Chromium LUCI CQ submitted the change with unreviewed changes![]( "Open in Gerrit")
Unreviewed changes
1 is the latest approved patch-set.
The change was submitted with unreviewed changes in the following files:
```
The name of the file: ui/ozone/public/native_pixmap_usage_utils.cc
Insertions: 1, Deletions: 1.
@@ -43,7 +43,7 @@
return {};
}
- const std::pair<NativePixmapUsage, const char*> kUsages[] = {
+ static const std::pair<NativePixmapUsage, const char*> kUsages[] = {
{NativePixmapUsage::kScanout, "Scanout"},
{NativePixmapUsage::kRendering, "Rendering"},
{NativePixmapUsage::kTexturing, "Texturing"},
```
Change information
Commit message:
[ozone] Use NativePixmapUsage in WaylandSurfaceFactory
As part of Bufferusage to NativePixmapUsage conversions within ozone,
update WaylandSurfaceFactory to use NativePixmapUsage as well as use
it within GbmPixmapWayland.
Bug: 404958317
Change-Id: I0028bcba3580cb2f42b13b6225b29d4c78125604
Reviewed-by: Kramer Ge <fang...@chromium.org>
Commit-Queue: Saifuddin Hitawala <hita...@chromium.org>
Reviewed-by: Vasiliy Telezhnikov <vas...@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1508544}
Files:
- M ui/ozone/platform/wayland/gpu/gbm_pixmap_wayland.cc
- M ui/ozone/platform/wayland/gpu/gbm_pixmap_wayland.h
- M ui/ozone/platform/wayland/gpu/wayland_surface_factory.cc
- M ui/ozone/public/native_pixmap_usage_utils.cc
- M ui/ozone/public/native_pixmap_usage_utils.h
Change size: M
Delta: 5 files changed, 48 insertions(+), 8 deletions(-)
Branch: refs/heads/main
Submit Requirements:
Code-Review: +1 by Vasiliy Telezhnikov, +1 by Kramer Ge
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Reply all
Reply to author
Forward
0 new messages