Terracotta-Phase-1: Validate all `handle`s in `ClientNativePixmapFactoryDmabuf` [chromium/src : main]
0 views
Skip to first unread message
Kalvin Lee (Gerrit)
Mar 26, 2026, 2:35:20 AM (8 days ago) Mar 26
to Michael Spang, Chromium LUCI CQ, chromium...@chromium.org, ozone-...@chromium.org
Attention needed from Michael Spang
Kalvin Lee added 1 comment![]( "Open in Gerrit")
Patchset-level comments
File-level comment, Patchset 1 (Latest):
Kalvin Lee . resolved
Passing over to Michael in continuation of our offline chat...
Related details
Attention is currently required from:
- Michael Spang
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Michael Spang (Gerrit)
Mar 26, 2026, 2:37:55 AM (8 days ago) Mar 26
to Kalvin Lee, Chromium LUCI CQ, chromium...@chromium.org, ozone-...@chromium.org
Attention needed from Kalvin Lee
Michael Spang added 1 comment![]( "Open in Gerrit")
File ui/gfx/linux/client_native_pixmap_factory_dmabuf.cc
Line 123, Patchset 1 (Latest):
case gfx::BufferUsage::GPU_READ:
case gfx::BufferUsage::SCANOUT:
case gfx::BufferUsage::SCANOUT_VDA_WRITE:
case gfx::BufferUsage::PROTECTED_SCANOUT:
case gfx::BufferUsage::PROTECTED_SCANOUT_VDA_WRITE:
return base::WrapUnique(
new ClientNativePixmapOpaque(std::move(handle)));Michael Spang . unresolved
These are usages with no CPU access, IIRC it's intended that we don't assume a memory representation in these cases.
Related details
Attention is currently required from:
- Kalvin Lee
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
No-Unresolved-Comments
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Kalvin Lee (Gerrit)
Mar 26, 2026, 3:03:26 AM (8 days ago) Mar 26
to Michael Spang, Chromium LUCI CQ, chromium...@chromium.org, ozone-...@chromium.org
Attention needed from Michael Spang
Kalvin Lee added 1 comment![]( "Open in Gerrit")
File ui/gfx/linux/client_native_pixmap_factory_dmabuf.cc
Line 123, Patchset 1 (Latest):
case gfx::BufferUsage::GPU_READ:
case gfx::BufferUsage::SCANOUT:
case gfx::BufferUsage::SCANOUT_VDA_WRITE:
case gfx::BufferUsage::PROTECTED_SCANOUT:
case gfx::BufferUsage::PROTECTED_SCANOUT_VDA_WRITE:
return base::WrapUnique(
new ClientNativePixmapOpaque(std::move(handle)));Michael Spang . unresolved
These are usages with no CPU access, IIRC it's intended that we don't assume a memory representation in these cases.
Kalvin Lee
Thanks for putting this on the record --- could you please comment on the bug if you think it's mistaken?
Related details
Attention is currently required from:
- Michael Spang
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
No-Unresolved-Comments
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Reply all
Reply to author
Forward
0 new messages