Saifuddin Hitawala (Gerrit)

unread,

Jan 12, 2026, 2:54:26 PMJan 12

to Kramer Ge, Kyle Charbonneau, Chromium IPC Reviews, AyeAye, Chromium LUCI CQ, chromium...@chromium.org, yhanada+...@chromium.org, crostin...@chromium.org, cc-...@chromium.org, max+watc...@igalia.com, nickdiego+wa...@igalia.com, ozone-...@chromium.org, penghu...@chromium.org

Attention needed from Chromium IPC Reviews, Kramer Ge and Kyle Charbonneau

Saifuddin Hitawala added 1 comment

Patchset-level comments

File-level comment, Patchset 3 (Latest):

Saifuddin Hitawala . resolved

Please take a look.

Open in Gerrit

Related details

Attention is currently required from:

Chromium IPC Reviews
Kramer Ge
Kyle Charbonneau

Submit Requirements:

Code-Coverage
Code-Owners
Code-Review
Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

satisfied_requirement

unsatisfied_requirement

open

diffy

gwsq (Gerrit)

unread,

Jan 12, 2026, 2:58:43 PMJan 12

to Saifuddin Hitawala, Chromium IPC Reviews, Ken Buchanan, Mitsuru Oshima, Kramer Ge, Kyle Charbonneau, AyeAye, Chromium LUCI CQ, chromium...@chromium.org, yhanada+...@chromium.org, crostin...@chromium.org, cc-...@chromium.org, max+watc...@igalia.com, nickdiego+wa...@igalia.com, ozone-...@chromium.org, penghu...@chromium.org

Attention needed from Ken Buchanan, Kramer Ge, Kyle Charbonneau and Mitsuru Oshima

Message from gwsq

From googleclient/chrome/chromium_gwsq/ipc/config.gwsq:
IPC: ke...@chromium.org

📎 It looks like you’re making a possibly security-sensitive change! 📎 IPC security review isn’t a rubberstamp, so your friendly security reviewer will need a fair amount of context to review your CL effectively. Please review your CL description and code comments to make sure they provide context for someone unfamiliar with your project/area. Pay special attention to where data comes from and which processes it flows between (and their privilege levels). Feel free to point your security reviewer at design docs, bugs, or other links if you can’t reasonably make a self-contained CL description. (Also see https://cbea.ms/git-commit/).

IPC reviewer(s): ke...@chromium.org

Reviewer source(s):
ke...@chromium.org is from context(googleclient/chrome/chromium_gwsq/ipc/config.gwsq)

Open in Gerrit

Related details

Attention is currently required from:

Ken Buchanan
Kramer Ge
Kyle Charbonneau
Mitsuru Oshima

Submit Requirements:

Code-Coverage
Code-Owners
Code-Review
Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

satisfied_requirement

unsatisfied_requirement

open

diffy

Mitsuru Oshima (Gerrit)

unread,

Jan 12, 2026, 3:00:14 PMJan 12

to Saifuddin Hitawala, Chromium IPC Reviews, Ken Buchanan, Kramer Ge, Kyle Charbonneau, AyeAye, Chromium LUCI CQ, chromium...@chromium.org, yhanada+...@chromium.org, crostin...@chromium.org, cc-...@chromium.org, max+watc...@igalia.com, nickdiego+wa...@igalia.com, ozone-...@chromium.org, penghu...@chromium.org

Attention needed from Ken Buchanan, Kramer Ge, Kyle Charbonneau and Saifuddin Hitawala

Mitsuru Oshima voted Code-Review+1

Code-Review

+1

Open in Gerrit

Related details

Attention is currently required from:

Ken Buchanan
Kramer Ge
Kyle Charbonneau

Saifuddin Hitawala

Submit Requirements:

Code-Coverage
Code-Owners

Code-Review
Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

satisfied_requirement

unsatisfied_requirement

open

diffy

Kramer Ge (Gerrit)

unread,

Jan 12, 2026, 4:12:52 PMJan 12

to Saifuddin Hitawala, Mitsuru Oshima, Chromium IPC Reviews, Ken Buchanan, Kyle Charbonneau, AyeAye, Chromium LUCI CQ, chromium...@chromium.org, yhanada+...@chromium.org, crostin...@chromium.org, cc-...@chromium.org, max+watc...@igalia.com, nickdiego+wa...@igalia.com, ozone-...@chromium.org, penghu...@chromium.org

Attention needed from Ken Buchanan, Kyle Charbonneau and Saifuddin Hitawala

Kramer Ge voted Code-Review+1

Code-Review

+1

Open in Gerrit

Related details

Attention is currently required from:

Ken Buchanan
Kyle Charbonneau
Saifuddin Hitawala

satisfied_requirement

unsatisfied_requirement

open

diffy

Ken Buchanan (Gerrit)

unread,

Jan 12, 2026, 4:16:04 PMJan 12

to Saifuddin Hitawala, Mitsuru Oshima, Chromium IPC Reviews, Kyle Charbonneau, AyeAye, Chromium LUCI CQ, chromium...@chromium.org, yhanada+...@chromium.org, crostin...@chromium.org, cc-...@chromium.org, max+watc...@igalia.com, nickdiego+wa...@igalia.com, ozone-...@chromium.org, penghu...@chromium.org

Attention needed from Kyle Charbonneau and Saifuddin Hitawala

Ken Buchanan voted Code-Review+1

Code-Review

+1

Open in Gerrit

Related details

Attention is currently required from:

Kyle Charbonneau
Saifuddin Hitawala

satisfied_requirement

unsatisfied_requirement

open

diffy

Kyle Charbonneau (Gerrit)

unread,

Jan 12, 2026, 4:16:12 PMJan 12

to Saifuddin Hitawala, Ken Buchanan, Mitsuru Oshima, Chromium IPC Reviews, AyeAye, Chromium LUCI CQ, chromium...@chromium.org, yhanada+...@chromium.org, crostin...@chromium.org, cc-...@chromium.org, max+watc...@igalia.com, nickdiego+wa...@igalia.com, ozone-...@chromium.org, penghu...@chromium.org

Attention needed from Saifuddin Hitawala

Kyle Charbonneau voted and added 1 comment

Votes added by Kyle Charbonneau

Code-Review

+1

1 comment

Patchset-level comments

File-level comment, Patchset 3 (Latest):

Kyle Charbonneau . resolved

lgtm!

Open in Gerrit

Related details

Attention is currently required from:

Saifuddin Hitawala

Submit Requirements:

Code-Coverage
Code-Owners

Code-Review
Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

satisfied_requirement

open

diffy

Saifuddin Hitawala (Gerrit)

unread,

Jan 12, 2026, 4:21:53 PMJan 12

to Kyle Charbonneau, Ken Buchanan, Mitsuru Oshima, Chromium IPC Reviews, AyeAye, Chromium LUCI CQ, chromium...@chromium.org, yhanada+...@chromium.org, crostin...@chromium.org, cc-...@chromium.org, max+watc...@igalia.com, nickdiego+wa...@igalia.com, ozone-...@chromium.org, penghu...@chromium.org

Saifuddin Hitawala voted and added 1 comment

Votes added by Saifuddin Hitawala

Commit-Queue

+2

1 comment

Patchset-level comments

File-level comment, Patchset 3 (Latest):

Saifuddin Hitawala . resolved

Thanks for reviews!

Open in Gerrit

Related details

Attention set is empty

Submit Requirements:

Code-Coverage
Code-Owners
Code-Review
Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

satisfied_requirement

open

diffy

Chromium LUCI CQ (Gerrit)

unread,

Jan 12, 2026, 5:03:30 PMJan 12

to Saifuddin Hitawala, Kyle Charbonneau, Ken Buchanan, Kramer Ge, Mitsuru Oshima, Chromium IPC Reviews, AyeAye, chromium...@chromium.org, yhanada+...@chromium.org, crostin...@chromium.org, cc-...@chromium.org, max+watc...@igalia.com, nickdiego+wa...@igalia.com, ozone-...@chromium.org, penghu...@chromium.org

Chromium LUCI CQ submitted the change

Change information

Commit message:

[ui/gfx] Remove BufferFormat util files

BufferFormatToString is no longer used as all its usages have been
removed as part of BufferFormat to SharedImageFormat conversions.
This change removes util file and all places it was included.

Bug: 356649879

Change-Id: I327ab72ad248b391e79c400c5e5e9fede3487fa2

Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/7453533

Reviewed-by: Mitsuru Oshima <osh...@chromium.org>

Reviewed-by: Kramer Ge <fang...@chromium.org>

Reviewed-by: Kyle Charbonneau <kyle...@chromium.org>

Reviewed-by: Ken Buchanan <ke...@chromium.org>

Commit-Queue: Saifuddin Hitawala <hita...@chromium.org>

Cr-Commit-Position: refs/heads/main@{#1568049}

Files:

M cc/test/pixel_test_output_surface.cc
M components/exo/wayland/test/integration/buffer_checker_test.cc
M components/viz/service/display_embedder/output_presenter_gl.cc
M components/viz/service/display_embedder/skia_output_device_webview.cc
M components/viz/test/fake_output_surface.cc
M content/browser/gpu/gpu_internals_ui.cc
M gpu/command_buffer/client/internal/mappable_buffer_ahb.cc
M gpu/command_buffer/client/internal/mappable_buffer_test_template.h
M gpu/command_buffer/service/shared_image/ahardwarebuffer_image_backing_factory.cc
M gpu/command_buffer/service/shared_image/d3d_image_backing_factory_unittest.cc
M gpu/command_buffer/service/shared_image/iosurface_image_backing_factory_unittest.cc
M gpu/command_buffer/service/shared_image/ozone_image_backing_factory_unittest.cc
M ui/gfx/BUILD.gn
D ui/gfx/buffer_format_util.cc
D ui/gfx/buffer_format_util.h
M ui/gfx/linux/gbm_support_x11.cc
M ui/ozone/common/native_pixmap_egl_binding.cc
M ui/ozone/gl/native_pixmap_gl_binding_unittest.cc
M ui/ozone/platform/wayland/gpu/gbm_pixmap_wayland.cc
M ui/ozone/platform/x11/native_pixmap_egl_x11_binding.cc

Change size: M

Delta: 20 files changed, 0 insertions(+), 93 deletions(-)

Branch: refs/heads/main

Submit Requirements:

Code-Review: +1 by Ken Buchanan, +1 by Mitsuru Oshima, +1 by Kramer Ge, +1 by Kyle Charbonneau

Open in Gerrit

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

open

diffy

satisfied_requirement

Reply all

Reply to author

Forward

[ui/gfx] Remove BufferFormat util files [chromium/src : main]

Saifuddin Hitawala (Gerrit)

Saifuddin Hitawala added 1 comment

Related details

gwsq (Gerrit)

Message from gwsq

Related details

Mitsuru Oshima (Gerrit)

Mitsuru Oshima voted Code-Review+1

Related details

Kramer Ge (Gerrit)

Kramer Ge voted Code-Review+1

Related details

Ken Buchanan (Gerrit)

Ken Buchanan voted Code-Review+1

Related details

Kyle Charbonneau (Gerrit)

Kyle Charbonneau voted and added 1 comment

Votes added by Kyle Charbonneau

1 comment

Related details

Saifuddin Hitawala (Gerrit)

Saifuddin Hitawala voted and added 1 comment

Votes added by Saifuddin Hitawala

1 comment

Related details

Chromium LUCI CQ (Gerrit)

Chromium LUCI CQ submitted the change

Change information