[headless] Fix scaled screen zoomed window size on Linux [chromium/src : main]
2 views
Skip to first unread message
Peter Kvitek (Gerrit)
Oct 30, 2025, 8:31:36 PM (7 days ago) Oct 30
to Chromium LUCI CQ, chromium...@chromium.org, headless...@chromium.org, ozone-...@chromium.org
New activity on the change![]( "Open in Gerrit")
Related details
Attention set is empty
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Colin Blundell (Gerrit)
Oct 31, 2025, 4:13:40 AM (6 days ago) Oct 31
to Peter Kvitek, Colin Blundell, Chromium LUCI CQ, chromium...@chromium.org, headless...@chromium.org, ozone-...@chromium.org
Attention needed from Peter Kvitek
Colin Blundell voted and added 2 comments![]( "Open in Gerrit")
Votes added by Colin Blundell
| Code-Review | +1 |
2 comments
Patchset-level comments
File ui/ozone/platform/headless/headless_window.cc
Line 180, Patchset 3 (Latest):
UpdateBounds(delegate_->ConvertRectToPixels(zoomed_bounds));Colin Blundell . unresolved
nit: Could use a comment explaining why this conversion is necessary here
Related details
Attention is currently required from:
- Peter Kvitek
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
No-Unresolved-Comments
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Peter Kvitek (Gerrit)
Oct 31, 2025, 11:09:17 AM (6 days ago) Oct 31
to Colin Blundell, Chromium LUCI CQ, chromium...@chromium.org, headless...@chromium.org, ozone-...@chromium.org
Peter Kvitek added 1 comment![]( "Open in Gerrit")
File ui/ozone/platform/headless/headless_window.cc
Line 180, Patchset 3:
UpdateBounds(delegate_->ConvertRectToPixels(zoomed_bounds));Colin Blundell . resolved
nit: Could use a comment explaining why this conversion is necessary here
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Peter Kvitek (Gerrit)
Oct 31, 2025, 11:14:07 AM (6 days ago) Oct 31
to Colin Blundell, Chromium LUCI CQ, chromium...@chromium.org, headless...@chromium.org, ozone-...@chromium.org
Peter Kvitek voted Commit-Queue+2![]( "Open in Gerrit")
| Commit-Queue | +2 |
Related details
Attention set is empty
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Chromium LUCI CQ (Gerrit)
Oct 31, 2025, 11:54:38 AM (6 days ago) Oct 31
to Peter Kvitek, Colin Blundell, chromium...@chromium.org, headless...@chromium.org, ozone-...@chromium.org
Chromium LUCI CQ submitted the change with unreviewed changes![]( "Open in Gerrit")
Unreviewed changes
3 is the latest approved patch-set.
The change was submitted with unreviewed changes in the following files:
```
The name of the file: ui/ozone/platform/headless/headless_window.cc
Insertions: 2, Deletions: 0.
The diff is too large to show. Please review the diff.
```
Change information
Commit message:
[headless] Fix scaled screen zoomed window size on Linux
This CL fixes double scaling that occurs in headless mode on Linux when
zooming a window located on a scaled screen.
Bug: 423951863
Change-Id: Idecf01f39cf32189a62d8b72c934a0ef125ff3a7
Reviewed-by: Colin Blundell <blun...@chromium.org>
Commit-Queue: Peter Kvitek <kvi...@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1538631}
Files:
- M chrome/browser/headless/headless_mode_protocol_browsertest.cc
- M ui/ozone/platform/headless/headless_window.cc
Change size: XS
Delta: 2 files changed, 5 insertions(+), 3 deletions(-)
Branch: refs/heads/main
Submit Requirements:
Code-Review: +1 by Colin Blundell
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Reply all
Reply to author
Forward
0 new messages