[//ui] Add command-line flag for loading ANGLE dynamically [chromium/src : main]

0 views
Skip to first unread message

Colin Blundell (Gerrit)

unread,
May 22, 2026, 7:38:26 AM (2 days ago) May 22
to Colin Blundell, Geoff Lang, Chromium LUCI CQ, android-bu...@system.gserviceaccount.com, chromium...@chromium.org, mac-r...@chromium.org, ozone-...@chromium.org
Attention needed from Geoff Lang

Colin Blundell added 1 comment

Patchset-level comments
File-level comment, Patchset 2 (Latest):
Colin Blundell . unresolved

Hey Geoff,

How could I easily test this locally to make sure the flag is working as expected? Thanks!

Open in Gerrit

Related details

Attention is currently required from:
  • Geoff Lang
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement satisfiedCode-Owners
  • requirement is not satisfiedCode-Review
  • requirement is not satisfiedNo-Unresolved-Comments
  • requirement is not satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: I70dc6e9ac257ffd120059846ac9399d9b4b6ad81
Gerrit-Change-Number: 7870933
Gerrit-PatchSet: 2
Gerrit-Owner: Colin Blundell <blun...@chromium.org>
Gerrit-Reviewer: Colin Blundell <blun...@chromium.org>
Gerrit-Reviewer: Geoff Lang <geof...@chromium.org>
Gerrit-Attention: Geoff Lang <geof...@chromium.org>
Gerrit-Comment-Date: Fri, 22 May 2026 11:38:14 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
satisfied_requirement
unsatisfied_requirement
open
diffy

Geoff Lang (Gerrit)

unread,
May 22, 2026, 12:16:51 PM (2 days ago) May 22
to Colin Blundell, Chromium LUCI CQ, android-bu...@system.gserviceaccount.com, chromium...@chromium.org, mac-r...@chromium.org, ozone-...@chromium.org
Attention needed from Colin Blundell

Geoff Lang voted and added 2 comments

Votes added by Geoff Lang

Code-Review+1

2 comments

Patchset-level comments
Geoff Lang . resolved

Thanks for adding this!

Colin Blundell . unresolved

Hey Geoff,

How could I easily test this locally to make sure the flag is working as expected? Thanks!

Geoff Lang

Build chrome `use_static_angle = true` but also build the `libGLESv2` and `libEGL` targets and ensure that `libGLESv2.so/dylib/dll` are in the same dir as the chrome binary. Run with `--use-dynamic-angle` and add a bit of logging in the dynamic loading path. You can also check the inverse, that GL init fails when setting the flag without those libs present.

To SUPER confirm, you would have to build a different version of ANGL, copy the outputs and check about:gpu for the git hash. This is probalby overkill.

Open in Gerrit

Related details

Attention is currently required from:
  • Colin Blundell
Submit Requirements:
    • requirement satisfiedCode-Coverage
    • requirement satisfiedCode-Owners
    • requirement satisfiedCode-Review
    • requirement is not satisfiedNo-Unresolved-Comments
    • requirement is not satisfiedReview-Enforcement
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: comment
    Gerrit-Project: chromium/src
    Gerrit-Branch: main
    Gerrit-Change-Id: I70dc6e9ac257ffd120059846ac9399d9b4b6ad81
    Gerrit-Change-Number: 7870933
    Gerrit-PatchSet: 2
    Gerrit-Owner: Colin Blundell <blun...@chromium.org>
    Gerrit-Reviewer: Colin Blundell <blun...@chromium.org>
    Gerrit-Reviewer: Geoff Lang <geof...@chromium.org>
    Gerrit-Attention: Colin Blundell <blun...@chromium.org>
    Gerrit-Comment-Date: Fri, 22 May 2026 16:16:43 +0000
    Gerrit-HasComments: Yes
    Gerrit-Has-Labels: Yes
    Comment-In-Reply-To: Colin Blundell <blun...@chromium.org>
    satisfied_requirement
    unsatisfied_requirement
    open
    diffy
    Reply all
    Reply to author
    Forward
    0 new messages