[Ozone/DRM]Present() rely on implicit sync when missing EGL context [chromium/src : main]

0 views
Skip to first unread message

Kramer Ge (Gerrit)

unread,
Jul 14, 2026, 1:04:23 PM (9 days ago) Jul 14
to Vasiliy Telezhnikov, Chromium LUCI CQ, chromium...@chromium.org, ozone-...@chromium.org
Attention needed from Vasiliy Telezhnikov

Kramer Ge voted Commit-Queue+1

Commit-Queue+1
Open in Gerrit

Related details

Attention is currently required from:
  • Vasiliy Telezhnikov
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement satisfiedCode-Owners
  • requirement is not satisfiedCode-Review
  • requirement is not satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: Ic4943514caac3bc2491d31d41e45b488dd5897e5
Gerrit-Change-Number: 8085517
Gerrit-PatchSet: 2
Gerrit-Owner: Kramer Ge <fang...@chromium.org>
Gerrit-Reviewer: Kramer Ge <fang...@chromium.org>
Gerrit-Reviewer: Vasiliy Telezhnikov <vas...@chromium.org>
Gerrit-Attention: Vasiliy Telezhnikov <vas...@chromium.org>
Gerrit-Comment-Date: Tue, 14 Jul 2026 17:04:12 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
satisfied_requirement
unsatisfied_requirement
open
diffy

Vasiliy Telezhnikov (Gerrit)

unread,
Jul 14, 2026, 1:14:21 PM (9 days ago) Jul 14
to Kramer Ge, Chromium LUCI CQ, chromium...@chromium.org, ozone-...@chromium.org
Attention needed from Kramer Ge

Vasiliy Telezhnikov added 1 comment

File ui/ozone/platform/drm/gpu/gbm_surfaceless.cc
Line 117, Patchset 2 (Latest): // egl context here, so rely on implicit sync.
Vasiliy Telezhnikov . unresolved

I don't think Vulkan supports implicit sync and I don't think we have any boards that are not atomic anymore (except Flex).

All crash reports seems to pass `--disable-explicit-dma-fences`, but I don't know why. It's not the flag that we [configure per board](https://source.chromium.org/chromiumos/chromiumos/codesearch/+/main:src/platform2/login_manager/chromium_command_builder.cc;drc=ed9561e7ab8a71fe4a9d9946cea99df8ebfc9449;l=523), so users have to toggle it in chrome://flags.

Right now it probably crashes few times and falls back to GL, but with this CL I suspect it might start flickering.

We probably can disable vulkan if this comand line passed.

Open in Gerrit

Related details

Attention is currently required from:
  • Kramer Ge
Submit Requirements:
    • requirement satisfiedCode-Coverage
    • requirement satisfiedCode-Owners
    • requirement is not satisfiedCode-Review
    • requirement is not satisfiedNo-Unresolved-Comments
    • requirement is not satisfiedReview-Enforcement
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: comment
    Gerrit-Project: chromium/src
    Gerrit-Branch: main
    Gerrit-Change-Id: Ic4943514caac3bc2491d31d41e45b488dd5897e5
    Gerrit-Change-Number: 8085517
    Gerrit-PatchSet: 2
    Gerrit-Owner: Kramer Ge <fang...@chromium.org>
    Gerrit-Reviewer: Kramer Ge <fang...@chromium.org>
    Gerrit-Reviewer: Vasiliy Telezhnikov <vas...@chromium.org>
    Gerrit-Attention: Kramer Ge <fang...@chromium.org>
    Gerrit-Comment-Date: Tue, 14 Jul 2026 17:13:49 +0000
    Gerrit-HasComments: Yes
    Gerrit-Has-Labels: No
    satisfied_requirement
    unsatisfied_requirement
    open
    diffy

    Kramer Ge (Gerrit)

    unread,
    Jul 14, 2026, 1:17:26 PM (9 days ago) Jul 14
    to Vasiliy Telezhnikov, Chromium LUCI CQ, chromium...@chromium.org, ozone-...@chromium.org
    Attention needed from Vasiliy Telezhnikov

    Kramer Ge added 1 comment

    File ui/ozone/platform/drm/gpu/gbm_surfaceless.cc
    Line 117, Patchset 2 (Latest): // egl context here, so rely on implicit sync.
    Vasiliy Telezhnikov . unresolved

    I don't think Vulkan supports implicit sync and I don't think we have any boards that are not atomic anymore (except Flex).

    All crash reports seems to pass `--disable-explicit-dma-fences`, but I don't know why. It's not the flag that we [configure per board](https://source.chromium.org/chromiumos/chromiumos/codesearch/+/main:src/platform2/login_manager/chromium_command_builder.cc;drc=ed9561e7ab8a71fe4a9d9946cea99df8ebfc9449;l=523), so users have to toggle it in chrome://flags.

    Right now it probably crashes few times and falls back to GL, but with this CL I suspect it might start flickering.

    We probably can disable vulkan if this comand line passed.

    Kramer Ge

    I missed `--disable-explicit-dma-fences` in crash reports. I'll disable vulkan.

    Open in Gerrit

    Related details

    Attention is currently required from:
    • Vasiliy Telezhnikov
    Submit Requirements:
    • requirement satisfiedCode-Coverage
    • requirement satisfiedCode-Owners
    • requirement is not satisfiedCode-Review
    • requirement is not satisfiedNo-Unresolved-Comments
    • requirement is not satisfiedReview-Enforcement
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: comment
    Gerrit-Project: chromium/src
    Gerrit-Branch: main
    Gerrit-Change-Id: Ic4943514caac3bc2491d31d41e45b488dd5897e5
    Gerrit-Change-Number: 8085517
    Gerrit-PatchSet: 2
    Gerrit-Owner: Kramer Ge <fang...@chromium.org>
    Gerrit-Reviewer: Kramer Ge <fang...@chromium.org>
    Gerrit-Reviewer: Vasiliy Telezhnikov <vas...@chromium.org>
    Gerrit-Attention: Vasiliy Telezhnikov <vas...@chromium.org>
    Gerrit-Comment-Date: Tue, 14 Jul 2026 17:17:14 +0000
    Gerrit-HasComments: Yes
    Gerrit-Has-Labels: No
    Comment-In-Reply-To: Vasiliy Telezhnikov <vas...@chromium.org>
    satisfied_requirement
    unsatisfied_requirement
    open
    diffy

    Kramer Ge (Gerrit)

    unread,
    Jul 14, 2026, 2:15:05 PM (9 days ago) Jul 14
    to Vasiliy Telezhnikov, Chromium LUCI CQ, chromium...@chromium.org, ozone-...@chromium.org
    Attention needed from Vasiliy Telezhnikov

    Kramer Ge voted and added 1 comment

    Votes added by Kramer Ge

    Commit-Queue+1

    1 comment

    File ui/ozone/platform/drm/gpu/gbm_surfaceless.cc
    Line 117, Patchset 2: // egl context here, so rely on implicit sync.
    Vasiliy Telezhnikov . resolved

    I don't think Vulkan supports implicit sync and I don't think we have any boards that are not atomic anymore (except Flex).

    All crash reports seems to pass `--disable-explicit-dma-fences`, but I don't know why. It's not the flag that we [configure per board](https://source.chromium.org/chromiumos/chromiumos/codesearch/+/main:src/platform2/login_manager/chromium_command_builder.cc;drc=ed9561e7ab8a71fe4a9d9946cea99df8ebfc9449;l=523), so users have to toggle it in chrome://flags.

    Right now it probably crashes few times and falls back to GL, but with this CL I suspect it might start flickering.

    We probably can disable vulkan if this comand line passed.

    Kramer Ge

    I missed `--disable-explicit-dma-fences` in crash reports. I'll disable vulkan.

    Kramer Ge

    Added early return in `GpuInit::InitializeVulkan()`.

    Open in Gerrit

    Related details

    Attention is currently required from:
    • Vasiliy Telezhnikov
    Submit Requirements:
    • requirement satisfiedCode-Coverage
    • requirement is not satisfiedCode-Owners
    • requirement is not satisfiedCode-Review
    • requirement is not satisfiedReview-Enforcement
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: comment
    Gerrit-Project: chromium/src
    Gerrit-Branch: main
    Gerrit-Change-Id: Ic4943514caac3bc2491d31d41e45b488dd5897e5
    Gerrit-Change-Number: 8085517
    Gerrit-PatchSet: 5
    Gerrit-Owner: Kramer Ge <fang...@chromium.org>
    Gerrit-Reviewer: Kramer Ge <fang...@chromium.org>
    Gerrit-Reviewer: Vasiliy Telezhnikov <vas...@chromium.org>
    Gerrit-Attention: Vasiliy Telezhnikov <vas...@chromium.org>
    Gerrit-Comment-Date: Tue, 14 Jul 2026 18:14:52 +0000
    Gerrit-HasComments: Yes
    Gerrit-Has-Labels: Yes
    Comment-In-Reply-To: Vasiliy Telezhnikov <vas...@chromium.org>
    Comment-In-Reply-To: Kramer Ge <fang...@chromium.org>
    satisfied_requirement
    unsatisfied_requirement
    open
    diffy

    Vasiliy Telezhnikov (Gerrit)

    unread,
    Jul 14, 2026, 2:47:08 PM (9 days ago) Jul 14
    to Kramer Ge, Chromium LUCI CQ, chromium...@chromium.org, ozone-...@chromium.org
    Attention needed from Kramer Ge

    Vasiliy Telezhnikov voted and added 1 comment

    Votes added by Vasiliy Telezhnikov

    Code-Review+1

    1 comment

    Patchset-level comments
    File-level comment, Patchset 6 (Latest):
    Vasiliy Telezhnikov . resolved

    lgtm, thanks.

    Open in Gerrit

    Related details

    Attention is currently required from:
    • Kramer Ge
    Submit Requirements:
    • requirement satisfiedCode-Coverage
    • requirement satisfiedCode-Owners
    • requirement satisfiedCode-Review
    • requirement satisfiedReview-Enforcement
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: comment
    Gerrit-Project: chromium/src
    Gerrit-Branch: main
    Gerrit-Change-Id: Ic4943514caac3bc2491d31d41e45b488dd5897e5
    Gerrit-Change-Number: 8085517
    Gerrit-PatchSet: 6
    Gerrit-Owner: Kramer Ge <fang...@chromium.org>
    Gerrit-Reviewer: Kramer Ge <fang...@chromium.org>
    Gerrit-Reviewer: Vasiliy Telezhnikov <vas...@chromium.org>
    Gerrit-Attention: Kramer Ge <fang...@chromium.org>
    Gerrit-Comment-Date: Tue, 14 Jul 2026 18:46:55 +0000
    Gerrit-HasComments: Yes
    Gerrit-Has-Labels: Yes
    satisfied_requirement
    open
    diffy

    Kramer Ge (Gerrit)

    unread,
    Jul 14, 2026, 2:57:01 PM (9 days ago) Jul 14
    to Vasiliy Telezhnikov, Chromium LUCI CQ, chromium...@chromium.org, ozone-...@chromium.org

    Kramer Ge voted Commit-Queue+2

    Commit-Queue+2
    Open in Gerrit

    Related details

    Attention set is empty
    Submit Requirements:
    • requirement satisfiedCode-Coverage
    • requirement satisfiedCode-Owners
    • requirement satisfiedCode-Review
    • requirement satisfiedReview-Enforcement
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: comment
    Gerrit-Project: chromium/src
    Gerrit-Branch: main
    Gerrit-Change-Id: Ic4943514caac3bc2491d31d41e45b488dd5897e5
    Gerrit-Change-Number: 8085517
    Gerrit-PatchSet: 6
    Gerrit-Owner: Kramer Ge <fang...@chromium.org>
    Gerrit-Reviewer: Kramer Ge <fang...@chromium.org>
    Gerrit-Reviewer: Vasiliy Telezhnikov <vas...@chromium.org>
    Gerrit-Comment-Date: Tue, 14 Jul 2026 18:56:49 +0000
    Gerrit-HasComments: No
    Gerrit-Has-Labels: Yes
    satisfied_requirement
    open
    diffy
    Reply all
    Reply to author
    Forward
    0 new messages