Fix maximizing window when in fullscreen on Wayland, X11 and Windows [chromium/src : main]

0 views
Skip to first unread message

David Bienvenu (Gerrit)

unread,
Nov 4, 2025, 11:31:42 AM (2 days ago) Nov 4
to Patryk Chodur, Kramer Ge, Marijn Kruisselbrink, AyeAye, Chromium LUCI CQ, chromium...@chromium.org, roblia...@chromium.org, sky+...@chromium.org, max+watc...@igalia.com, nickdiego+wa...@igalia.com, ozone-...@chromium.org
Attention needed from Kramer Ge, Marijn Kruisselbrink and Patryk Chodur

David Bienvenu voted and added 1 comment

Votes added by David Bienvenu

Code-Review+1

1 comment

Patchset-level comments
File-level comment, Patchset 5 (Latest):
David Bienvenu . resolved

This only works for programmatic maximizing, right, i.e., web apps? On Windows, there's no way to restore a full screen window with the mouse or keyboard (Windows key down arrow doesn't do a restore).

Open in Gerrit

Related details

Attention is currently required from:
  • Kramer Ge
  • Marijn Kruisselbrink
  • Patryk Chodur
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement is not satisfiedCode-Owners
  • requirement satisfiedCode-Review
  • requirement satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: I9e41664b996136b0f6983975592663a9e799eb53
Gerrit-Change-Number: 7095963
Gerrit-PatchSet: 5
Gerrit-Owner: Patryk Chodur <pch...@google.com>
Gerrit-Reviewer: David Bienvenu <davidb...@chromium.org>
Gerrit-Reviewer: Kramer Ge <fang...@chromium.org>
Gerrit-Reviewer: Marijn Kruisselbrink <m...@chromium.org>
Gerrit-Reviewer: Patryk Chodur <pch...@google.com>
Gerrit-Attention: Patryk Chodur <pch...@google.com>
Gerrit-Attention: Kramer Ge <fang...@chromium.org>
Gerrit-Attention: Marijn Kruisselbrink <m...@chromium.org>
Gerrit-Comment-Date: Tue, 04 Nov 2025 16:31:32 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
satisfied_requirement
unsatisfied_requirement
open
diffy

Patryk Chodur (Gerrit)

unread,
Nov 4, 2025, 11:34:32 AM (2 days ago) Nov 4
to David Bienvenu, Kramer Ge, Marijn Kruisselbrink, AyeAye, Chromium LUCI CQ, chromium...@chromium.org, roblia...@chromium.org, sky+...@chromium.org, max+watc...@igalia.com, nickdiego+wa...@igalia.com, ozone-...@chromium.org
Attention needed from Kramer Ge and Marijn Kruisselbrink

Patryk Chodur added 1 comment

Patchset-level comments
David Bienvenu . resolved

This only works for programmatic maximizing, right, i.e., web apps? On Windows, there's no way to restore a full screen window with the mouse or keyboard (Windows key down arrow doesn't do a restore).

Patryk Chodur

Yes exactly. I'm implementing web app APIs for maximizing, restoring and minimizing a window. Previously, some of the state changes were not implemented because they couldn't be triggered with UI.

Open in Gerrit

Related details

Attention is currently required from:
  • Kramer Ge
  • Marijn Kruisselbrink
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement is not satisfiedCode-Owners
  • requirement satisfiedCode-Review
  • requirement satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: I9e41664b996136b0f6983975592663a9e799eb53
Gerrit-Change-Number: 7095963
Gerrit-PatchSet: 5
Gerrit-Owner: Patryk Chodur <pch...@google.com>
Gerrit-Reviewer: David Bienvenu <davidb...@chromium.org>
Gerrit-Reviewer: Kramer Ge <fang...@chromium.org>
Gerrit-Reviewer: Marijn Kruisselbrink <m...@chromium.org>
Gerrit-Reviewer: Patryk Chodur <pch...@google.com>
Gerrit-Attention: Kramer Ge <fang...@chromium.org>
Gerrit-Attention: Marijn Kruisselbrink <m...@chromium.org>
Gerrit-Comment-Date: Tue, 04 Nov 2025 16:34:14 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: David Bienvenu <davidb...@chromium.org>
satisfied_requirement
unsatisfied_requirement
open
diffy

Marijn Kruisselbrink (Gerrit)

unread,
Nov 4, 2025, 12:50:51 PM (2 days ago) Nov 4
to Patryk Chodur, Marijn Kruisselbrink, David Bienvenu, Kramer Ge, AyeAye, Chromium LUCI CQ, chromium...@chromium.org, roblia...@chromium.org, sky+...@chromium.org, max+watc...@igalia.com, nickdiego+wa...@igalia.com, ozone-...@chromium.org
Attention needed from Kramer Ge and Patryk Chodur

Marijn Kruisselbrink voted Code-Review+1

Code-Review+1
Open in Gerrit

Related details

Attention is currently required from:
  • Kramer Ge
  • Patryk Chodur
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement is not satisfiedCode-Owners
  • requirement satisfiedCode-Review
  • requirement satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: I9e41664b996136b0f6983975592663a9e799eb53
Gerrit-Change-Number: 7095963
Gerrit-PatchSet: 5
Gerrit-Owner: Patryk Chodur <pch...@google.com>
Gerrit-Reviewer: David Bienvenu <davidb...@chromium.org>
Gerrit-Reviewer: Kramer Ge <fang...@chromium.org>
Gerrit-Reviewer: Marijn Kruisselbrink <m...@chromium.org>
Gerrit-Reviewer: Patryk Chodur <pch...@google.com>
Gerrit-Attention: Patryk Chodur <pch...@google.com>
Gerrit-Attention: Kramer Ge <fang...@chromium.org>
Gerrit-Comment-Date: Tue, 04 Nov 2025 17:50:41 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
satisfied_requirement
unsatisfied_requirement
open
diffy

Kramer Ge (Gerrit)

unread,
Nov 4, 2025, 1:58:17 PM (2 days ago) Nov 4
to Patryk Chodur, Marijn Kruisselbrink, David Bienvenu, AyeAye, Chromium LUCI CQ, chromium...@chromium.org, roblia...@chromium.org, sky+...@chromium.org, max+watc...@igalia.com, nickdiego+wa...@igalia.com, ozone-...@chromium.org
Attention needed from Patryk Chodur

Kramer Ge voted and added 1 comment

Votes added by Kramer Ge

Code-Review+1

1 comment

Patchset-level comments
Kramer Ge . resolved

Thank you!

Open in Gerrit

Related details

Attention is currently required from:
  • Patryk Chodur
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement satisfiedCode-Owners
  • requirement satisfiedCode-Review
  • requirement satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: I9e41664b996136b0f6983975592663a9e799eb53
Gerrit-Change-Number: 7095963
Gerrit-PatchSet: 5
Gerrit-Owner: Patryk Chodur <pch...@google.com>
Gerrit-Reviewer: David Bienvenu <davidb...@chromium.org>
Gerrit-Reviewer: Kramer Ge <fang...@chromium.org>
Gerrit-Reviewer: Marijn Kruisselbrink <m...@chromium.org>
Gerrit-Reviewer: Patryk Chodur <pch...@google.com>
Gerrit-Attention: Patryk Chodur <pch...@google.com>
Gerrit-Comment-Date: Tue, 04 Nov 2025 18:58:11 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
satisfied_requirement
open
diffy

Marijn Kruisselbrink (Gerrit)

unread,
Nov 4, 2025, 4:30:19 PM (2 days ago) Nov 4
to Patryk Chodur, Marijn Kruisselbrink, David Bienvenu, AyeAye, Chromium LUCI CQ, chromium...@chromium.org, roblia...@chromium.org, sky+...@chromium.org, max+watc...@igalia.com, nickdiego+wa...@igalia.com, ozone-...@chromium.org
Attention needed from Patryk Chodur

Marijn Kruisselbrink added 1 comment

Commit Message
Line 14, Patchset 5 (Latest):Bug: 40946306
Marijn Kruisselbrink . unresolved

Can you add `Include-Ci-Only-Tests: chromium.mac:Mac12 Tests|browser_tests` to verify that the new test also works on macOS?

Open in Gerrit

Related details

Attention is currently required from:
  • Patryk Chodur
Submit Requirements:
    • requirement satisfiedCode-Coverage
    • requirement satisfiedCode-Owners
    • requirement satisfiedCode-Review
    • requirement is not satisfiedNo-Unresolved-Comments
    • requirement satisfiedReview-Enforcement
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: comment
    Gerrit-Project: chromium/src
    Gerrit-Branch: main
    Gerrit-Change-Id: I9e41664b996136b0f6983975592663a9e799eb53
    Gerrit-Change-Number: 7095963
    Gerrit-PatchSet: 5
    Gerrit-Owner: Patryk Chodur <pch...@google.com>
    Gerrit-Reviewer: David Bienvenu <davidb...@chromium.org>
    Gerrit-Reviewer: Kramer Ge <fang...@chromium.org>
    Gerrit-Reviewer: Marijn Kruisselbrink <m...@chromium.org>
    Gerrit-Reviewer: Patryk Chodur <pch...@google.com>
    Gerrit-Attention: Patryk Chodur <pch...@google.com>
    Gerrit-Comment-Date: Tue, 04 Nov 2025 21:30:09 +0000
    Gerrit-HasComments: Yes
    Gerrit-Has-Labels: No
    satisfied_requirement
    unsatisfied_requirement
    open
    diffy
    Reply all
    Reply to author
    Forward
    0 new messages