drm: Add flag to assume Default colorspace is Rec709 [chromium/src : main]
0 views
Skip to first unread message
ccameron chromium (Gerrit)
Jan 8, 2026, 3:14:41 AMJan 8
to ccameron chromium, Sasha McIntosh, Chromium LUCI CQ, chromium...@chromium.org, ozone-...@chromium.org
Attention needed from Sasha McIntosh
ccameron chromium added 1 comment![]( "Open in Gerrit")
Patchset-level comments
File-level comment, Patchset 4 (Latest):
ccameron chromium . resolved
Happy new year! Turns out we were using EDID primaries wrong the whole time (gulp!)
Related details
Attention is currently required from:
- Sasha McIntosh
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Pin-yen Lin (Gerrit)
Jan 11, 2026, 10:29:40 PMJan 11
to ccameron chromium, Sasha McIntosh, Chromium LUCI CQ, chromium...@chromium.org, ozone-...@chromium.org
Attention needed from Sasha McIntosh
Pin-yen Lin added 1 comment![]( "Open in Gerrit")
Patchset-level comments
Pin-yen Lin . resolved
Friendly ping.
Related details
Attention is currently required from:
- Sasha McIntosh
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Sasha McIntosh (Gerrit)
Jan 12, 2026, 3:06:06 PMJan 12
to ccameron chromium, Pin-yen Lin, Chromium LUCI CQ, chromium...@chromium.org, ozone-...@chromium.org
Attention needed from ccameron chromium
Sasha McIntosh voted and added 3 comments![]( "Open in Gerrit")
Votes added by Sasha McIntosh
| Code-Review | +1 |
3 comments
Patchset-level comments
Sasha McIntosh . resolved
LGTM, added some comments for consideration but they are non-blocking.
File ui/ozone/platform/drm/gpu/drm_display.cc
Line 202, Patchset 4 (Latest):
} else {Sasha McIntosh . unresolved
Another possibility, add a case for BT709 and leave the default as is.
Line 212, Patchset 4 (Latest):
SetColorspaceProperty(kColorSpaceDefaultEnumName);Sasha McIntosh . unresolved
In the flagged case, should we set the colorspace property to one of "BT709_YCC", "XVYCC_709" ?
Related details
Attention is currently required from:
- ccameron chromium
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
No-Unresolved-Comments
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
ccameron chromium (Gerrit)
Jan 13, 2026, 9:55:22 AMJan 13
to ccameron chromium, Sasha McIntosh, Pin-yen Lin, Chromium LUCI CQ, chromium...@chromium.org, ozone-...@chromium.org
ccameron chromium voted and added 3 comments![]( "Open in Gerrit")
Votes added by ccameron chromium
| Commit-Queue | +2 |
3 comments
Patchset-level comments
ccameron chromium . resolved
Thanks!
File ui/ozone/platform/drm/gpu/drm_display.cc
Line 202, Patchset 4 (Latest):
} else {Sasha McIntosh . resolved
Another possibility, add a case for BT709 and leave the default as is.
ccameron chromium
Yeah, that's another good way to frame it. I put it under the default cause cause the feature flag is "default means 709".
Line 212, Patchset 4 (Latest):
SetColorspaceProperty(kColorSpaceDefaultEnumName);Sasha McIntosh . resolved
In the flagged case, should we set the colorspace property to one of "BT709_YCC", "XVYCC_709" ?
ccameron chromium
That's the long-term solution I'd want (just always say BT709_YCC). But we'd have to make sure that it doesn't un-WCG the WCG displays.
Related details
Attention set is empty
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Chromium LUCI CQ (Gerrit)
Jan 13, 2026, 10:38:23 AMJan 13
to ccameron chromium, Sasha McIntosh, Pin-yen Lin, chromium...@chromium.org, ozone-...@chromium.org
Chromium LUCI CQ submitted the change![]( "Open in Gerrit")
Change information
Commit message:
drm: Add flag to assume Default colorspace is Rec709
It is currently assumed that when the Colorspace property is set to
Default, the color primaries of the signal are set to the color
primaries read from the EDID. This happens to be correct for several
wide color gamut displays, but is not reliable. Many devices interpret
Default as Rec709.
Add a flag to allow interpreting Default as Rec709, and add a TODO to
more robustly signal the color space.
Bug: 467283738, 471224089
Change-Id: I9a30bc2f659093380f68d548d2bfc0ad671ae3ae
Reviewed-by: Sasha McIntosh <sasham...@chromium.org>
Commit-Queue: ccameron chromium <ccam...@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1568396}
Files:
- M ui/display/display_features.cc
- M ui/display/display_features.h
- M ui/ozone/platform/drm/common/drm_util.cc
- M ui/ozone/platform/drm/common/drm_util.h
- M ui/ozone/platform/drm/gpu/drm_display.cc
- M ui/ozone/platform/drm/gpu/drm_display.h
Change size: S
Delta: 6 files changed, 24 insertions(+), 16 deletions(-)
Branch: refs/heads/main
Submit Requirements:
Code-Review: +1 by Sasha McIntosh
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Reply all
Reply to author
Forward
0 new messages