[//gpu] Add feature that disallows GLES2 fallback [chromium/src : main]
0 views
Skip to first unread message
Kramer Ge (Gerrit)
Feb 3, 2026, 4:36:04 PMFeb 3
to chromium...@chromium.org, geoffla...@chromium.org, ozone-...@chromium.org
Kramer Ge voted and added 1 comment![]( "Open in Gerrit")
Votes added by Kramer Ge
| Commit-Queue | +1 |
1 comment
File gpu/config/gpu_info_collector.cc
Line 95, Patchset 1 (Latest):
attribs.allow_es_version_fallback =Kramer Ge . unresolved
This would covertly fallback to SW directly because it fails before `gl_use_swiftshader_` is [determined](https://chromium-review.googlesource.com/c/chromium/src/+/7036757/10/gpu/ipc/service/gpu_init.cc#620).
If we want to do swiftshader fallback first I can do it in `gpu_init.cc`.
Related details
Attention set is empty
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
No-Unresolved-Comments
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Colin Blundell (Gerrit)
Feb 4, 2026, 3:19:26 AMFeb 4
to Kramer Ge, Vasiliy Telezhnikov, Colin Blundell, Chromium LUCI CQ, chromium...@chromium.org, geoffla...@chromium.org, ozone-...@chromium.org
Attention needed from Kramer Ge and Vasiliy Telezhnikov
Colin Blundell added 1 comment![]( "Open in Gerrit")
Patchset-level comments
File-level comment, Patchset 1 (Latest):
Colin Blundell . resolved
Thanks! I'll review after Vasiliy LGTMs.
Related details
Attention is currently required from:
- Kramer Ge
- Vasiliy Telezhnikov
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
No-Unresolved-Comments
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Kramer Ge (Gerrit)
Feb 5, 2026, 11:57:57 AMFeb 5
to Vasiliy Telezhnikov, Colin Blundell, Chromium LUCI CQ, chromium...@chromium.org, geoffla...@chromium.org, ozone-...@chromium.org
Attention needed from Colin Blundell and Vasiliy Telezhnikov
Kramer Ge voted and added 1 comment![]( "Open in Gerrit")
Votes added by Kramer Ge
| Commit-Queue | +1 |
1 comment
File gpu/config/gpu_info_collector.cc
This would covertly fallback to SW directly because it fails before `gl_use_swiftshader_` is [determined](https://chromium-review.googlesource.com/c/chromium/src/+/7036757/10/gpu/ipc/service/gpu_init.cc#620).
If we want to do swiftshader fallback first I can do it in `gpu_init.cc`.
Kramer Ge
If swiftshader is allowed in the fallback list (WARP or `--enable-unsafe-swiftshader`), it will automatically start gpu in swiftshader.
Marked as resolved.
Related details
Attention is currently required from:
- Colin Blundell
- Vasiliy Telezhnikov
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Vasiliy Telezhnikov (Gerrit)
Feb 5, 2026, 1:38:16 PMFeb 5
to Kramer Ge, Colin Blundell, Chromium LUCI CQ, chromium...@chromium.org, geoffla...@chromium.org, ozone-...@chromium.org
Attention needed from Colin Blundell and Kramer Ge
Vasiliy Telezhnikov voted and added 1 comment![]( "Open in Gerrit")
Votes added by Vasiliy Telezhnikov
| Code-Review | +1 |
1 comment
Patchset-level comments
Related details
Attention is currently required from:
- Colin Blundell
- Kramer Ge
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Colin Blundell (Gerrit)
Feb 6, 2026, 3:19:25 AMFeb 6
to Kramer Ge, Colin Blundell, Vasiliy Telezhnikov, Chromium LUCI CQ, chromium...@chromium.org, geoffla...@chromium.org, ozone-...@chromium.org
Attention needed from Kramer Ge
Colin Blundell voted and added 1 comment![]( "Open in Gerrit")
Votes added by Colin Blundell
| Code-Review | +1 |
1 comment
Patchset-level comments
Colin Blundell . resolved
Thanks!
Attention is currently required from:
- Kramer Ge
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Kramer Ge (Gerrit)
Feb 6, 2026, 1:19:50 PM (14 days ago) Feb 6
to Colin Blundell, Vasiliy Telezhnikov, Chromium LUCI CQ, chromium...@chromium.org, geoffla...@chromium.org, ozone-...@chromium.org
Kramer Ge voted Commit-Queue+2![]( "Open in Gerrit")
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Chromium LUCI CQ (Gerrit)
Feb 6, 2026, 3:07:09 PM (14 days ago) Feb 6
to Kramer Ge, Colin Blundell, Vasiliy Telezhnikov, chromium...@chromium.org, geoffla...@chromium.org, ozone-...@chromium.org
Chromium LUCI CQ submitted the change![]( "Open in Gerrit")
Change information
Commit message:
[//gpu] Add feature that disallows GLES2 fallback
Feature FallbackToSWIfGLES3NotSupported forces gpu_info_collector to
request ES 3.0 context, and disallows 2.0 fallback, which will lead to
gpu process exit and fallback to the next mode.
If swiftshader is allowed in the fallback list (by WARP or
`--enable-unsafe-swiftshader`), it will automatically start gpu in
swiftshader mode. With swiftshader ANGLE can emulate ES 3.0.
Bug: 444049511
Change-Id: Ibeab66cff58404a0136962aef39a00902610768a
Reviewed-by: Colin Blundell <blun...@chromium.org>
Reviewed-by: Vasiliy Telezhnikov <vas...@chromium.org>
Commit-Queue: Kramer Ge <fang...@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1581047}
Files:
- M gpu/command_buffer/service/service_utils.cc
- M gpu/config/gpu_info_collector.cc
- M ui/gl/gl_features.cc
- M ui/gl/gl_features.h
Change size: S
Delta: 4 files changed, 12 insertions(+), 0 deletions(-)
Branch: refs/heads/main
Submit Requirements:
Code-Review: +1 by Colin Blundell, +1 by Vasiliy Telezhnikov
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Reply all
Reply to author
Forward
0 new messages