[headless] Extract utility methods from headless screen manager [chromium/src : main]
0 views
Skip to first unread message
Peter Kvitek (Gerrit)
Feb 25, 2026, 11:00:56 PMFeb 25
to Andrey Kosyakov, Chromium LUCI CQ, chromium...@chromium.org, devtools...@chromium.org, headless...@chromium.org, mac-r...@chromium.org, ozone-...@chromium.org
Attention needed from Andrey Kosyakov
New activity on the change![]( "Open in Gerrit")
Related details
Attention is currently required from:
- Andrey Kosyakov
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Andrey Kosyakov (Gerrit)
Feb 26, 2026, 12:44:40 PMFeb 26
to Peter Kvitek, Mitsuru Oshima, Chromium LUCI CQ, chromium...@chromium.org, devtools...@chromium.org, headless...@chromium.org, mac-r...@chromium.org, ozone-...@chromium.org
Attention needed from Mitsuru Oshima and Peter Kvitek
Andrey Kosyakov voted Code-Review+1![]( "Open in Gerrit")
Attention is currently required from:
- Mitsuru Oshima
- Peter Kvitek
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Colin Blundell (Gerrit)
Feb 27, 2026, 3:21:55 AMFeb 27
to Peter Kvitek, Colin Blundell, Dmitry Gozman, Andrey Kosyakov, Chromium LUCI CQ, chromium...@chromium.org, devtools...@chromium.org, headless...@chromium.org, mac-r...@chromium.org, ozone-...@chromium.org
Attention needed from Dmitry Gozman and Peter Kvitek
Colin Blundell voted and added 1 comment![]( "Open in Gerrit")
Votes added by Colin Blundell
| Code-Review | +1 |
1 comment
Patchset-level comments
Related details
Attention is currently required from:
- Dmitry Gozman
- Peter Kvitek
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Peter Kvitek (Gerrit)
Feb 27, 2026, 6:07:39 AMFeb 27
to Colin Blundell, Dmitry Gozman, Andrey Kosyakov, Chromium LUCI CQ, chromium...@chromium.org, devtools...@chromium.org, headless...@chromium.org, mac-r...@chromium.org, ozone-...@chromium.org
Attention needed from Dmitry Gozman
Peter Kvitek voted Commit-Queue+2![]( "Open in Gerrit")
| Commit-Queue | +2 |
Related details
Attention is currently required from:
- Dmitry Gozman
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Chromium LUCI CQ (Gerrit)
Feb 27, 2026, 6:10:59 AMFeb 27
to Peter Kvitek, Colin Blundell, Dmitry Gozman, Andrey Kosyakov, chromium...@chromium.org, devtools...@chromium.org, headless...@chromium.org, mac-r...@chromium.org, ozone-...@chromium.org
Chromium LUCI CQ submitted the change![]( "Open in Gerrit")
Change information
Commit message:
[headless] Extract utility methods from headless screen manager
This is in anticipation of more utility methods coming, see
http://crrev.com/c/7603249. These methods are often used by headless
screen manager clients, however, this is not always the case, so with
more of them on the way moving them out will ensure headless screen
manager readability
Bug: 404587568, 476931018
Bypass-Check-License: Renaming existing unit tests file.
Change-Id: I32ec2cac688d06513bac4be94d108548863b4e86
Reviewed-by: Andrey Kosyakov <ca...@chromium.org>
Reviewed-by: Colin Blundell <blun...@chromium.org>
Commit-Queue: Peter Kvitek <kvi...@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1591458}
Files:
- M chrome/browser/devtools/protocol/emulation_handler.cc
- M headless/lib/browser/headless_screen.cc
- M headless/lib/browser/protocol/emulation_handler.cc
- M ui/display/BUILD.gn
- M ui/display/headless/headless_screen_manager.cc
- M ui/display/headless/headless_screen_manager.h
- A ui/display/headless/headless_screen_util.cc
- A ui/display/headless/headless_screen_util.h
- R ui/display/headless/headless_screen_util_unittest.cc
- M ui/display/mac/screen_mac_headless.mm
- M ui/ozone/platform/headless/headless_screen.cc
Change size: L
Delta: 11 files changed, 168 insertions(+), 126 deletions(-)
Branch: refs/heads/main
Submit Requirements:
Code-Review: +1 by Andrey Kosyakov, +1 by Colin Blundell
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Reply all
Reply to author
Forward
0 new messages