Remove unread is_natural_landscape_map_ field from HeadlessScreen [chromium/src : main]

0 views
Skip to first unread message

Andrew Paseltiner (Gerrit)

unread,
Mar 16, 2026, 8:43:41 PMMar 16
to Colin Blundell, chromium...@chromium.org, headless...@chromium.org, ozone-...@chromium.org
Attention needed from Colin Blundell

Andrew Paseltiner voted Commit-Queue+1

Commit-Queue+1
Open in Gerrit

Related details

Attention is currently required from:
  • Colin Blundell
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement is not satisfiedCode-Owners
  • requirement is not satisfiedCode-Review
  • requirement is not satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: I3c8bdcbcac4ef2add7a6e9801c0f096c68428552
Gerrit-Change-Number: 7671227
Gerrit-PatchSet: 3
Gerrit-Owner: Andrew Paseltiner <apase...@chromium.org>
Gerrit-Reviewer: Andrew Paseltiner <apase...@chromium.org>
Gerrit-Reviewer: Colin Blundell <blun...@chromium.org>
Gerrit-Attention: Colin Blundell <blun...@chromium.org>
Gerrit-Comment-Date: Tue, 17 Mar 2026 00:43:36 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
satisfied_requirement
unsatisfied_requirement
open
diffy

Colin Blundell (Gerrit)

unread,
Mar 17, 2026, 4:02:58 AMMar 17
to Andrew Paseltiner, Colin Blundell, Peter Kvitek, Chromium LUCI CQ, chromium...@chromium.org, headless...@chromium.org, ozone-...@chromium.org
Attention needed from Andrew Paseltiner

Colin Blundell voted and added 1 comment

Votes added by Colin Blundell

Code-Review+1

1 comment

Patchset-level comments
File-level comment, Patchset 4 (Latest):
Colin Blundell . resolved

Thanks! +Peter FYI

Open in Gerrit

Related details

Attention is currently required from:
  • Andrew Paseltiner
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement satisfiedCode-Owners
  • requirement satisfiedCode-Review
  • requirement satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: I3c8bdcbcac4ef2add7a6e9801c0f096c68428552
Gerrit-Change-Number: 7671227
Gerrit-PatchSet: 4
Gerrit-Owner: Andrew Paseltiner <apase...@chromium.org>
Gerrit-Reviewer: Andrew Paseltiner <apase...@chromium.org>
Gerrit-Reviewer: Colin Blundell <blun...@chromium.org>
Gerrit-CC: Peter Kvitek <kvi...@chromium.org>
Gerrit-Attention: Andrew Paseltiner <apase...@chromium.org>
Gerrit-Comment-Date: Tue, 17 Mar 2026 08:02:42 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
satisfied_requirement
open
diffy

Andrew Paseltiner (Gerrit)

unread,
Mar 17, 2026, 8:21:17 AMMar 17
to Colin Blundell, Peter Kvitek, Chromium LUCI CQ, chromium...@chromium.org, headless...@chromium.org, ozone-...@chromium.org

Andrew Paseltiner voted Commit-Queue+2

Commit-Queue+2
Open in Gerrit

Related details

Attention set is empty
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement satisfiedCode-Owners
  • requirement satisfiedCode-Review
  • requirement satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: I3c8bdcbcac4ef2add7a6e9801c0f096c68428552
Gerrit-Change-Number: 7671227
Gerrit-PatchSet: 4
Gerrit-Owner: Andrew Paseltiner <apase...@chromium.org>
Gerrit-Reviewer: Andrew Paseltiner <apase...@chromium.org>
Gerrit-Reviewer: Colin Blundell <blun...@chromium.org>
Gerrit-CC: Peter Kvitek <kvi...@chromium.org>
Gerrit-Comment-Date: Tue, 17 Mar 2026 12:21:11 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
satisfied_requirement
open
diffy

Chromium LUCI CQ (Gerrit)

unread,
Mar 17, 2026, 8:25:32 AMMar 17
to Andrew Paseltiner, Colin Blundell, Peter Kvitek, chromium...@chromium.org, headless...@chromium.org, ozone-...@chromium.org

Chromium LUCI CQ submitted the change

Change information

Commit message:
Remove unread is_natural_landscape_map_ field from HeadlessScreen

Per crrev.com/c/6287167/comment/3d56a87d_46f60f12/ this field was
intended to be read in a followup CL, but it appears that never
happened.
Bug: 396072563
Change-Id: I3c8bdcbcac4ef2add7a6e9801c0f096c68428552
Reviewed-by: Colin Blundell <blun...@chromium.org>
Commit-Queue: Andrew Paseltiner <apase...@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1600467}
Files:
  • M ui/ozone/platform/headless/headless_screen.cc
  • M ui/ozone/platform/headless/headless_screen.h
Change size: XS
Delta: 2 files changed, 0 insertions(+), 4 deletions(-)
Branch: refs/heads/main
Submit Requirements:
  • requirement satisfiedCode-Review: +1 by Colin Blundell
Open in Gerrit
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: merged
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: I3c8bdcbcac4ef2add7a6e9801c0f096c68428552
Gerrit-Change-Number: 7671227
Gerrit-PatchSet: 5
Gerrit-Owner: Andrew Paseltiner <apase...@chromium.org>
Gerrit-Reviewer: Andrew Paseltiner <apase...@chromium.org>
Gerrit-Reviewer: Chromium LUCI CQ <chromiu...@luci-project-accounts.iam.gserviceaccount.com>
Gerrit-Reviewer: Colin Blundell <blun...@chromium.org>
open
diffy
satisfied_requirement
Reply all
Reply to author
Forward
0 new messages