CrOS: Remove the Peripheral Cust. flag. [chromium/src : main]
0 views
Skip to first unread message
Michael Checo (Gerrit)
Aug 3, 2026, 4:33:00 PM (10 days ago) Aug 3
to James Hawkins, Chromium LUCI CQ, Hidehiko Abe, Michael Spang, chromium...@chromium.org, asvitki...@chromium.org, croissant-...@chromium.org, cros-setti...@google.com, jimmyxgong+wat...@chromium.org, jimmyxgong+watch...@chromium.org, jmedle...@chromium.org, longbowei+watc...@google.com, michaelcheco+wa...@google.com, michaelcheco+watch-i...@google.com, oshima...@chromium.org, ozone-...@chromium.org, rrsilva+wat...@google.com, wangdanny+watch-in...@google.com, yyhyyh+watch-inpu...@google.com
Attention needed from Hidehiko Abe, James Hawkins and Michael Spang
Michael Checo added 1 comment![]( "Open in Gerrit")
Patchset-level comments
File-level comment, Patchset 3 (Latest):
Michael Checo . resolved
I'd recommend splitting this change into multiple CLs to make it easier to review and reduce regression risk. Feel free to structure the split however you see fit, but here's one option similar to what I did when removing the Welcome Experience flag (https://crrev.com/c/7629177):
1. ash/ and ui/events/
2. Settings/WebUI
3. Flag cleanup
Related details
Attention is currently required from:
- Hidehiko Abe
- James Hawkins
- Michael Spang
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Michael Checo (Gerrit)
Aug 3, 2026, 7:38:19 PM (9 days ago) Aug 3
to James Hawkins, Chromium LUCI CQ, Hidehiko Abe, Michael Spang, chromium...@chromium.org, asvitki...@chromium.org, croissant-...@chromium.org, cros-setti...@google.com, jimmyxgong+wat...@chromium.org, jimmyxgong+watch...@chromium.org, jmedle...@chromium.org, longbowei+watc...@google.com, michaelcheco+wa...@google.com, michaelcheco+watch-i...@google.com, oshima...@chromium.org, ozone-...@chromium.org, rrsilva+wat...@google.com, wangdanny+watch-in...@google.com, yyhyyh+watch-inpu...@google.com
Attention needed from Hidehiko Abe, James Hawkins and Michael Spang
Michael Checo voted Code-Review+1![]( "Open in Gerrit")
| Code-Review | +1 |
Related details
Attention is currently required from:
- Hidehiko Abe
- James Hawkins
- Michael Spang
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Hidehiko Abe (Gerrit)
Aug 3, 2026, 9:50:18 PM (9 days ago) Aug 3
to James Hawkins, Michael Checo, Chromium LUCI CQ, Michael Spang, chromium...@chromium.org, asvitki...@chromium.org, croissant-...@chromium.org, cros-setti...@google.com, jimmyxgong+wat...@chromium.org, jimmyxgong+watch...@chromium.org, jmedle...@chromium.org, longbowei+watc...@google.com, michaelcheco+wa...@google.com, michaelcheco+watch-i...@google.com, oshima...@chromium.org, ozone-...@chromium.org, rrsilva+wat...@google.com, wangdanny+watch-in...@google.com, yyhyyh+watch-inpu...@google.com
Attention needed from James Hawkins and Michael Spang
Hidehiko Abe voted Code-Review+1![]( "Open in Gerrit")
| Code-Review | +1 |
Related details
Attention is currently required from:
- James Hawkins
- Michael Spang
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
James Hawkins (Gerrit)
Aug 3, 2026, 10:09:27 PM (9 days ago) Aug 3
to Hidehiko Abe, Michael Checo, Chromium LUCI CQ, Michael Spang, chromium...@chromium.org, asvitki...@chromium.org, croissant-...@chromium.org, cros-setti...@google.com, jimmyxgong+wat...@chromium.org, jimmyxgong+watch...@chromium.org, jmedle...@chromium.org, longbowei+watc...@google.com, michaelcheco+wa...@google.com, michaelcheco+watch-i...@google.com, oshima...@chromium.org, ozone-...@chromium.org, rrsilva+wat...@google.com, wangdanny+watch-in...@google.com, yyhyyh+watch-inpu...@google.com
Attention needed from Michael Spang
James Hawkins voted Commit-Queue+2![]( "Open in Gerrit")
Attention is currently required from:
- Michael Spang
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Chromium LUCI CQ (Gerrit)
Aug 3, 2026, 11:21:45 PM (9 days ago) Aug 3
to James Hawkins, Hidehiko Abe, Michael Checo, Michael Spang, chromium...@chromium.org, asvitki...@chromium.org, croissant-...@chromium.org, cros-setti...@google.com, jimmyxgong+wat...@chromium.org, jimmyxgong+watch...@chromium.org, jmedle...@chromium.org, longbowei+watc...@google.com, michaelcheco+wa...@google.com, michaelcheco+watch-i...@google.com, oshima...@chromium.org, ozone-...@chromium.org, rrsilva+wat...@google.com, wangdanny+watch-in...@google.com, yyhyyh+watch-inpu...@google.com
Chromium LUCI CQ submitted the change![]( "Open in Gerrit")
Change information
Commit message:
CrOS: Remove the Peripheral Cust. flag.
Which has been enabled for a while.
Bug: none
Test: none
Change-Id: I055e0061c34c197f5e17b750214d09e6d61cd6ef
Commit-Queue: James Hawkins <jhaw...@chromium.org>
Reviewed-by: Michael Checo <michae...@google.com>
Reviewed-by: Hidehiko Abe <hide...@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1673042}
Files:
- M ash/accelerators/accelerator_controller_unittest.cc
- M ash/accelerators/shortcut_input_handler.cc
- M ash/constants/ash_features.cc
- M ash/constants/ash_features.h
- M ash/events/peripheral_customization_event_rewriter_unittest.cc
- M ash/shell.cc
- M ash/system/input_device_settings/input_device_notifier.cc
- M ash/system/input_device_settings/input_device_settings_controller_impl.cc
- M ash/system/input_device_settings/input_device_settings_controller_unittest.cc
- M ash/system/input_device_settings/input_device_settings_dispatcher.cc
- M ash/system/input_device_settings/input_device_settings_dispatcher_unittest.cc
- M ash/system/input_device_settings/pref_handlers/graphics_tablet_pref_handler_impl.cc
- M ash/system/input_device_settings/pref_handlers/graphics_tablet_pref_handler_unittest.cc
- M ash/system/input_device_settings/pref_handlers/mouse_pref_handler_impl.cc
- M ash/system/input_device_settings/pref_handlers/mouse_pref_handler_unittest.cc
- M ash/webui/common/backend/accelerator_fetcher_unittest.cc
- M ash/webui/common/backend/shortcut_input_provider.cc
- M ash/webui/common/backend/shortcut_input_provider_unittest.cc
- M chrome/browser/about_flags.cc
- M chrome/browser/ash/events/event_rewriter_delegate_impl.cc
- M chrome/browser/ash/events/event_rewriter_unittest.cc
- M chrome/browser/flag-metadata.json
- M chrome/browser/flag_descriptions.h
- M chrome/browser/resources/ash/settings/device_page/device_page.html
- M chrome/browser/resources/ash/settings/device_page/device_page.ts
- M chrome/browser/resources/ash/settings/device_page/per_device_mouse_subsection.html
- M chrome/browser/resources/ash/settings/device_page/per_device_mouse_subsection.ts
- M chrome/browser/resources/ash/settings/os_settings_routes.ts
- M chrome/browser/ui/ash/system/system_tray_client_impl.cc
- M chrome/browser/ui/ash/system/system_tray_client_impl_unittest.cc
- M chrome/browser/ui/webui/ash/settings/integration_tests/device_page/device_settings_interactive_uitest.cc
- M chrome/browser/ui/webui/ash/settings/os_settings_ui.cc
- M chrome/browser/ui/webui/ash/settings/pages/device/device_section.cc
- M chrome/browser/ui/webui/ash/settings/pages/device/input_device_settings/input_device_settings_provider.cc
- M chrome/browser/ui/webui/ash/settings/pages/device/input_device_settings/input_device_settings_provider_unittest.cc
- M chrome/browser/ui/webui/ash/settings/services/settings_manager/os_settings_manager_unittest.cc
- M chrome/test/data/webui/chromeos/settings/device_page/device_page_test.ts
- M chrome/test/data/webui/chromeos/settings/device_page/per_device_mouse_subsection_test.ts
- M chrome/test/data/webui/chromeos/settings/os_settings_browsertest.cc
- M ui/events/ozone/evdev/keyboard_evdev.cc
- M ui/events/ozone/evdev/pen_tablet_event_converter_evdev.cc
- M ui/events/ozone/evdev/pen_tablet_event_converter_evdev_unittest.cc
Change size: L
Delta: 42 files changed, 128 insertions(+), 592 deletions(-)
Branch: refs/heads/main
Submit Requirements:
Code-Review: +1 by Michael Checo, +1 by Hidehiko Abe
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Ming-Ying Chung (Gerrit)
Aug 4, 2026, 1:54:18 AM (9 days ago) Aug 4
to Chromium LUCI CQ, James Hawkins, Hidehiko Abe, Michael Checo, Michael Spang, chromium...@chromium.org, asvitki...@chromium.org, croissant-...@chromium.org, cros-setti...@google.com, jimmyxgong+wat...@chromium.org, jimmyxgong+watch...@chromium.org, jmedle...@chromium.org, longbowei+watc...@google.com, michaelcheco+wa...@google.com, michaelcheco+watch-i...@google.com, oshima...@chromium.org, ozone-...@chromium.org, rrsilva+wat...@google.com, wangdanny+watch-in...@google.com, yyhyyh+watch-inpu...@google.com
Ming-Ying Chung has created a revert of this change![]( "Open in Gerrit")
Related details
Attention set is empty
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Reply all
Reply to author
Forward
0 new messages