Remove workaround for ash-chrome M104 and prior [chromium/src : main]
0 views
Skip to first unread message
Seija K. (Gerrit)
Feb 21, 2023, 1:03:38 PM2/21/23
to Maksim Sisov, Kramer Ge, ozone-...@chromium.org
Attention is currently required from: Kramer Ge, Maksim Sisov.
Seija K. would like Maksim Sisov and Kramer Ge to review this change.
Remove workaround for ash-chrome M104 and prior
We do not use those versions anymore.
Bug: None
Change-Id: I3f77a1f1accb9f25fc5d16d93aa60bdd57df3759
---
M ui/ozone/platform/wayland/host/wayland_input_method_context.cc
1 file changed, 12 insertions(+), 20 deletions(-)
diff --git a/ui/ozone/platform/wayland/host/wayland_input_method_context.cc b/ui/ozone/platform/wayland/host/wayland_input_method_context.cc
index 9ee65f03..0939538 100644
--- a/ui/ozone/platform/wayland/host/wayland_input_method_context.cc
+++ b/ui/ozone/platform/wayland/host/wayland_input_method_context.cc
@@ -566,26 +566,6 @@
if (!layout_engine)
return;
- // TODO(crbug.com/1289236): This is for the backward compatibility with older
- // ash-chrome (M101 and earlier). In that version of ash-chrome didn't send
- // CapsLock so that we hit an issue on using it.
- // Because newer ash-chrome always sends CapsLock modifier map, as short term
- // workaround, check the condition to identify whether Lacros is running
- // on top of enough newer ash-chrome.
- // To avoid accident, we also check text_input_extension, which is available
- // only on ash-chrome.
- // We can remove this workaround check in M104 or later.
- absl::optional<std::vector<base::StringPiece>> modifiers;
- if (!connection_->text_input_extension_v1() ||
- base::Contains(modifiers_map_, XKB_MOD_NAME_CAPS)) {
- std::vector<base::StringPiece> modifier_content;
- for (size_t i = 0; i < modifiers_map_.size(); ++i) {
- if (modifiers_bits & (1 << i))
- modifier_content.emplace_back(modifiers_map_[i]);
- }
- modifiers = std::move(modifier_content);
- }
-
DomCode dom_code = static_cast<XkbKeyboardLayoutEngine*>(layout_engine)
->GetDomCodeByKeysym(keysym, modifiers);
if (dom_code == DomCode::NONE)
To view, visit change 4275445. To unsubscribe, or for help writing mail filters, visit settings.
Seija K. (Gerrit)
Feb 21, 2023, 1:03:41 PM2/21/23
to ozone-...@chromium.org, Maksim Sisov, Kramer Ge, chromium...@chromium.org
Attention is currently required from: Kramer Ge, Maksim Sisov.
Maksim Sisov (Gerrit)
Feb 22, 2023, 1:20:00 AM2/22/23
to Seija K., ozone-...@chromium.org, Kramer Ge, chromium...@chromium.org
Attention is currently required from: Kramer Ge, Seija K..
Patch set 1:Code-Review +1
Kramer Ge (Gerrit)
Feb 24, 2023, 2:00:38 PM2/24/23
to Seija K., ozone-...@chromium.org, Maksim Sisov, chromium...@chromium.org
Attention is currently required from: Seija K..
Patch set 2:Code-Review +1
Maksim Sisov (Gerrit)
Sep 12, 2023, 9:39:09 AM9/12/23
to Seija K., ozone-...@chromium.org, chromium...@chromium.org
Attention is currently required from: Seija K..
Patch set 2:-Code-Review
1 comment:
Patchset:
looks like it's no longer needed?
To view, visit change 4275445. To unsubscribe, or for help writing mail filters, visit settings.
Kramer Ge (Gerrit)
May 15, 2024, 2:44:15 PMMay 15
to Seija K., chromium...@chromium.org, ozone-...@chromium.org
Attention needed from Seija K.
Kramer Ge voted and added 1 comment![]( "Open in Gerrit")
Votes added by Kramer Ge
| Code-Review | +0 |
1 comment
File ui/ozone/platform/wayland/host/wayland_input_method_context.cc
Line 581, Patchset 2 (Parent):
std::vector<base::StringPiece> modifier_content;Kramer Ge . unresolved
rebase needed if you want to land it.
Related details
Attention is currently required from:
- Seija K.
Submit Requirements:
Code-Coverage
Code-Review
No-Unresolved-Comments
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Reply all
Reply to author
Forward
0 new messages