[//ui] Have DRMThread::CreateBufferFromHandle() talk SIFormat [chromium/src : main]

0 views
Skip to first unread message

Vasiliy Telezhnikov (Gerrit)

unread,
Nov 20, 2025, 12:00:16 PM (11 days ago) Nov 20
to Colin Blundell, Chromium LUCI CQ, chromium...@chromium.org, ozone-...@chromium.org
Attention needed from Colin Blundell

Vasiliy Telezhnikov voted and added 1 comment

Votes added by Vasiliy Telezhnikov

Code-Review+1

1 comment

Patchset-level comments
File-level comment, Patchset 1 (Latest):
Vasiliy Telezhnikov . resolved

lgtm, thanks.

Open in Gerrit

Related details

Attention is currently required from:
  • Colin Blundell
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement satisfiedCode-Owners
  • requirement satisfiedCode-Review
  • requirement satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: I9e23cd788fef338357d58e0a7400b4582622a2bb
Gerrit-Change-Number: 7177482
Gerrit-PatchSet: 1
Gerrit-Owner: Colin Blundell <blun...@chromium.org>
Gerrit-Reviewer: Colin Blundell <blun...@chromium.org>
Gerrit-Reviewer: Vasiliy Telezhnikov <vas...@chromium.org>
Gerrit-Attention: Colin Blundell <blun...@chromium.org>
Gerrit-Comment-Date: Thu, 20 Nov 2025 17:00:09 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
satisfied_requirement
open
diffy

Colin Blundell (Gerrit)

unread,
Nov 21, 2025, 2:44:55 AM (10 days ago) Nov 21
to Colin Blundell, Vasiliy Telezhnikov, Chromium LUCI CQ, chromium...@chromium.org, ozone-...@chromium.org

Colin Blundell voted and added 1 comment

Votes added by Colin Blundell

Commit-Queue+2

1 comment

Patchset-level comments
Colin Blundell . resolved

Thanks!

Open in Gerrit

Related details

Attention set is empty
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement satisfiedCode-Owners
  • requirement satisfiedCode-Review
  • requirement satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: I9e23cd788fef338357d58e0a7400b4582622a2bb
Gerrit-Change-Number: 7177482
Gerrit-PatchSet: 1
Gerrit-Owner: Colin Blundell <blun...@chromium.org>
Gerrit-Reviewer: Colin Blundell <blun...@chromium.org>
Gerrit-Reviewer: Vasiliy Telezhnikov <vas...@chromium.org>
Gerrit-Comment-Date: Fri, 21 Nov 2025 07:44:39 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
satisfied_requirement
open
diffy

Chromium LUCI CQ (Gerrit)

unread,
Nov 21, 2025, 2:47:38 AM (10 days ago) Nov 21
to Colin Blundell, Vasiliy Telezhnikov, chromium...@chromium.org, ozone-...@chromium.org

Chromium LUCI CQ submitted the change

Change information

Commit message:
[//ui] Have DRMThread::CreateBufferFromHandle() talk SIFormat

Eliminate need for callers to convert to BufferFormat.
Bug: 450325664
Change-Id: I9e23cd788fef338357d58e0a7400b4582622a2bb
Reviewed-by: Vasiliy Telezhnikov <vas...@chromium.org>
Commit-Queue: Colin Blundell <blun...@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1548287}
Files:
  • M ui/ozone/platform/drm/gpu/drm_thread.cc
  • M ui/ozone/platform/drm/gpu/drm_thread.h
  • M ui/ozone/platform/drm/gpu/drm_thread_proxy.cc
Change size: XS
Delta: 3 files changed, 4 insertions(+), 5 deletions(-)
Branch: refs/heads/main
Submit Requirements:
  • requirement satisfiedCode-Review: +1 by Vasiliy Telezhnikov
Open in Gerrit
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: merged
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: I9e23cd788fef338357d58e0a7400b4582622a2bb
Gerrit-Change-Number: 7177482
Gerrit-PatchSet: 2
Gerrit-Owner: Colin Blundell <blun...@chromium.org>
Gerrit-Reviewer: Chromium LUCI CQ <chromiu...@luci-project-accounts.iam.gserviceaccount.com>
Gerrit-Reviewer: Colin Blundell <blun...@chromium.org>
Gerrit-Reviewer: Vasiliy Telezhnikov <vas...@chromium.org>
open
diffy
satisfied_requirement
Reply all
Reply to author
Forward
0 new messages