Remove Expired Compositing.Display.DrmOverlayManager.* metrics [chromium/src : main]

Jonathan Ross (Gerrit)

unread,

May 19, 2022, 8:51:35 AM5/19/22

to Robert Kroeger, asvitkine...@chromium.org, ozone-...@chromium.org, Kevin Haslett

Attention is currently required from: Robert Kroeger.

Jonathan Ross would like Robert Kroeger to review this change.

Remove Expired Compositing.Display.DrmOverlayManager.* metrics

Metrics expired and no longer monitored. Just clearing them out.

Bug: 1109813
Change-Id: I9b5a0d5cec44f72942147a4f0bea3d2c91f234bf
---
M tools/metrics/histograms/metadata/compositing/histograms.xml
M ui/ozone/platform/drm/gpu/drm_overlay_manager.cc
M ui/ozone/platform/drm/gpu/drm_overlay_validator.cc
M ui/ozone/platform/drm/gpu/drm_overlay_validator.h
4 files changed, 18 insertions(+), 45 deletions(-)

To view, visit change 3653293. To unsubscribe, or for help writing mail filters, visit settings.

Jonathan Ross (Gerrit)

unread,

May 19, 2022, 8:51:42 AM5/19/22

to asvitkine...@chromium.org, ozone-...@chromium.org, Robert Kroeger, Kevin Haslett, Chromium Metrics Reviews, chromium...@chromium.org

Attention is currently required from: Robert Kroeger.

View Change

1 comment:

Patchset:
- Patch Set #1:
  +Rob for Owner's review
  +Kevin FYI
  Hey Rob, I'm looking to clear out an older expired metric from DrmOverlayManager. Could you PTAL? Thanks!

To view, visit change 3653293. To unsubscribe, or for help writing mail filters, visit settings.

Robert Kroeger (Gerrit)

unread,

May 19, 2022, 1:07:18 PM5/19/22

to Jonathan Ross, asvitkine...@chromium.org, ozone-...@chromium.org, Kevin Haslett, Chromium Metrics Reviews, chromium...@chromium.org

Attention is currently required from: Jonathan Ross.

Patch set 1:Code-Review +1

View Change

To view, visit change 3653293. To unsubscribe, or for help writing mail filters, visit settings.

Jonathan Ross (Gerrit)

unread,

May 19, 2022, 1:13:30 PM5/19/22

to asvitkine...@chromium.org, ozone-...@chromium.org, Robert Kroeger, Kevin Haslett, Chromium Metrics Reviews, chromium...@chromium.org

Attention is currently required from: Jonathan Ross.

Patch set 1:Commit-Queue +2

View Change

To view, visit change 3653293. To unsubscribe, or for help writing mail filters, visit settings.

Jonathan Ross (Gerrit)

unread,

May 24, 2022, 8:49:53 AM5/24/22

to asvitkine...@chromium.org, ozone-...@chromium.org, Chromium LUCI CQ, Robert Kroeger, Kevin Haslett, Chromium Metrics Reviews, chromium...@chromium.org

Attention is currently required from: Jonathan Ross.

Patch set 1:Commit-Queue +2

View Change

To view, visit change 3653293. To unsubscribe, or for help writing mail filters, visit settings.

Jonathan Ross (Gerrit)

unread,

May 24, 2022, 3:20:12 PM5/24/22

to asvitkine...@chromium.org, ozone-...@chromium.org, Chromium LUCI CQ, Robert Kroeger, Kevin Haslett, Chromium Metrics Reviews, chromium...@chromium.org

Chromium LUCI CQ (Gerrit)

unread,

May 24, 2022, 4:00:09 PM5/24/22

to Jonathan Ross, asvitkine...@chromium.org, ozone-...@chromium.org, Robert Kroeger, Kevin Haslett, Chromium Metrics Reviews, chromium...@chromium.org

Chromium LUCI CQ submitted this change.

View Change

Approvals:
  Robert Kroeger: Looks good to me
  Jonathan Ross: Commit

Remove Expired Compositing.Display.DrmOverlayManager.* metrics

Metrics expired and no longer monitored. Just clearing them out.

Bug: 1109813
Change-Id: I9b5a0d5cec44f72942147a4f0bea3d2c91f234bf

Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3653293
Commit-Queue: Jonathan Ross <jon...@chromium.org>
Reviewed-by: Robert Kroeger <rjkr...@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1007022}


---
M tools/metrics/histograms/metadata/compositing/histograms.xml
M ui/ozone/platform/drm/gpu/drm_overlay_manager.cc
M ui/ozone/platform/drm/gpu/drm_overlay_validator.cc
M ui/ozone/platform/drm/gpu/drm_overlay_validator.h

4 files changed, 22 insertions(+), 45 deletions(-)

To view, visit change 3653293. To unsubscribe, or for help writing mail filters, visit settings.

Reply all

Reply to author

Forward