Revert "[fuchsia][flatland] Validate image size and layout" [chromium/src : main]

0 views
Skip to first unread message

David Song (Gerrit)

unread,
Jul 21, 2026, 6:33:50 PM (2 days ago) Jul 21
to rubber-...@appspot.gserviceaccount.com, android-bu...@system.gserviceaccount.com, Chromium LUCI CQ, Zijie He, David Worsham, chromium...@chromium.org, Robert Kroeger, spang...@chromium.org, fuchsia...@chromium.org, ozone-...@chromium.org, emi...@google.com
Attention needed from Zijie He

David Song voted

Auto-Submit+1
Commit-Queue+1
Open in Gerrit

Related details

Attention is currently required from:
  • Zijie He
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement satisfiedCode-Owners
  • requirement is not satisfiedCode-Review
  • requirement is not satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: I6495f8acf968b4616eaf2e13f27f4c438b4acaf5
Gerrit-Change-Number: 8127139
Gerrit-PatchSet: 3
Gerrit-Owner: David Song <winter...@google.com>
Gerrit-Reviewer: Chromium LUCI CQ <chromiu...@luci-project-accounts.iam.gserviceaccount.com>
Gerrit-Reviewer: David Song <winter...@google.com>
Gerrit-Reviewer: Zijie He <zij...@google.com>
Gerrit-CC: David Worsham <dwor...@google.com>
Gerrit-CC: Robert Kroeger <rjkr...@chromium.org>
Gerrit-Attention: Zijie He <zij...@google.com>
Gerrit-Comment-Date: Tue, 21 Jul 2026 22:33:33 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
satisfied_requirement
unsatisfied_requirement
open
diffy

rubber-stamper@appspot.gserviceaccount.com (Gerrit)

unread,
Jul 21, 2026, 6:34:26 PM (2 days ago) Jul 21
to David Song, android-bu...@system.gserviceaccount.com, Chromium LUCI CQ, Zijie He, David Worsham, chromium...@chromium.org, Robert Kroeger, spang...@chromium.org, fuchsia...@chromium.org, ozone-...@chromium.org, emi...@google.com
Attention needed from Zijie He

Message from rubber-...@appspot.gserviceaccount.com

Gerrit GetPureRevert API does not mark this CL as a pure revert. Learn more: go/rubber-stamper-user-guide.

Gerrit-Comment-Date: Tue, 21 Jul 2026 22:34:13 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
satisfied_requirement
unsatisfied_requirement
open
diffy

David Song (Gerrit)

unread,
Jul 21, 2026, 7:02:38 PM (2 days ago) Jul 21
to android-bu...@system.gserviceaccount.com, Chromium LUCI CQ, Zijie He, David Worsham, chromium...@chromium.org, Robert Kroeger, spang...@chromium.org, fuchsia...@chromium.org, ozone-...@chromium.org, emi...@google.com
Attention needed from Zijie He

David Song voted Auto-Submit+0

Auto-Submit+0
Open in Gerrit

Related details

Attention is currently required from:
  • Zijie He
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement satisfiedCode-Owners
  • requirement is not satisfiedCode-Review
  • requirement is not satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: I6495f8acf968b4616eaf2e13f27f4c438b4acaf5
Gerrit-Change-Number: 8127139
Gerrit-PatchSet: 3
Gerrit-Owner: David Song <winter...@google.com>
Gerrit-Reviewer: Chromium LUCI CQ <chromiu...@luci-project-accounts.iam.gserviceaccount.com>
Gerrit-Reviewer: David Song <winter...@google.com>
Gerrit-Reviewer: Zijie He <zij...@google.com>
Gerrit-CC: David Worsham <dwor...@google.com>
Gerrit-CC: Robert Kroeger <rjkr...@chromium.org>
Gerrit-Attention: Zijie He <zij...@google.com>
Gerrit-Comment-Date: Tue, 21 Jul 2026 23:02:10 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
satisfied_requirement
unsatisfied_requirement
open
diffy

Zijie He (Gerrit)

unread,
Jul 21, 2026, 7:09:56 PM (2 days ago) Jul 21
to David Song, android-bu...@system.gserviceaccount.com, Chromium LUCI CQ, David Worsham, chromium...@chromium.org, Robert Kroeger, spang...@chromium.org, fuchsia...@chromium.org, ozone-...@chromium.org, emi...@google.com
Attention needed from David Song

Zijie He voted Code-Review+1

Code-Review+1
Open in Gerrit

Related details

Attention is currently required from:
  • David Song
Submit Requirements:
    • requirement satisfiedCode-Coverage
    • requirement satisfiedCode-Owners
    • requirement satisfiedCode-Review
    • requirement satisfiedReview-Enforcement
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: comment
    Gerrit-Project: chromium/src
    Gerrit-Branch: main
    Gerrit-Change-Id: I6495f8acf968b4616eaf2e13f27f4c438b4acaf5
    Gerrit-Change-Number: 8127139
    Gerrit-PatchSet: 3
    Gerrit-Owner: David Song <winter...@google.com>
    Gerrit-Reviewer: Chromium LUCI CQ <chromiu...@luci-project-accounts.iam.gserviceaccount.com>
    Gerrit-Reviewer: David Song <winter...@google.com>
    Gerrit-Reviewer: Zijie He <zij...@google.com>
    Gerrit-CC: David Worsham <dwor...@google.com>
    Gerrit-CC: Robert Kroeger <rjkr...@chromium.org>
    Gerrit-Attention: David Song <winter...@google.com>
    Gerrit-Comment-Date: Tue, 21 Jul 2026 23:09:44 +0000
    Gerrit-HasComments: No
    Gerrit-Has-Labels: Yes
    satisfied_requirement
    open
    diffy

    David Song (Gerrit)

    unread,
    Jul 21, 2026, 7:20:06 PM (2 days ago) Jul 21
    to Zijie He, android-bu...@system.gserviceaccount.com, Chromium LUCI CQ, David Worsham, chromium...@chromium.org, Robert Kroeger, spang...@chromium.org, fuchsia...@chromium.org, ozone-...@chromium.org, emi...@google.com

    David Song voted Commit-Queue+2

    Commit-Queue+2
    Open in Gerrit

    Related details

    Attention set is empty
    Submit Requirements:
    • requirement satisfiedCode-Coverage
    • requirement satisfiedCode-Owners
    • requirement satisfiedCode-Review
    • requirement satisfiedReview-Enforcement
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: comment
    Gerrit-Project: chromium/src
    Gerrit-Branch: main
    Gerrit-Change-Id: I6495f8acf968b4616eaf2e13f27f4c438b4acaf5
    Gerrit-Change-Number: 8127139
    Gerrit-PatchSet: 3
    Gerrit-Owner: David Song <winter...@google.com>
    Gerrit-Reviewer: Chromium LUCI CQ <chromiu...@luci-project-accounts.iam.gserviceaccount.com>
    Gerrit-Reviewer: David Song <winter...@google.com>
    Gerrit-Reviewer: Zijie He <zij...@google.com>
    Gerrit-CC: David Worsham <dwor...@google.com>
    Gerrit-CC: Robert Kroeger <rjkr...@chromium.org>
    Gerrit-Comment-Date: Tue, 21 Jul 2026 23:19:51 +0000
    Gerrit-HasComments: No
    Gerrit-Has-Labels: Yes
    satisfied_requirement
    open
    diffy

    Chromium LUCI CQ (Gerrit)

    unread,
    Jul 21, 2026, 7:23:54 PM (2 days ago) Jul 21
    to David Song, Zijie He, android-bu...@system.gserviceaccount.com, David Worsham, chromium...@chromium.org, Robert Kroeger, spang...@chromium.org, fuchsia...@chromium.org, ozone-...@chromium.org, emi...@google.com

    Chromium LUCI CQ submitted the change

    Change information

    Commit message:
    Revert "[fuchsia][flatland] Validate image size and layout"

    This reverts commit bfa06f769ad504b55f5a650c9b6f95cb7a2684e5.

    Reason for revert: Broke hardware bots

    Failure Link: https://ci.chromium.org/ui/p/chrome/builders/ci/fuchsia-fyi-sherlock/33175/overview

    Original change's description:
    > [fuchsia][flatland] Validate image size and layout
    >
    > Validate gfx::Size and format in Initialize, CreateNativePixmap, and
    > CreateVkImage to prevent buffer overflows.
    >
    > - Unify size validation and layout calculation in the
    >   CalculateBufferLayout helper using checked math.
    > - Verify that the computed image layout fits within the allocated buffer
    >   size.
    > - Keep layout boundary checks and early size/format checks as graceful
    >   failures (returning nullptr or false) to prevent DoS from untrusted
    >   inputs.
    > - Convert Vulkan memory requirements checks to CHECKs (crash on
    >   unexpected system values).
    >
    > TAG=agy
    > CONV=c64f46f9-7333-4bcf-8497-788ae27b1ce7
    >
    > Bug: 500576940
    > Change-Id: I5a89a49b8be9a165d3da9b78c2cf1d56a6b697eb
    > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/8007838
    > Auto-Submit: David Song <winter...@google.com>
    > Commit-Queue: David Song <winter...@google.com>
    > Reviewed-by: Zijie He <zij...@google.com>
    > Cr-Commit-Position: refs/heads/main@{#1664843}
    Bug: 500576940
    Change-Id: I6495f8acf968b4616eaf2e13f27f4c438b4acaf5
    Reviewed-by: Zijie He <zij...@google.com>
    Commit-Queue: David Song <winter...@google.com>
    Cr-Commit-Position: refs/heads/main@{#1665881}
    Files:
    • M ui/ozone/platform/flatland/flatland_sysmem_buffer_collection.cc
    Change size: M
    Delta: 1 file changed, 26 insertions(+), 128 deletions(-)
    Branch: refs/heads/main
    Submit Requirements:
    • requirement satisfiedCode-Review: +1 by Zijie He
    Open in Gerrit
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: merged
    Gerrit-Project: chromium/src
    Gerrit-Branch: main
    Gerrit-Change-Id: I6495f8acf968b4616eaf2e13f27f4c438b4acaf5
    Gerrit-Change-Number: 8127139
    Gerrit-PatchSet: 4
    open
    diffy
    satisfied_requirement
    Reply all
    Reply to author
    Forward
    0 new messages