Remove kHandleOverlaysSwapFailure feature [chromium/src : main]
0 views
Skip to first unread message
Jonathan Ross (Gerrit)
Jan 7, 2026, 10:12:52 AM (4 days ago) Jan 7
to Kramer Ge, Chromium LUCI CQ, Chromium Metrics Reviews, chromium...@chromium.org, asvitkine...@chromium.org, cc-...@chromium.org, ozone-...@chromium.org, penghu...@chromium.org
Attention needed from Kramer Ge
Jonathan Ross added 1 comment![]( "Open in Gerrit")
Patchset-level comments
File-level comment, Patchset 1 (Latest):
Jonathan Ross . resolved
Hey fangzhoug@ I'm looking to cleanup a feature that didn't ship, and the related metrics. Could you PTAL? Thanks!
Related details
Attention is currently required from:
- Kramer Ge
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Kramer Ge (Gerrit)
Jan 7, 2026, 2:08:26 PM (4 days ago) Jan 7
to Jonathan Ross, Chromium LUCI CQ, Chromium Metrics Reviews, chromium...@chromium.org, asvitkine...@chromium.org, cc-...@chromium.org, ozone-...@chromium.org, penghu...@chromium.org
Attention needed from Jonathan Ross
Kramer Ge voted and added 1 comment![]( "Open in Gerrit")
Votes added by Kramer Ge
| Code-Review | +1 |
1 comment
Patchset-level comments
Attention is currently required from:
- Jonathan Ross
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Jonathan Ross (Gerrit)
Jan 7, 2026, 2:29:07 PM (4 days ago) Jan 7
to Zhenyao Mo, Chromium LUCI CQ, Chromium Metrics Reviews, chromium...@chromium.org, asvitkine...@chromium.org, cc-...@chromium.org, ozone-...@chromium.org, penghu...@chromium.org
Attention needed from Zhenyao Mo
Jonathan Ross added 1 comment![]( "Open in Gerrit")
Patchset-level comments
Jonathan Ross . resolved
+zmo@ for gpu/* for removal of a disabled-by-default feature
Related details
Attention is currently required from:
- Zhenyao Mo
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Zhenyao Mo (Gerrit)
Jan 7, 2026, 4:34:56 PM (4 days ago) Jan 7
to Jonathan Ross, Chromium LUCI CQ, Chromium Metrics Reviews, chromium...@chromium.org, asvitkine...@chromium.org, cc-...@chromium.org, ozone-...@chromium.org, penghu...@chromium.org
Attention needed from Jonathan Ross
Zhenyao Mo voted Code-Review+1![]( "Open in Gerrit")
Attention is currently required from:
- Jonathan Ross
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Jonathan Ross (Gerrit)
Jan 8, 2026, 9:26:05 AM (3 days ago) Jan 8
to Zhenyao Mo, Kramer Ge, Chromium LUCI CQ, Chromium Metrics Reviews, chromium...@chromium.org, asvitkine...@chromium.org, cc-...@chromium.org, ozone-...@chromium.org, penghu...@chromium.org
Attention needed from Kramer Ge and Zhenyao Mo
Jonathan Ross added 1 comment![]( "Open in Gerrit")
Patchset-level comments
File-level comment, Patchset 3 (Latest):
Jonathan Ross . resolved
Rebase solved merge conflict in histograms.xml
Related details
Attention is currently required from:
- Kramer Ge
- Zhenyao Mo
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Jonathan Ross (Gerrit)
Jan 8, 2026, 9:26:08 AM (3 days ago) Jan 8
to Zhenyao Mo, Kramer Ge, Chromium LUCI CQ, Chromium Metrics Reviews, chromium...@chromium.org, asvitkine...@chromium.org, cc-...@chromium.org, ozone-...@chromium.org, penghu...@chromium.org
Attention needed from Kramer Ge and Zhenyao Mo
Jonathan Ross voted Commit-Queue+2![]( "Open in Gerrit")
| Commit-Queue | +2 |
Chromium LUCI CQ (Gerrit)
Jan 8, 2026, 10:49:14 AM (3 days ago) Jan 8
to Jonathan Ross, Zhenyao Mo, Kramer Ge, Chromium Metrics Reviews, chromium...@chromium.org, asvitkine...@chromium.org, cc-...@chromium.org, ozone-...@chromium.org, penghu...@chromium.org
Chromium LUCI CQ submitted the change![]( "Open in Gerrit")
Unreviewed changes
1 is the latest approved patch-set.
No files were changed between the latest approved patch-set and the submitted one.
Change information
Commit message:
Remove kHandleOverlaysSwapFailure feature
Gains seemed minimal, and there was more required to launch. This is
currently not under development. Removing it.
Bug: 379691125
Change-Id: I9707b173106d2651dd705becd3b2671f7187bf38
Reviewed-by: Zhenyao Mo <z...@chromium.org>
Commit-Queue: Jonathan Ross <jon...@chromium.org>
Reviewed-by: Kramer Ge <fang...@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1566297}
Files:
- M components/viz/service/display_embedder/skia_output_surface_dependency_impl.cc
- M components/viz/service/display_embedder/skia_output_surface_impl_on_gpu.cc
- M gpu/config/gpu_finch_features.cc
- M gpu/config/gpu_finch_features.h
- M gpu/ipc/service/gpu_init.cc
- M tools/metrics/histograms/metadata/compositing/histograms.xml
- M ui/ozone/platform/drm/gpu/drm_overlay_manager.cc
- M ui/ozone/platform/drm/gpu/drm_overlay_manager.h
- M ui/ozone/platform/drm/gpu/drm_overlay_manager_gpu.cc
- M ui/ozone/platform/drm/gpu/drm_overlay_manager_gpu.h
- M ui/ozone/platform/drm/gpu/drm_overlay_manager_unittest.cc
- M ui/ozone/platform/drm/ozone_platform_drm.cc
- M ui/ozone/public/ozone_platform.h
Change size: M
Delta: 13 files changed, 9 insertions(+), 220 deletions(-)
Branch: refs/heads/main
Submit Requirements:
Code-Review: +1 by Kramer Ge, +1 by Zhenyao Mo
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Reply all
Reply to author
Forward
0 new messages