Remove GbmSurfaceless::SetNotifyNonSimpleOverlayFailure [chromium/src : main]

0 views
Skip to first unread message

Jonathan Ross (Gerrit)

unread,
Jan 7, 2026, 3:16:57 PM (4 days ago) Jan 7
to Kramer Ge, Zhenyao Mo, chromium...@chromium.org, ozone-...@chromium.org
Attention needed from Kramer Ge and Zhenyao Mo

Jonathan Ross added 1 comment

Patchset-level comments
File-level comment, Patchset 1 (Latest):
Jonathan Ross . resolved

fangzhoug for ui/ozone
zmo for ui/gl

Open in Gerrit

Related details

Attention is currently required from:
  • Kramer Ge
  • Zhenyao Mo
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement is not satisfiedCode-Owners
  • requirement is not satisfiedCode-Review
  • requirement is not satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: Ie5eda69ffe540ce61a61536f6251b63c3948cd9d
Gerrit-Change-Number: 7408671
Gerrit-PatchSet: 1
Gerrit-Owner: Jonathan Ross <jon...@chromium.org>
Gerrit-Reviewer: Kramer Ge <fang...@chromium.org>
Gerrit-Reviewer: Zhenyao Mo <z...@chromium.org>
Gerrit-Attention: Kramer Ge <fang...@chromium.org>
Gerrit-Attention: Zhenyao Mo <z...@chromium.org>
Gerrit-Comment-Date: Wed, 07 Jan 2026 20:16:50 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
satisfied_requirement
unsatisfied_requirement
open
diffy

Kramer Ge (Gerrit)

unread,
Jan 7, 2026, 3:48:22 PM (4 days ago) Jan 7
to Jonathan Ross, Zhenyao Mo, chromium...@chromium.org, ozone-...@chromium.org
Attention needed from Jonathan Ross and Zhenyao Mo

Kramer Ge voted Code-Review+1

Code-Review+1
Open in Gerrit

Related details

Attention is currently required from:
  • Jonathan Ross
  • Zhenyao Mo
Submit Requirements:
    • requirement satisfiedCode-Coverage
    • requirement is not satisfiedCode-Owners
    • requirement satisfiedCode-Review
    • requirement satisfiedReview-Enforcement
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: comment
    Gerrit-Project: chromium/src
    Gerrit-Branch: main
    Gerrit-Change-Id: Ie5eda69ffe540ce61a61536f6251b63c3948cd9d
    Gerrit-Change-Number: 7408671
    Gerrit-PatchSet: 1
    Gerrit-Owner: Jonathan Ross <jon...@chromium.org>
    Gerrit-Reviewer: Kramer Ge <fang...@chromium.org>
    Gerrit-Reviewer: Zhenyao Mo <z...@chromium.org>
    Gerrit-Attention: Jonathan Ross <jon...@chromium.org>
    Gerrit-Attention: Zhenyao Mo <z...@chromium.org>
    Gerrit-Comment-Date: Wed, 07 Jan 2026 20:48:14 +0000
    Gerrit-HasComments: No
    Gerrit-Has-Labels: Yes
    satisfied_requirement
    unsatisfied_requirement
    open
    diffy

    Zhenyao Mo (Gerrit)

    unread,
    Jan 7, 2026, 4:34:08 PM (4 days ago) Jan 7
    to Jonathan Ross, chromium...@chromium.org, ozone-...@chromium.org
    Attention needed from Jonathan Ross

    Zhenyao Mo voted Code-Review+1

    Code-Review+1
    Open in Gerrit

    Related details

    Attention is currently required from:
    • Jonathan Ross
    Submit Requirements:
    • requirement satisfiedCode-Coverage
    • requirement satisfiedCode-Owners
    • requirement satisfiedCode-Review
    • requirement satisfiedReview-Enforcement
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: comment
    Gerrit-Project: chromium/src
    Gerrit-Branch: main
    Gerrit-Change-Id: Ie5eda69ffe540ce61a61536f6251b63c3948cd9d
    Gerrit-Change-Number: 7408671
    Gerrit-PatchSet: 1
    Gerrit-Owner: Jonathan Ross <jon...@chromium.org>
    Gerrit-Reviewer: Kramer Ge <fang...@chromium.org>
    Gerrit-Reviewer: Zhenyao Mo <z...@chromium.org>
    Gerrit-Attention: Jonathan Ross <jon...@chromium.org>
    Gerrit-Comment-Date: Wed, 07 Jan 2026 21:33:57 +0000
    Gerrit-HasComments: No
    Gerrit-Has-Labels: Yes
    satisfied_requirement
    open
    diffy

    Jonathan Ross (Gerrit)

    unread,
    Jan 8, 2026, 11:11:36 AM (3 days ago) Jan 8
    to Zhenyao Mo, chromium...@chromium.org, ozone-...@chromium.org

    Jonathan Ross voted Commit-Queue+2

    Commit-Queue+2
    Open in Gerrit

    Related details

    Attention set is empty
    Submit Requirements:
    • requirement satisfiedCode-Coverage
    • requirement satisfiedCode-Owners
    • requirement satisfiedCode-Review
    • requirement satisfiedReview-Enforcement
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: comment
    Gerrit-Project: chromium/src
    Gerrit-Branch: main
    Gerrit-Change-Id: Ie5eda69ffe540ce61a61536f6251b63c3948cd9d
    Gerrit-Change-Number: 7408671
    Gerrit-PatchSet: 2
    Gerrit-Owner: Jonathan Ross <jon...@chromium.org>
    Gerrit-Reviewer: Jonathan Ross <jon...@chromium.org>
    Gerrit-Reviewer: Kramer Ge <fang...@chromium.org>
    Gerrit-Reviewer: Zhenyao Mo <z...@chromium.org>
    Gerrit-Comment-Date: Thu, 08 Jan 2026 16:11:28 +0000
    Gerrit-HasComments: No
    Gerrit-Has-Labels: Yes
    satisfied_requirement
    open
    diffy

    Jonathan Ross (Gerrit)

    unread,
    Jan 8, 2026, 12:58:40 PM (3 days ago) Jan 8
    to Chromium LUCI CQ, Zhenyao Mo, chromium...@chromium.org, ozone-...@chromium.org

    Jonathan Ross voted Commit-Queue+2

    Commit-Queue+2
    Open in Gerrit

    Related details

    Attention set is empty
    Submit Requirements:
    • requirement satisfiedCode-Coverage
    • requirement satisfiedCode-Owners
    • requirement satisfiedCode-Review
    • requirement satisfiedReview-Enforcement
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: comment
    Gerrit-Project: chromium/src
    Gerrit-Branch: main
    Gerrit-Change-Id: Ie5eda69ffe540ce61a61536f6251b63c3948cd9d
    Gerrit-Change-Number: 7408671
    Gerrit-PatchSet: 2
    Gerrit-Owner: Jonathan Ross <jon...@chromium.org>
    Gerrit-Reviewer: Jonathan Ross <jon...@chromium.org>
    Gerrit-Reviewer: Kramer Ge <fang...@chromium.org>
    Gerrit-Reviewer: Zhenyao Mo <z...@chromium.org>
    Gerrit-Comment-Date: Thu, 08 Jan 2026 17:58:33 +0000
    Gerrit-HasComments: No
    Gerrit-Has-Labels: Yes
    satisfied_requirement
    open
    diffy

    Chromium LUCI CQ (Gerrit)

    unread,
    Jan 8, 2026, 1:28:50 PM (3 days ago) Jan 8
    to Jonathan Ross, Zhenyao Mo, Kramer Ge, chromium...@chromium.org, ozone-...@chromium.org

    Chromium LUCI CQ submitted the change

    Unreviewed changes

    1 is the latest approved patch-set.
    No files were changed between the latest approved patch-set and the submitted one.

    Change information

    Commit message:
    Remove GbmSurfaceless::SetNotifyNonSimpleOverlayFailure

    We removed kHandleOverlaysSwapFailure which was the only entry point to
    SetNotifyNonSimpleOverlayFailure. Here we remove it.
    Bug: 379691125
    Change-Id: Ie5eda69ffe540ce61a61536f6251b63c3948cd9d
    Reviewed-by: Kramer Ge <fang...@chromium.org>
    Reviewed-by: Zhenyao Mo <z...@chromium.org>
    Commit-Queue: Jonathan Ross <jon...@chromium.org>
    Cr-Commit-Position: refs/heads/main@{#1566407}
    Files:
    • M ui/gl/presenter.h
    • M ui/ozone/platform/drm/gpu/gbm_surfaceless.cc
    • M ui/ozone/platform/drm/gpu/gbm_surfaceless.h
    Change size: M
    Delta: 3 files changed, 8 insertions(+), 45 deletions(-)
    Branch: refs/heads/main
    Submit Requirements:
    • requirement satisfiedCode-Review: +1 by Kramer Ge, +1 by Zhenyao Mo
    Open in Gerrit
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: merged
    Gerrit-Project: chromium/src
    Gerrit-Branch: main
    Gerrit-Change-Id: Ie5eda69ffe540ce61a61536f6251b63c3948cd9d
    Gerrit-Change-Number: 7408671
    Gerrit-PatchSet: 3
    Gerrit-Owner: Jonathan Ross <jon...@chromium.org>
    Gerrit-Reviewer: Chromium LUCI CQ <chromiu...@luci-project-accounts.iam.gserviceaccount.com>
    Gerrit-Reviewer: Jonathan Ross <jon...@chromium.org>
    Gerrit-Reviewer: Kramer Ge <fang...@chromium.org>
    Gerrit-Reviewer: Zhenyao Mo <z...@chromium.org>
    open
    diffy
    satisfied_requirement
    Reply all
    Reply to author
    Forward
    0 new messages