[Ozone/Wayland]Remove DCHECK superceded by preferred_scale [chromium/src : main]
0 views
Skip to first unread message
Kramer Ge (Gerrit)
Sep 29, 2025, 3:46:41 PM (8 days ago) Sep 29
to Thomas Anderson, AyeAye, chromium...@chromium.org, max+watc...@igalia.com, nickdiego+wa...@igalia.com, ozone-...@chromium.org
Attention needed from Thomas Anderson
Kramer Ge voted Commit-Queue+1![]( "Open in Gerrit")
| Commit-Queue | +1 |
Related details
Attention is currently required from:
- Thomas Anderson
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Thomas Anderson (Gerrit)
Sep 29, 2025, 4:41:00 PM (8 days ago) Sep 29
to Kramer Ge, Chromium LUCI CQ, AyeAye, chromium...@chromium.org, max+watc...@igalia.com, nickdiego+wa...@igalia.com, ozone-...@chromium.org
Attention needed from Kramer Ge
Thomas Anderson voted Code-Review+1![]( "Open in Gerrit")
Attention is currently required from:
- Kramer Ge
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Kramer Ge (Gerrit)
Sep 29, 2025, 4:46:40 PM (8 days ago) Sep 29
to Thomas Anderson, Chromium LUCI CQ, AyeAye, chromium...@chromium.org, max+watc...@igalia.com, nickdiego+wa...@igalia.com, ozone-...@chromium.org
Kramer Ge voted Commit-Queue+2![]( "Open in Gerrit")
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Chromium LUCI CQ (Gerrit)
Sep 29, 2025, 4:55:21 PM (8 days ago) Sep 29
to Kramer Ge, Thomas Anderson, AyeAye, chromium...@chromium.org, max+watc...@igalia.com, nickdiego+wa...@igalia.com, ozone-...@chromium.org
Chromium LUCI CQ submitted the change![]( "Open in Gerrit")
Change information
Commit message:
[Ozone/Wayland]Remove DCHECK superceded by preferred_scale
This DCHECK assumes the widget tree should have the same window_scale
because they're on the same display and hence should deduce the same
scale.
This assumption is not true when preferred_scale protocol is used, where
compositor sends each widget scale factor asynchronously.
Bug: 446602690
Change-Id: I35432320b87f337651dc466afb69d5984b5f69bb
Commit-Queue: Kramer Ge <fang...@chromium.org>
Reviewed-by: Thomas Anderson <thomasa...@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1522463}
Files:
- M ui/ozone/platform/wayland/common/wayland_util.cc
Change size: XS
Delta: 1 file changed, 0 insertions(+), 2 deletions(-)
Branch: refs/heads/main
Submit Requirements:
Code-Review: +1 by Thomas Anderson
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Reply all
Reply to author
Forward
0 new messages