Revert "Support statically linking ANGLE on all platforms" [chromium/src : main]

0 views
Skip to first unread message

Colin Blundell (Gerrit)

unread,
May 21, 2025, 2:49:27 AM5/21/25
to Colin Blundell, Rubber Stamper, Alex Gough, Geoff Lang, Chromium LUCI CQ, Gil Dekel, Thomas Anderson, David Dorwin, Fumitoshi Ukai, Corentin Wallez, Robert Kroeger, chromium...@chromium.org, Raphael Kubo Da Costa, David Worsham, AyeAye, Michael Moss, Raphael Kubo da Costa, fuchsia...@chromium.org, mac-r...@chromium.org, emi...@google.com, spang...@chromium.org, ozone-...@chromium.org
Attention needed from Alex Gough, David Dorwin, Geoff Lang, Gil Dekel and Thomas Anderson

Colin Blundell voted Auto-Submit+1

Auto-Submit+1
Open in Gerrit

Related details

Attention is currently required from:
  • Alex Gough
  • David Dorwin
  • Geoff Lang
  • Gil Dekel
  • Thomas Anderson
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement is not satisfiedCode-Review
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: I92707161c3c8c7c0a2a53c6305f0339e9c135791
Gerrit-Change-Number: 6573472
Gerrit-PatchSet: 1
Gerrit-Owner: Colin Blundell <blun...@chromium.org>
Gerrit-Reviewer: Alex Gough <aj...@chromium.org>
Gerrit-Reviewer: Chromium LUCI CQ <chromiu...@luci-project-accounts.iam.gserviceaccount.com>
Gerrit-Reviewer: Colin Blundell <blun...@chromium.org>
Gerrit-Reviewer: David Dorwin <ddo...@chromium.org>
Gerrit-Reviewer: Geoff Lang <geof...@chromium.org>
Gerrit-Reviewer: Gil Dekel <gild...@chromium.org>
Gerrit-Reviewer: Rubber Stamper <rubber-...@appspot.gserviceaccount.com>
Gerrit-Reviewer: Thomas Anderson <thomasa...@chromium.org>
Gerrit-CC: Corentin Wallez <cwa...@chromium.org>
Gerrit-CC: David Worsham <dwor...@google.com>
Gerrit-CC: Fumitoshi Ukai <uk...@google.com>
Gerrit-CC: Michael Moss <mm...@chromium.org>
Gerrit-CC: Raphael Kubo Da Costa <raphael.ku...@intel.com>
Gerrit-CC: Raphael Kubo da Costa <ku...@igalia.com>
Gerrit-CC: Robert Kroeger <rjkr...@chromium.org>
Gerrit-Attention: Alex Gough <aj...@chromium.org>
Gerrit-Attention: Geoff Lang <geof...@chromium.org>
Gerrit-Attention: Gil Dekel <gild...@chromium.org>
Gerrit-Attention: Thomas Anderson <thomasa...@chromium.org>
Gerrit-Attention: David Dorwin <ddo...@chromium.org>
Gerrit-Comment-Date: Wed, 21 May 2025 06:49:16 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
satisfied_requirement
unsatisfied_requirement
open
diffy

Rubber Stamper (Gerrit)

unread,
May 21, 2025, 2:50:20 AM5/21/25
to Colin Blundell, Alex Gough, Geoff Lang, Chromium LUCI CQ, Gil Dekel, Thomas Anderson, David Dorwin, Fumitoshi Ukai, Corentin Wallez, Robert Kroeger, chromium...@chromium.org, Raphael Kubo Da Costa, David Worsham, AyeAye, Michael Moss, Raphael Kubo da Costa, fuchsia...@chromium.org, mac-r...@chromium.org, emi...@google.com, spang...@chromium.org, ozone-...@chromium.org
Attention needed from Alex Gough, David Dorwin, Geoff Lang, Gil Dekel and Thomas Anderson

Rubber Stamper voted

Bot-Commit+1
Commit-Queue+2
Open in Gerrit

Related details

Attention is currently required from:
  • Alex Gough
  • David Dorwin
  • Geoff Lang
  • Gil Dekel
  • Thomas Anderson
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement satisfiedCode-Review
Gerrit-Comment-Date: Wed, 21 May 2025 06:50:09 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
satisfied_requirement
open
diffy

Chromium LUCI CQ (Gerrit)

unread,
May 21, 2025, 2:50:40 AM5/21/25
to Colin Blundell, Rubber Stamper, Alex Gough, Geoff Lang, Gil Dekel, Thomas Anderson, David Dorwin, Fumitoshi Ukai, Corentin Wallez, Robert Kroeger, chromium...@chromium.org, Raphael Kubo Da Costa, David Worsham, AyeAye, Michael Moss, Raphael Kubo da Costa, fuchsia...@chromium.org, mac-r...@chromium.org, emi...@google.com, spang...@chromium.org, ozone-...@chromium.org

Chromium LUCI CQ submitted the change

Change information

Commit message:
Revert "Support statically linking ANGLE on all platforms"

This reverts commit e076a4349e11e4dfc27d7267df4c266257627519.

Reason for revert: Causing build errors on bots, e.g.

https://ci.chromium.org/ui/p/chromium/builders/ci/linux-chromeos-archive-rel/32556/overview
https://ci.chromium.org/ui/p/chromium/builders/build/linux-build-perf-ninja/6422/overview

Original change's description:
> Support statically linking ANGLE on all platforms
>
> Use the static version everywhere except Mac. There are a few global initializers in the Vulkan loader which still need to be removed.
>
> Bug: 40268378
>
> Change-Id: I3c12f9d32e97221068d64f6e3589eb1e54dd8a74
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4404439
> Reviewed-by: Alex Gough <aj...@chromium.org>
> Reviewed-by: Colin Blundell <blun...@chromium.org>
> Commit-Queue: Geoff Lang <geof...@chromium.org>
> Reviewed-by: Thomas Anderson <thomasa...@chromium.org>
> Cr-Commit-Position: refs/heads/main@{#1462754}
Bug: 40268378
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Change-Id: I92707161c3c8c7c0a2a53c6305f0339e9c135791
Bot-Commit: Rubber Stamper <rubber-...@appspot.gserviceaccount.com>
Auto-Submit: Colin Blundell <blun...@chromium.org>
Commit-Queue: Rubber Stamper <rubber-...@appspot.gserviceaccount.com>
Cr-Commit-Position: refs/heads/main@{#1463241}
Files:
  • M chrome/BUILD.gn
  • M chrome/installer/linux/BUILD.gn
  • M chrome/test/delayload/delayloads_unittest.cc
  • M ui/gl/BUILD.gn
  • M ui/gl/features.gni
  • M ui/gl/gl_surface_egl_unittest.cc
  • M ui/gl/init/BUILD.gn
  • M ui/gl/init/gl_initializer_angle.cc
  • M ui/gl/init/gl_initializer_mac.cc
  • M ui/gl/init/gl_initializer_win.cc
  • M ui/ozone/common/BUILD.gn
  • M ui/ozone/common/egl_util.cc
  • M ui/ozone/platform/drm/BUILD.gn
  • M ui/ozone/platform/flatland/BUILD.gn
Change size: L
Delta: 14 files changed, 112 insertions(+), 178 deletions(-)
Branch: refs/heads/main
Submit Requirements:
  • requirement satisfiedCode-Review: Bot-Commit+1 by Rubber Stamper
Open in Gerrit
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: merged
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: I92707161c3c8c7c0a2a53c6305f0339e9c135791
Gerrit-Change-Number: 6573472
Gerrit-PatchSet: 2
open
diffy
satisfied_requirement
Reply all
Reply to author
Forward
0 new messages