Saifuddin Hitawala (Gerrit)

unread,

Jan 9, 2026, 11:27:51 AM (2 days ago) Jan 9

to Vasiliy Telezhnikov, Chromium LUCI CQ, chromium...@chromium.org, David Worsham, Robert Kroeger, emi...@google.com, fuchsia...@chromium.org, max+watc...@igalia.com, nickdiego+wa...@igalia.com, ozone-...@chromium.org, spang...@chromium.org

Attention needed from Vasiliy Telezhnikov

Saifuddin Hitawala added 1 comment

Patchset-level comments

File-level comment, Patchset 4 (Latest):

Saifuddin Hitawala . resolved

Please take a look.

Open in Gerrit

Related details

Attention is currently required from:

Vasiliy Telezhnikov

Submit Requirements:

Code-Coverage
Code-Owners
Code-Review
Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

satisfied_requirement

unsatisfied_requirement

open

diffy

Vasiliy Telezhnikov (Gerrit)

unread,

Jan 9, 2026, 11:42:35 AM (2 days ago) Jan 9

to Saifuddin Hitawala, Chromium LUCI CQ, chromium...@chromium.org, David Worsham, Robert Kroeger, emi...@google.com, fuchsia...@chromium.org, max+watc...@igalia.com, nickdiego+wa...@igalia.com, ozone-...@chromium.org, spang...@chromium.org

Attention needed from Saifuddin Hitawala

Vasiliy Telezhnikov voted and added 1 comment

Votes added by Vasiliy Telezhnikov

Code-Review

+1

1 comment

Patchset-level comments

File-level comment, Patchset 4 (Latest):

Vasiliy Telezhnikov . resolved

lgtm, thanks!

Open in Gerrit

Related details

Attention is currently required from:

Saifuddin Hitawala

Submit Requirements:

Code-Coverage
Code-Owners

Code-Review
Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

satisfied_requirement

unsatisfied_requirement

open

diffy

Saifuddin Hitawala (Gerrit)

unread,

Jan 9, 2026, 11:46:34 AM (2 days ago) Jan 9

to Colin Blundell, Vasiliy Telezhnikov, Chromium LUCI CQ, chromium...@chromium.org, David Worsham, Robert Kroeger, emi...@google.com, fuchsia...@chromium.org, max+watc...@igalia.com, nickdiego+wa...@igalia.com, ozone-...@chromium.org, spang...@chromium.org

Attention needed from Colin Blundell

Saifuddin Hitawala added 1 comment

Patchset-level comments

File-level comment, Patchset 4 (Latest):

Saifuddin Hitawala . resolved

Thanks, adding Colin, PTAL.

Open in Gerrit

Related details

Attention is currently required from:

Colin Blundell

Submit Requirements:

Code-Coverage
Code-Owners
Code-Review
Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

satisfied_requirement

unsatisfied_requirement

open

diffy

Colin Blundell (Gerrit)

unread,

Jan 9, 2026, 12:19:39 PM (2 days ago) Jan 9

to Saifuddin Hitawala, Colin Blundell, Vasiliy Telezhnikov, Chromium LUCI CQ, chromium...@chromium.org, David Worsham, Robert Kroeger, emi...@google.com, fuchsia...@chromium.org, max+watc...@igalia.com, nickdiego+wa...@igalia.com, ozone-...@chromium.org, spang...@chromium.org

Attention needed from Saifuddin Hitawala

Colin Blundell voted and added 2 comments

Votes added by Colin Blundell

Code-Review

+1

2 comments

Patchset-level comments

File-level comment, Patchset 4 (Latest):

Colin Blundell . resolved

Thanks!

File ui/ozone/public/surface_factory_ozone.h

Line 204, Patchset 4 (Latest): // CreateNativePixmap() the provided `format`, or returns empty if it could

Colin Blundell . unresolved

nit: eliminate `, or returns empty ... .`

Open in Gerrit

Related details

Attention is currently required from:

Saifuddin Hitawala

Submit Requirements:

Code-Coverage
Code-Owners
Code-Review
No-Unresolved-Comments
Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

satisfied_requirement

unsatisfied_requirement

open

diffy

Saifuddin Hitawala (Gerrit)

unread,

Jan 9, 2026, 2:49:15 PM (2 days ago) Jan 9

to Colin Blundell, Vasiliy Telezhnikov, Chromium LUCI CQ, chromium...@chromium.org, David Worsham, Robert Kroeger, emi...@google.com, fuchsia...@chromium.org, max+watc...@igalia.com, nickdiego+wa...@igalia.com, ozone-...@chromium.org, spang...@chromium.org

Saifuddin Hitawala voted and added 2 comments

Votes added by Saifuddin Hitawala

Commit-Queue

+2

2 comments

Patchset-level comments

File-level comment, Patchset 5 (Latest):

Saifuddin Hitawala . resolved

Thanks for reviewing!

File ui/ozone/public/surface_factory_ozone.h

Line 204, Patchset 4: // CreateNativePixmap() the provided `format`, or returns empty if it could

Colin Blundell . resolved

nit: eliminate `, or returns empty ... .`

Saifuddin Hitawala

Sounds good, updated the comment.

Open in Gerrit

Related details

Attention set is empty

Submit Requirements:

Code-Coverage
Code-Owners
Code-Review

Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

satisfied_requirement

open

diffy

Chromium LUCI CQ (Gerrit)

unread,

Jan 9, 2026, 4:04:32 PM (2 days ago) Jan 9

to Saifuddin Hitawala, Colin Blundell, Vasiliy Telezhnikov, chromium...@chromium.org, David Worsham, Robert Kroeger, emi...@google.com, fuchsia...@chromium.org, max+watc...@igalia.com, nickdiego+wa...@igalia.com, ozone-...@chromium.org, spang...@chromium.org

Chromium LUCI CQ submitted the change with unreviewed changes

Unreviewed changes

4 is the latest approved patch-set.
The change was submitted with unreviewed changes in the following files:

```
The name of the file: ui/ozone/public/surface_factory_ozone.h
Insertions: 2, Deletions: 3.

@@ -201,9 +201,8 @@
       std::unique_ptr<DrmModifiersFilter> filter);
 
   // Checks if the platform can allocate (and use for texturing) via
-  // CreateNativePixmap() the provided `format`, or returns empty if it could
-  // not be retrieved or the platform doesn't know in advance. Checks should not
-  // be assumed to take a trivial amount of time.
+  // CreateNativePixmap() the provided `format`. Checks should not be assumed to
+  // take a trivial amount of time.
   virtual bool IsFormatSupportedForTexturing(
       viz::SharedImageFormat format) const;
 
```

Change information

Commit message:

[ozone] Refactor GetSupportedFormatsForTexturing

Refactor GetSupportedFormatsForTexturing to check for specific format
instead of returning list of all supported formats. This is because
it is used only for NV12/P010 formats and thus we can avoid checking
for all BufferFormats. It also helps us get closer to removing
BufferFormat usages.

Bug: 454067872

Change-Id: I4f96cf4e4df73c7733eb669cec016abd5a19a1a1

Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/7411933

Reviewed-by: Vasiliy Telezhnikov <vas...@chromium.org>

Reviewed-by: Colin Blundell <blun...@chromium.org>

Commit-Queue: Saifuddin Hitawala <hita...@chromium.org>

Cr-Commit-Position: refs/heads/main@{#1567164}

Files:

M gpu/ipc/service/gpu_init.cc
M ui/ozone/platform/drm/gpu/gbm_surface_factory.cc
M ui/ozone/platform/drm/gpu/gbm_surface_factory.h
M ui/ozone/platform/flatland/flatland_surface_factory.cc
M ui/ozone/platform/flatland/flatland_surface_factory.h
M ui/ozone/platform/wayland/gpu/wayland_surface_factory.cc
M ui/ozone/platform/wayland/gpu/wayland_surface_factory.h
M ui/ozone/platform/x11/x11_surface_factory.cc
M ui/ozone/platform/x11/x11_surface_factory.h
M ui/ozone/public/surface_factory_ozone.cc
M ui/ozone/public/surface_factory_ozone.h

Change size: M

Delta: 11 files changed, 88 insertions(+), 119 deletions(-)

Branch: refs/heads/main

Submit Requirements:

Code-Review: +1 by Vasiliy Telezhnikov, +1 by Colin Blundell

Open in Gerrit

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

open

diffy

satisfied_requirement

Ian Wells (Gerrit)

unread,

Jan 9, 2026, 5:59:20 PM (2 days ago) Jan 9

to Saifuddin Hitawala, Chromium LUCI CQ, Colin Blundell, Vasiliy Telezhnikov, chromium...@chromium.org, David Worsham, Robert Kroeger, emi...@google.com, fuchsia...@chromium.org, max+watc...@igalia.com, nickdiego+wa...@igalia.com, ozone-...@chromium.org, spang...@chromium.org

Ian Wells has created a revert of this change

Open original change

Related details

Attention set is empty

Submit Requirements:

Code-Coverage
Code-Owners
Code-Review
Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

satisfied_requirement

open

diffy

Reply all

Reply to author

Forward

[ozone] Refactor GetSupportedFormatsForTexturing [chromium/src : main]

Saifuddin Hitawala (Gerrit)

Saifuddin Hitawala added 1 comment

Related details

Vasiliy Telezhnikov (Gerrit)

Vasiliy Telezhnikov voted and added 1 comment

Votes added by Vasiliy Telezhnikov

1 comment

Related details

Saifuddin Hitawala (Gerrit)

Saifuddin Hitawala added 1 comment

Related details

Colin Blundell (Gerrit)

Colin Blundell voted and added 2 comments

Votes added by Colin Blundell

2 comments

Related details

Saifuddin Hitawala (Gerrit)

Saifuddin Hitawala voted and added 2 comments

Votes added by Saifuddin Hitawala

2 comments

Related details

Chromium LUCI CQ (Gerrit)

Chromium LUCI CQ submitted the change with unreviewed changes

Unreviewed changes

Change information

Ian Wells (Gerrit)

Ian Wells has created a revert of this change

Related details