Reland "[SxS] Enable drag and drop for Split View" [chromium/src : main]
0 views
Skip to first unread message
Rubber Stamper (Gerrit)
Oct 1, 2025, 12:06:22 PM (6 days ago) Oct 1
to Alison Gale, Chromium LUCI CQ, Caroline Rising, Lingqi Chi, Kramer Ge, AyeAye, chromium...@chromium.org, max+watc...@igalia.com, nickdiego+wa...@igalia.com, ozone-...@chromium.org
Attention needed from Caroline Rising, Kramer Ge and Lingqi Chi
Rubber Stamper voted Bot-Commit+1![]( "Open in Gerrit")
| Bot-Commit | +1 |
Related details
Attention is currently required from:
- Caroline Rising
- Kramer Ge
- Lingqi Chi
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Caroline Rising (Gerrit)
Oct 2, 2025, 12:04:33 PM (5 days ago) Oct 2
to Alison Gale, Kramer Ge, Chromium LUCI CQ, AyeAye, chromium...@chromium.org, max+watc...@igalia.com, nickdiego+wa...@igalia.com, ozone-...@chromium.org
Attention needed from Alison Gale and Kramer Ge
Caroline Rising voted Code-Review+1![]( "Open in Gerrit")
Attention is currently required from:
- Alison Gale
- Kramer Ge
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Kramer Ge (Gerrit)
Oct 2, 2025, 2:06:38 PM (5 days ago) Oct 2
to Alison Gale, Caroline Rising, Chromium LUCI CQ, AyeAye, chromium...@chromium.org, max+watc...@igalia.com, nickdiego+wa...@igalia.com, ozone-...@chromium.org
Attention needed from Alison Gale
Kramer Ge voted Code-Review+1![]( "Open in Gerrit")
| Code-Review | +1 |
Related details
Attention is currently required from:
- Alison Gale
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Alison Gale (Gerrit)
Oct 2, 2025, 2:07:48 PM (5 days ago) Oct 2
to Caroline Rising, Chromium LUCI CQ, AyeAye, chromium...@chromium.org, max+watc...@igalia.com, nickdiego+wa...@igalia.com, ozone-...@chromium.org
Alison Gale voted Commit-Queue+2![]( "Open in Gerrit")
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Chromium LUCI CQ (Gerrit)
Oct 2, 2025, 3:29:25 PM (5 days ago) Oct 2
to Alison Gale, Kramer Ge, Caroline Rising, AyeAye, chromium...@chromium.org, max+watc...@igalia.com, nickdiego+wa...@igalia.com, ozone-...@chromium.org
Chromium LUCI CQ submitted the change![]( "Open in Gerrit")
Change information
Commit message:
Reland "[SxS] Enable drag and drop for Split View"
This reverts commit dab0b59def1b8c8151bd232069aa014385f583b4.
Reason for revert: Reland with disabling two tests
Weston uses system drag drop rather than Chrome's custom tab dragging
implementation which means that the drop targets for Split View don't
open. I'll land this now which will enable link dragging on all Linux
and tab dragging on Mutter and filed a bug to follow up with tab
dragging on Weston.
linux-mutter-rel succeeded: https://ci.chromium.org/ui/p/chromium/builders/try/linux-wayland-mutter-rel/14916/overview
Original change's description:
> Revert "[SxS] Enable drag and drop for Split View"
>
> This reverts commit 6ee23ee3eb2a3c9f6facf80071f5cd12e8d5f74b.
>
> Reason for revert: failing on wayland-weston
>
> https://ci.chromium.org/ui/p/chromium/builders/ci/linux-wayland-weston-rel-tests/4519/overview
>
> Original change's description:
> > [SxS] Enable drag and drop for Split View
> >
> > Now that Wayland supports this type of link drag
> >
> > Bug: 425715421
> > Change-Id: I6e61e5c430aeb6aa29fd07ccaf75dbbaedae2360
> > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6977226
> > Reviewed-by: Kramer Ge <fang...@chromium.org>
> > Commit-Queue: Alison Gale <ag...@chromium.org>
> > Reviewed-by: Caroline Rising <cori...@chromium.org>
> > Cr-Commit-Position: refs/heads/main@{#1522945}
>
> Bug: 425715421
> No-Presubmit: true
> No-Tree-Checks: true
> No-Try: true
> Change-Id: I4614d53e5ad7dd3790d800f4f664a28e8dd8ccdb
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6999592
> Bot-Commit: Rubber Stamper <rubber-...@appspot.gserviceaccount.com>
> Owners-Override: Lingqi Chi <lin...@chromium.org>
> Commit-Queue: Rubber Stamper <rubber-...@appspot.gserviceaccount.com>
> Auto-Submit: Lingqi Chi <lin...@chromium.org>
> Cr-Commit-Position: refs/heads/main@{#1523265}
Bug: 425715421
Change-Id: Ic9ee35f9998c1feceb7601c00f3b2f0acabc9db1
Reviewed-by: Caroline Rising <cori...@chromium.org>
Commit-Queue: Alison Gale <ag...@chromium.org>
Reviewed-by: Kramer Ge <fang...@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1524383}
Files:
- M chrome/browser/ui/views/frame/multi_contents_view.cc
- M chrome/browser/ui/views/frame/multi_contents_view_browsertest.cc
- M chrome/browser/ui/views/frame/multi_contents_view_drop_target_controller_browsertest.cc
- M chrome/browser/ui/views/frame/multi_contents_view_tab_drag_interactive_uitest.cc
- M ui/ozone/platform/wayland/ozone_platform_wayland.cc
- M ui/ozone/public/ozone_platform.h
Change size: M
Delta: 6 files changed, 21 insertions(+), 144 deletions(-)
Branch: refs/heads/main
Submit Requirements:
Code-Review: +1 by Kramer Ge, +1 by Caroline Rising
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Reply all
Reply to author
Forward
0 new messages