Saifuddin Hitawala (Gerrit)

unread,

Jan 27, 2026, 11:08:39 AM (6 days ago) Jan 27

to Colin Blundell, Kyle Charbonneau, Dave Tapuska, Chromium IPC Reviews, Chromium LUCI CQ, chromium...@chromium.org, blink-...@chromium.org, cc-...@chromium.org, ipc-securi...@chromium.org, max+watc...@igalia.com, nickdiego+wa...@igalia.com, ozone-...@chromium.org

Attention needed from Chromium IPC Reviews, Colin Blundell, Dave Tapuska and Kyle Charbonneau

Saifuddin Hitawala added 1 comment

Patchset-level comments

File-level comment, Patchset 2 (Latest):

Saifuddin Hitawala . resolved

Please take a look.

Open in Gerrit

Related details

Attention is currently required from:

Chromium IPC Reviews
Colin Blundell
Dave Tapuska
Kyle Charbonneau

Submit Requirements:

Code-Coverage
Code-Owners
Code-Review
Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

satisfied_requirement

unsatisfied_requirement

open

diffy

Dave Tapuska (Gerrit)

unread,

Jan 27, 2026, 11:10:17 AM (6 days ago) Jan 27

to Saifuddin Hitawala, Colin Blundell, Kyle Charbonneau, Chromium IPC Reviews, Chromium LUCI CQ, chromium...@chromium.org, blink-...@chromium.org, cc-...@chromium.org, ipc-securi...@chromium.org, max+watc...@igalia.com, nickdiego+wa...@igalia.com, ozone-...@chromium.org

Attention needed from Chromium IPC Reviews, Colin Blundell, Kyle Charbonneau and Saifuddin Hitawala

Dave Tapuska voted Code-Review+1

Code-Review

+1

Open in Gerrit

Related details

Attention is currently required from:

Chromium IPC Reviews
Colin Blundell

Kyle Charbonneau
Saifuddin Hitawala

Submit Requirements:

Code-Coverage
Code-Owners

Code-Review
Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

satisfied_requirement

unsatisfied_requirement

open

diffy

gwsq (Gerrit)

unread,

Jan 27, 2026, 11:13:50 AM (6 days ago) Jan 27

to Saifuddin Hitawala, Chromium IPC Reviews, Dave Tapuska, Colin Blundell, Kyle Charbonneau, Chromium LUCI CQ, chromium...@chromium.org, blink-...@chromium.org, cc-...@chromium.org, ipc-securi...@chromium.org, max+watc...@igalia.com, nickdiego+wa...@igalia.com, ozone-...@chromium.org

Attention needed from Colin Blundell, Joe Mason, Kyle Charbonneau and Saifuddin Hitawala

Message from gwsq

From googleclient/chrome/chromium_gwsq/ipc/config.gwsq:
IPC: joenot...@google.com

📎 It looks like you’re making a possibly security-sensitive change! 📎 IPC security review isn’t a rubberstamp, so your friendly security reviewer will need a fair amount of context to review your CL effectively. Please review your CL description and code comments to make sure they provide context for someone unfamiliar with your project/area. Pay special attention to where data comes from and which processes it flows between (and their privilege levels). Feel free to point your security reviewer at design docs, bugs, or other links if you can’t reasonably make a self-contained CL description. (Also see https://cbea.ms/git-commit/).

IPC reviewer(s): joenot...@google.com

Reviewer source(s):
joenot...@google.com is from context(googleclient/chrome/chromium_gwsq/ipc/config.gwsq)

Open in Gerrit

Related details

Attention is currently required from:

Colin Blundell
Joe Mason
Kyle Charbonneau
Saifuddin Hitawala

Submit Requirements:

Code-Coverage
Code-Owners
Code-Review
Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

satisfied_requirement

unsatisfied_requirement

open

diffy

Kyle Charbonneau (Gerrit)

unread,

Jan 27, 2026, 11:36:13 AM (6 days ago) Jan 27

to Saifuddin Hitawala, Chromium IPC Reviews, Dave Tapuska, Colin Blundell, Chromium LUCI CQ, chromium...@chromium.org, blink-...@chromium.org, cc-...@chromium.org, ipc-securi...@chromium.org, max+watc...@igalia.com, nickdiego+wa...@igalia.com, ozone-...@chromium.org

Attention needed from Colin Blundell, Joe Mason and Saifuddin Hitawala

Kyle Charbonneau voted and added 1 comment

Votes added by Kyle Charbonneau

Code-Review

+1

1 comment

Patchset-level comments

File-level comment, Patchset 2 (Latest):

Kyle Charbonneau . resolved

lgtm!

Open in Gerrit

Related details

Attention is currently required from:

Colin Blundell
Joe Mason
Saifuddin Hitawala

satisfied_requirement

unsatisfied_requirement

open

diffy

Colin Blundell (Gerrit)

unread,

Jan 27, 2026, 11:45:15 AM (6 days ago) Jan 27

to Saifuddin Hitawala, Colin Blundell, Kyle Charbonneau, Chromium IPC Reviews, Dave Tapuska, Chromium LUCI CQ, chromium...@chromium.org, blink-...@chromium.org, cc-...@chromium.org, ipc-securi...@chromium.org, max+watc...@igalia.com, nickdiego+wa...@igalia.com, ozone-...@chromium.org

Attention needed from Joe Mason and Saifuddin Hitawala

Colin Blundell voted and added 1 comment

Votes added by Colin Blundell

Code-Review

+1

1 comment

Patchset-level comments

File-level comment, Patchset 2 (Latest):

Colin Blundell . resolved

LGTM, thanks! \o/

Going to look at rationalizing [this](https://source.chromium.org/chromium/chromium/src/+/main:components/viz/common/resources/shared_image_format_utils.h;l=97?q=HasEquiv&sq=&ss=chromium) in followup?

Open in Gerrit

Related details

Attention is currently required from:

Joe Mason
Saifuddin Hitawala

satisfied_requirement

unsatisfied_requirement

open

diffy

Joe Mason (Gerrit)

unread,

Jan 27, 2026, 2:11:13 PM (5 days ago) Jan 27

to Saifuddin Hitawala, Colin Blundell, Kyle Charbonneau, Chromium IPC Reviews, Dave Tapuska, Chromium LUCI CQ, chromium...@chromium.org, blink-...@chromium.org, cc-...@chromium.org, ipc-securi...@chromium.org, max+watc...@igalia.com, nickdiego+wa...@igalia.com, ozone-...@chromium.org

Attention needed from Saifuddin Hitawala

Joe Mason voted and added 1 comment

Votes added by Joe Mason

Code-Review

+1

1 comment

Patchset-level comments

File-level comment, Patchset 2 (Latest):

Joe Mason . resolved

Thanks for the cleanup!

Open in Gerrit

Related details

Attention is currently required from:

Saifuddin Hitawala

Submit Requirements:

Code-Coverage
Code-Owners

Code-Review
Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

satisfied_requirement

open

diffy

Saifuddin Hitawala (Gerrit)

unread,

Jan 27, 2026, 2:14:39 PM (5 days ago) Jan 27

to Colin Blundell, Kyle Charbonneau, Chromium IPC Reviews, Dave Tapuska, Chromium LUCI CQ, chromium...@chromium.org, blink-...@chromium.org, cc-...@chromium.org, ipc-securi...@chromium.org, max+watc...@igalia.com, nickdiego+wa...@igalia.com, ozone-...@chromium.org

Saifuddin Hitawala voted and added 2 comments

Votes added by Saifuddin Hitawala

Commit-Queue

+2

2 comments

Patchset-level comments

File-level comment, Patchset 2 (Latest):

Saifuddin Hitawala . resolved

Thanks for all reviews!

File-level comment, Patchset 2 (Latest):

Colin Blundell . resolved

LGTM, thanks! \o/
Going to look at rationalizing [this](https://source.chromium.org/chromium/chromium/src/+/main:components/viz/common/resources/shared_image_format_utils.h;l=97?q=HasEquiv&sq=&ss=chromium) in followup?

Saifuddin Hitawala

Yes, I will look at that method in follow-up.

Open in Gerrit

Related details

Attention set is empty

Submit Requirements:

Code-Coverage
Code-Owners
Code-Review
Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

satisfied_requirement

open

diffy

Chromium LUCI CQ (Gerrit)

unread,

Jan 27, 2026, 2:17:47 PM (5 days ago) Jan 27

to Saifuddin Hitawala, Colin Blundell, Kyle Charbonneau, Chromium IPC Reviews, Dave Tapuska, chromium...@chromium.org, blink-...@chromium.org, cc-...@chromium.org, ipc-securi...@chromium.org, max+watc...@igalia.com, nickdiego+wa...@igalia.com, ozone-...@chromium.org

Chromium LUCI CQ submitted the change

Change information

Commit message:

[gfx] Eliminate BufferFormat

Remove BufferFormat enum and relevant utility methods and IPCs
as it is no longer needed.

Bug: 356649879

Change-Id: I289cbb6e0a7191afd48d4a682fa6cddb96105085

Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/7521685

Commit-Queue: Saifuddin Hitawala <hita...@chromium.org>

Reviewed-by: Dave Tapuska <dtap...@chromium.org>

Reviewed-by: Joe Mason <joenot...@google.com>

Reviewed-by: Colin Blundell <blun...@chromium.org>

Reviewed-by: Kyle Charbonneau <kyle...@chromium.org>

Cr-Commit-Position: refs/heads/main@{#1575394}

Files:

M components/viz/common/resources/shared_image_format_utils.cc
M components/viz/common/resources/shared_image_format_utils.h
M third_party/blink/tools/blinkpy/presubmit/audit_non_blink_usage.py
M ui/gfx/mojom/BUILD.gn
M ui/gfx/mojom/buffer_types.mojom
M ui/gfx/mojom/buffer_types_mojom_traits.h
M ui/gfx/mojom/mojom_traits_unittest.cc
M ui/ozone/platform/wayland/mojom/wayland_buffer_manager.mojom

Change size: M

Delta: 8 files changed, 1 insertion(+), 192 deletions(-)

Branch: refs/heads/main

Submit Requirements:

Code-Review: +1 by Colin Blundell, +1 by Dave Tapuska, +1 by Kyle Charbonneau, +1 by Joe Mason

Open in Gerrit

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

open

diffy

satisfied_requirement

Reply all

Reply to author

Forward

[gfx] Eliminate BufferFormat [chromium/src : main]

Saifuddin Hitawala (Gerrit)

Saifuddin Hitawala added 1 comment

Related details

Dave Tapuska (Gerrit)

Dave Tapuska voted Code-Review+1

Related details

gwsq (Gerrit)

Message from gwsq

Related details

Kyle Charbonneau (Gerrit)

Kyle Charbonneau voted and added 1 comment

Votes added by Kyle Charbonneau

1 comment

Related details

Colin Blundell (Gerrit)

Colin Blundell voted and added 1 comment

Votes added by Colin Blundell

1 comment

Related details

Joe Mason (Gerrit)

Joe Mason voted and added 1 comment

Votes added by Joe Mason

1 comment

Related details

Saifuddin Hitawala (Gerrit)

Saifuddin Hitawala voted and added 2 comments

Votes added by Saifuddin Hitawala

2 comments

Related details

Chromium LUCI CQ (Gerrit)

Chromium LUCI CQ submitted the change

Change information