Attach WebContents to HeadlessWindowTreeHost during password change [chromium/src : main]
0 views
Skip to first unread message
Viktor Semeniuk (Gerrit)
Feb 17, 2026, 10:56:01 AM (3 days ago) Feb 17
to Robert Liao, Vasilii Sukhanov, Erik Chen, Peter Kvitek, AyeAye, chromium...@chromium.org, Chromium LUCI CQ, mfoltz+wa...@chromium.org, gcasto+w...@chromium.org, max+watc...@igalia.com, milicau+watchlis...@google.com, nickdiego+wa...@igalia.com, ozone-...@chromium.org, vasilii+watchlis...@chromium.org
Attention needed from Robert Liao and Vasilii Sukhanov
Viktor Semeniuk added 2 comments![]( "Open in Gerrit")
Patchset-level comments
File-level comment, Patchset 16 (Latest):
Viktor Semeniuk . resolved
Hi Robert and Vasilii, PTAL
Thanks!
File chrome/browser/password_manager/password_change_delegate_impl.cc
Line 148, Patchset 6:
class HeadlessWindowTreeHost : public aura::WindowTreeHost {Peter Kvitek . resolved
Viktor SemeniukCould we rename this to something not having `Headless`? `DetachedWindowTreeHost` or something like that.
Reason: Headless is already overloaded in Chrome source tree so it would be good to avoid adding another overload.
Done
Related details
Attention is currently required from:
- Robert Liao
- Vasilii Sukhanov
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
No-Unresolved-Comments
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Robert Liao (Gerrit)
Feb 17, 2026, 5:53:16 PM (3 days ago) Feb 17
to Viktor Semeniuk, Keren Zhu, Vasilii Sukhanov, Erik Chen, Peter Kvitek, AyeAye, chromium...@chromium.org, Chromium LUCI CQ, mfoltz+wa...@chromium.org, gcasto+w...@chromium.org, max+watc...@igalia.com, milicau+watchlis...@google.com, nickdiego+wa...@igalia.com, ozone-...@chromium.org, vasilii+watchlis...@chromium.org
Attention needed from Keren Zhu, Vasilii Sukhanov and Viktor Semeniuk
Robert Liao added 1 comment![]( "Open in Gerrit")
Attention is currently required from:
- Keren Zhu
- Vasilii Sukhanov
- Viktor Semeniuk
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
No-Unresolved-Comments
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Robert Liao (Gerrit)
Feb 17, 2026, 6:02:33 PM (3 days ago) Feb 17
to Viktor Semeniuk, Keren Zhu, Vasilii Sukhanov, Erik Chen, Peter Kvitek, AyeAye, chromium...@chromium.org, Chromium LUCI CQ, mfoltz+wa...@chromium.org, gcasto+w...@chromium.org, max+watc...@igalia.com, milicau+watchlis...@google.com, nickdiego+wa...@igalia.com, ozone-...@chromium.org, vasilii+watchlis...@chromium.org
Attention needed from Keren Zhu, Vasilii Sukhanov and Viktor Semeniuk
Robert Liao added 3 comments![]( "Open in Gerrit")
File chrome/browser/password_manager/password_change/detached_window_tree_host.h
Line 19, Patchset 18 (Latest):
// WindowTreeHost:Robert Liao . resolved
Optional:
```suggestion
private:
// WindowTreeHost:
```
This encourages folks to use the underlying aura::WindowTreeHost type instead of the concrete type.
Line 14, Patchset 18 (Latest):
class DetachedWindowTreeHost : public aura::WindowTreeHost {Robert Liao . unresolved
Add a quick comment above to indicate this is a special WindowTreeHost that will not actually show the underlying native_view.
File chrome/browser/password_manager/password_change/detached_window_tree_host.cc
Line 21, Patchset 18 (Latest):
CreateCompositor(false, false);Robert Liao . unresolved
These are default arguments to CreateCompositor. Are these values critical for this to work?
Keren Zhu (Gerrit)
Feb 17, 2026, 11:11:55 PM (2 days ago) Feb 17
to Viktor Semeniuk, Robert Liao, Vasilii Sukhanov, Erik Chen, Peter Kvitek, AyeAye, chromium...@chromium.org, Chromium LUCI CQ, mfoltz+wa...@chromium.org, gcasto+w...@chromium.org, max+watc...@igalia.com, milicau+watchlis...@google.com, nickdiego+wa...@igalia.com, ozone-...@chromium.org, vasilii+watchlis...@chromium.org
Attention needed from Vasilii Sukhanov and Viktor Semeniuk
Keren Zhu voted and added 4 comments![]( "Open in Gerrit")
Votes added by Keren Zhu
| Code-Review | +1 |
4 comments
Commit Message
Line 10, Patchset 18 (Latest):
like rAF aren't propsagated. This results in APC failures. To resolveKeren Zhu . unresolved
nit: typo
File chrome/browser/password_manager/password_change/detached_window_tree_host.h
Line 14, Patchset 18 (Latest):
class DetachedWindowTreeHost : public aura::WindowTreeHost {Robert Liao . unresolved
Add a quick comment above to indicate this is a special WindowTreeHost that will not actually show the underlying native_view.
Keren Zhu
+1. Also explains that this is needed to drive `requestAnimationFrame()` in a detached WebContents.
File chrome/browser/password_manager/password_change/detached_window_tree_host.cc
Line 68, Patchset 18 (Latest):
void DetachedWindowTreeHost::ShowImpl() {}Keren Zhu . unresolved
nit: add a blank line between each function.
File components/password_manager/core/browser/features/password_features.h
Line 189, Patchset 18 (Latest):
// to which WebContents is attached. This helps to resolve some a problem with
// animations.Keren Zhu . unresolved
```suggestion
// to which WebContents is attached. This helps to resolve the problem
// that requestAnimationFrame() is not fired on a detached WebContents.
```
Related details
Attention is currently required from:
- Vasilii Sukhanov
- Viktor Semeniuk
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
No-Unresolved-Comments
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Reply all
Reply to author
Forward
0 new messages