Fix tracking for maximize state changes from the compositor [chromium/src : main]

0 views
Skip to first unread message

Thomas Anderson (Gerrit)

unread,
Jan 19, 2026, 6:06:19 PM (13 days ago) Jan 19
to Mitchell Cohen, Kramer Ge, Chromium LUCI CQ, chromium...@chromium.org, max+watc...@igalia.com, nickdiego+wa...@igalia.com, ozone-...@chromium.org
Attention needed from Kramer Ge and Mitchell Cohen

Thomas Anderson voted Code-Review+1

Code-Review+1
Open in Gerrit

Related details

Attention is currently required from:
  • Kramer Ge
  • Mitchell Cohen
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement satisfiedCode-Owners
  • requirement is not satisfiedCode-Review
  • requirement is not satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: Ie66de9ba677047f2663b8373920e9616ee7ae2ee
Gerrit-Change-Number: 7486523
Gerrit-PatchSet: 3
Gerrit-Owner: Mitchell Cohen <mitc...@agilebits.com>
Gerrit-Reviewer: Kramer Ge <fang...@chromium.org>
Gerrit-Reviewer: Mitchell Cohen <mitc...@agilebits.com>
Gerrit-Reviewer: Thomas Anderson <thomasa...@chromium.org>
Gerrit-Attention: Mitchell Cohen <mitc...@agilebits.com>
Gerrit-Attention: Kramer Ge <fang...@chromium.org>
Gerrit-Comment-Date: Mon, 19 Jan 2026 23:06:06 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
satisfied_requirement
unsatisfied_requirement
open
diffy

Kramer Ge (Gerrit)

unread,
Jan 20, 2026, 9:59:21 AM (13 days ago) Jan 20
to Mitchell Cohen, Thomas Anderson, Chromium LUCI CQ, chromium...@chromium.org, max+watc...@igalia.com, nickdiego+wa...@igalia.com, ozone-...@chromium.org
Attention needed from Mitchell Cohen

Kramer Ge voted Code-Review+1

Code-Review+1
Open in Gerrit

Related details

Attention is currently required from:
  • Mitchell Cohen
Submit Requirements:
    • requirement satisfiedCode-Coverage
    • requirement satisfiedCode-Owners
    • requirement satisfiedCode-Review
    • requirement satisfiedReview-Enforcement
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: comment
    Gerrit-Project: chromium/src
    Gerrit-Branch: main
    Gerrit-Change-Id: Ie66de9ba677047f2663b8373920e9616ee7ae2ee
    Gerrit-Change-Number: 7486523
    Gerrit-PatchSet: 3
    Gerrit-Owner: Mitchell Cohen <mitc...@agilebits.com>
    Gerrit-Reviewer: Kramer Ge <fang...@chromium.org>
    Gerrit-Reviewer: Mitchell Cohen <mitc...@agilebits.com>
    Gerrit-Reviewer: Thomas Anderson <thomasa...@chromium.org>
    Gerrit-Attention: Mitchell Cohen <mitc...@agilebits.com>
    Gerrit-Comment-Date: Tue, 20 Jan 2026 14:59:10 +0000
    Gerrit-HasComments: No
    Gerrit-Has-Labels: Yes
    satisfied_requirement
    open
    diffy

    Kramer Ge (Gerrit)

    unread,
    Jan 20, 2026, 11:01:56 AM (13 days ago) Jan 20
    to Mitchell Cohen, Thomas Anderson, Chromium LUCI CQ, chromium...@chromium.org, max+watc...@igalia.com, nickdiego+wa...@igalia.com, ozone-...@chromium.org
    Attention needed from Mitchell Cohen

    Kramer Ge voted Commit-Queue+2

    Commit-Queue+2
    Open in Gerrit

    Related details

    Attention is currently required from:
    • Mitchell Cohen
    Submit Requirements:
    • requirement satisfiedCode-Coverage
    • requirement satisfiedCode-Owners
    • requirement satisfiedCode-Review
    • requirement satisfiedReview-Enforcement
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: comment
    Gerrit-Project: chromium/src
    Gerrit-Branch: main
    Gerrit-Change-Id: Ie66de9ba677047f2663b8373920e9616ee7ae2ee
    Gerrit-Change-Number: 7486523
    Gerrit-PatchSet: 3
    Gerrit-Owner: Mitchell Cohen <mitc...@agilebits.com>
    Gerrit-Reviewer: Kramer Ge <fang...@chromium.org>
    Gerrit-Reviewer: Mitchell Cohen <mitc...@agilebits.com>
    Gerrit-Reviewer: Thomas Anderson <thomasa...@chromium.org>
    Gerrit-Attention: Mitchell Cohen <mitc...@agilebits.com>
    Gerrit-Comment-Date: Tue, 20 Jan 2026 16:01:43 +0000
    Gerrit-HasComments: No
    Gerrit-Has-Labels: Yes
    satisfied_requirement
    open
    diffy

    Chromium LUCI CQ (Gerrit)

    unread,
    Jan 20, 2026, 11:49:17 AM (13 days ago) Jan 20
    to Mitchell Cohen, Kramer Ge, Thomas Anderson, chromium...@chromium.org, max+watc...@igalia.com, nickdiego+wa...@igalia.com, ozone-...@chromium.org

    Chromium LUCI CQ submitted the change

    Change information

    Commit message:
    Fix tracking for maximize state changes from the compositor

    If the window is maximized by the compositor, e.g. when dragging to
    tile, it doesn't go through the SetWindowState path. Copied a state
    update to HandleToplevelConfigure to catch those instances.
    Bug: 476651194
    Change-Id: Ie66de9ba677047f2663b8373920e9616ee7ae2ee
    Reviewed-by: Kramer Ge <fang...@chromium.org>
    Commit-Queue: Kramer Ge <fang...@chromium.org>
    Reviewed-by: Thomas Anderson <thomasa...@chromium.org>
    Cr-Commit-Position: refs/heads/main@{#1571670}
    Files:
    • M ui/ozone/platform/wayland/host/wayland_toplevel_window.cc
    • M ui/ozone/platform/wayland/host/wayland_toplevel_window.h
    Change size: S
    Delta: 2 files changed, 19 insertions(+), 10 deletions(-)
    Branch: refs/heads/main
    Submit Requirements:
    • requirement satisfiedCode-Review: +1 by Thomas Anderson, +1 by Kramer Ge
    Open in Gerrit
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: merged
    Gerrit-Project: chromium/src
    Gerrit-Branch: main
    Gerrit-Change-Id: Ie66de9ba677047f2663b8373920e9616ee7ae2ee
    Gerrit-Change-Number: 7486523
    Gerrit-PatchSet: 4
    Gerrit-Owner: Mitchell Cohen <mitc...@agilebits.com>
    Gerrit-Reviewer: Chromium LUCI CQ <chromiu...@luci-project-accounts.iam.gserviceaccount.com>
    Gerrit-Reviewer: Kramer Ge <fang...@chromium.org>
    Gerrit-Reviewer: Mitchell Cohen <mitc...@agilebits.com>
    Gerrit-Reviewer: Thomas Anderson <thomasa...@chromium.org>
    open
    diffy
    satisfied_requirement
    Reply all
    Reply to author
    Forward
    0 new messages