[//ui] Have OzonePlatform::IsNativePixmapConfigSupported take SIFormat [chromium/src : main]
0 views
Skip to first unread message
Colin Blundell (Gerrit)
Jan 7, 2026, 11:35:54 AM (4 days ago) Jan 7
to Colin Blundell, Saifuddin Hitawala, Daniel Cheng, AyeAye, Chromium LUCI CQ, chromium...@chromium.org, David Worsham, Robert Kroeger, emi...@google.com, fuchsia...@chromium.org, max+watc...@igalia.com, nickdiego+wa...@igalia.com, ozone-...@chromium.org, spang...@chromium.org
Attention needed from Daniel Cheng and Saifuddin Hitawala
Colin Blundell added 1 comment![]( "Open in Gerrit")
Patchset-level comments
File-level comment, Patchset 2 (Latest):
Colin Blundell . resolved
Saif: for the CL as a whole
dcheng@: for mappable_buffer_test_template.h
Related details
Attention is currently required from:
- Daniel Cheng
- Saifuddin Hitawala
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Saifuddin Hitawala (Gerrit)
Jan 7, 2026, 12:43:59 PM (4 days ago) Jan 7
to Colin Blundell, Daniel Cheng, AyeAye, Chromium LUCI CQ, chromium...@chromium.org, David Worsham, Robert Kroeger, emi...@google.com, fuchsia...@chromium.org, max+watc...@igalia.com, nickdiego+wa...@igalia.com, ozone-...@chromium.org, spang...@chromium.org
Attention needed from Colin Blundell and Daniel Cheng
Saifuddin Hitawala voted and added 1 comment![]( "Open in Gerrit")
Votes added by Saifuddin Hitawala
| Code-Review | +1 |
1 comment
Patchset-level comments
Attention is currently required from:
- Colin Blundell
- Daniel Cheng
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Daniel Cheng (Gerrit)
Jan 7, 2026, 1:18:57 PM (4 days ago) Jan 7
to Colin Blundell, Daniel Cheng, Saifuddin Hitawala, AyeAye, Chromium LUCI CQ, chromium...@chromium.org, David Worsham, Robert Kroeger, emi...@google.com, fuchsia...@chromium.org, max+watc...@igalia.com, nickdiego+wa...@igalia.com, ozone-...@chromium.org, spang...@chromium.org
Attention needed from Colin Blundell
Daniel Cheng voted Code-Review+1![]( "Open in Gerrit")
| Code-Review | +1 |
Related details
Attention is currently required from:
- Colin Blundell
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Chromium LUCI CQ (Gerrit)
Jan 8, 2026, 6:14:46 AM (3 days ago) Jan 8
to Colin Blundell, Daniel Cheng, Saifuddin Hitawala, AyeAye, chromium...@chromium.org, David Worsham, Robert Kroeger, emi...@google.com, fuchsia...@chromium.org, max+watc...@igalia.com, nickdiego+wa...@igalia.com, ozone-...@chromium.org, spang...@chromium.org
Chromium LUCI CQ submitted the change with unreviewed changes![]( "Open in Gerrit")
Unreviewed changes
2 is the latest approved patch-set.
The change was submitted with unreviewed changes in the following files:
```
The name of the file: ui/ozone/platform/wayland/ozone_platform_wayland.cc
Insertions: 1, Deletions: 2.
The diff is too large to show. Please review the diff.
```
Change information
Commit message:
[//ui] Have OzonePlatform::IsNativePixmapConfigSupported take SIFormat
Bug: 356649879
Change-Id: Iba8e22f0d800f36a6fab4769df12ccab80374dbc
Commit-Queue: Colin Blundell <blun...@chromium.org>
Reviewed-by: Saifuddin Hitawala <hita...@chromium.org>
Reviewed-by: Daniel Cheng <dch...@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1566186}
Files:
- M gpu/command_buffer/client/internal/mappable_buffer_test_template.h
- M gpu/command_buffer/service/shared_image/ozone_image_backing_factory_unittest.cc
- M gpu/command_buffer/service/shared_image/shared_image_factory.cc
- M ui/ozone/platform/cast/ozone_platform_cast.cc
- M ui/ozone/platform/drm/ozone_platform_drm.cc
- M ui/ozone/platform/flatland/ozone_platform_flatland.cc
- M ui/ozone/platform/wayland/ozone_platform_wayland.cc
- M ui/ozone/platform/x11/ozone_platform_x11.cc
- M ui/ozone/public/ozone_platform.cc
- M ui/ozone/public/ozone_platform.h
Change size: M
Delta: 10 files changed, 28 insertions(+), 30 deletions(-)
Branch: refs/heads/main
Submit Requirements:
Code-Review: +1 by Saifuddin Hitawala, +1 by Daniel Cheng
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
luci-bisection@appspot.gserviceaccount.com (Gerrit)
Jan 8, 2026, 6:27:53 AM (3 days ago) Jan 8
to Chromium LUCI CQ, Colin Blundell, Daniel Cheng, Saifuddin Hitawala, AyeAye, chromium...@chromium.org, David Worsham, Robert Kroeger, emi...@google.com, fuchsia...@chromium.org, max+watc...@igalia.com, nickdiego+wa...@igalia.com, ozone-...@chromium.org, spang...@chromium.org
Message from luci-bi...@appspot.gserviceaccount.com![]( "Open in Gerrit")
LUCI Bisection has identified this change as the culprit of a build failure. See the analysis: https://ci.chromium.org/ui/p/chromium/bisection/compile-analysis/b/8693246647954167649
A revert for this change was not created because there are merged changes depending on it.
Sample failed build: https://ci.chromium.org/b/8693246647954167649
If this is a false positive, please report it at http://b.corp.google.com/createIssue?component=1199205&description=Analysis%3A+https%3A%2F%2Fchromium-review.googlesource.com%2Fc%2Fchromium%2Fsrc%2F%2B%2F7380105&format=PLAIN&priority=P3&title=Wrongly+blamed+https%3A%2F%2Fci.chromium.org%2Fui%2Fp%2Fchromium%2Fbisection%2Fcompile-analysis%2Fb%2F8693246647954167649&type=BUG
Related details
Attention set is empty
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Gabrielle Lau (Gerrit)
Jan 8, 2026, 6:29:48 AM (3 days ago) Jan 8
to Chromium LUCI CQ, Colin Blundell, luci-bi...@appspot.gserviceaccount.com, Daniel Cheng, Saifuddin Hitawala, AyeAye, chromium...@chromium.org, David Worsham, Robert Kroeger, emi...@google.com, fuchsia...@chromium.org, max+watc...@igalia.com, nickdiego+wa...@igalia.com, ozone-...@chromium.org, spang...@chromium.org
Gabrielle Lau has created a revert of this change![]( "Open in Gerrit")
Related details
Attention set is empty
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Reply all
Reply to author
Forward
0 new messages