[//ui] Streamline GLEGLUtilityX11::CollectGpuExtraInfo() [chromium/src : main]
0 views
Skip to first unread message
Colin Blundell (Gerrit)
Nov 4, 2025, 12:15:35 PM (2 days ago) Nov 4
to Colin Blundell, Vasiliy Telezhnikov, Chromium LUCI CQ, chromium...@chromium.org, ozone-...@chromium.org
Attention needed from Vasiliy Telezhnikov
Colin Blundell voted Commit-Queue+1![]( "Open in Gerrit")
| Commit-Queue | +1 |
Related details
Attention is currently required from:
- Vasiliy Telezhnikov
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Vasiliy Telezhnikov (Gerrit)
Nov 4, 2025, 12:43:27 PM (2 days ago) Nov 4
to Colin Blundell, Chromium LUCI CQ, chromium...@chromium.org, ozone-...@chromium.org
Attention needed from Colin Blundell
Vasiliy Telezhnikov voted and added 2 comments![]( "Open in Gerrit")
Votes added by Vasiliy Telezhnikov
| Code-Review | +1 |
2 comments
Patchset-level comments
Commit Message
Line 10, Patchset 2 (Latest):
GL implementation used. The code has been this way for 3 years (sinceVasiliy Telezhnikov . resolved
The only other one is `kGLImplementationDisabled`, but we can't reach the code in this case because of [this](https://source.chromium.org/chromium/chromium/src/+/main:gpu/ipc/service/gpu_init.cc;drc=128f35b3fb019f2fa67e1e798e113ed95f766096;l=758).
Related details
Attention is currently required from:
- Colin Blundell
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Colin Blundell (Gerrit)
Nov 5, 2025, 2:55:53 AM (yesterday) Nov 5
to Colin Blundell, Vasiliy Telezhnikov, Chromium LUCI CQ, chromium...@chromium.org, ozone-...@chromium.org
Colin Blundell added 1 comment![]( "Open in Gerrit")
Commit Message
Line 10, Patchset 2:
GL implementation used. The code has been this way for 3 years (sinceVasiliy Telezhnikov . resolved
The only other one is `kGLImplementationDisabled`, but we can't reach the code in this case because of [this](https://source.chromium.org/chromium/chromium/src/+/main:gpu/ipc/service/gpu_init.cc;drc=128f35b3fb019f2fa67e1e798e113ed95f766096;l=758).
Colin Blundell
Thanks for flagging this! I had intuitively thought that we wouldn't be going into this code if GL was disabled, but I neglected to actually verify that assumption. Added to the CL description here.
Related details
Attention set is empty
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Colin Blundell (Gerrit)
Nov 5, 2025, 2:55:55 AM (yesterday) Nov 5
to Colin Blundell, Vasiliy Telezhnikov, Chromium LUCI CQ, chromium...@chromium.org, ozone-...@chromium.org
Colin Blundell voted Commit-Queue+2![]( "Open in Gerrit")
| Commit-Queue | +2 |
Related details
Attention set is empty
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Chromium LUCI CQ (Gerrit)
Nov 5, 2025, 2:58:50 AM (yesterday) Nov 5
to Colin Blundell, Vasiliy Telezhnikov, chromium...@chromium.org, ozone-...@chromium.org
Chromium LUCI CQ submitted the change![]( "Open in Gerrit")
Unreviewed changes
2 is the latest approved patch-set.
No files were changed between the latest approved patch-set and the submitted one.
Change information
Commit message:
[//ui] Streamline GLEGLUtilityX11::CollectGpuExtraInfo()
This code is effectively a no-op in production now as the only two
GL implementations used are (a) ANGLE and (b) kGLImplementationDisabled,
does not reach this code [1]. The code has been this way for 3 years
(since the passthrough decoder shipped 100% on Linux), and we are not
actively looking to bring up support in ANGLE's GLX backend. Make the
method into a no-op to start the chain of cleanup that we'll do here.
[1] https://source.chromium.org/chromium/chromium/src/+/main:gpu/ipc/service/gpu_init.cc;drc=128f35b3fb019f2fa67e1e798e113ed95f766096;l=758
Bug: 457646315
Change-Id: Ic2963dc81ffafd79a86b31483dbeb918395208ac
Reviewed-by: Vasiliy Telezhnikov <vas...@chromium.org>
Commit-Queue: Colin Blundell <blun...@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1540505}
Files:
- M ui/ozone/platform/x11/gl_egl_utility_x11.cc
Change size: S
Delta: 1 file changed, 0 insertions(+), 14 deletions(-)
Branch: refs/heads/main
Submit Requirements:
Code-Review: +1 by Vasiliy Telezhnikov
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Reply all
Reply to author
Forward
0 new messages