[M141] [Ozone/Wayland]gbm_pixmap_wayland fallback to implicit modifier [chromium/src : refs/branch-heads/7390]

[Rubber Stamper (Gerrit)]

Rubber Stamper voted

Bot-Commit	+1
Commit-Queue	+2

Open in Gerrit

Related details

Attention set is empty

Submit Requirements:

• Code-Owners
• Code-Review
• Lint

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

Gerrit-MessageType: comment

Gerrit-Project: chromium/src

Gerrit-Branch: refs/branch-heads/7390

Gerrit-Change-Id: I3b9b9e66c17b3968213007d5e1643b59a6987052

Gerrit-Change-Number: 7003064

Gerrit-PatchSet: 2

Gerrit-Owner: Chrome Cherry Picker <chrome-che...@chops-service-accounts.iam.gserviceaccount.com>

Gerrit-Reviewer: Chrome Cherry Picker <chrome-che...@chops-service-accounts.iam.gserviceaccount.com>

Gerrit-Reviewer: Rubber Stamper <rubber-...@appspot.gserviceaccount.com>

Gerrit-CC: AyeAye <android-bu...@system.gserviceaccount.com>

Gerrit-CC: Kramer Ge <fang...@chromium.org>

Gerrit-Comment-Date: Wed, 01 Oct 2025 16:51:16 +0000

Gerrit-HasComments: No

Gerrit-Has-Labels: Yes

[Chromium LUCI CQ (Gerrit)]

Chromium LUCI CQ submitted the change

Change information

Commit message:

[M141] [Ozone/Wayland]gbm_pixmap_wayland fallback to implicit modifier

Original change's description:
> [Ozone/Wayland]gbm_pixmap_wayland fallback to implicit modifier
> 
> linux_dmabuf extension specifies that DRM_FORMAT_MOD_INVALID is allowed
> for server to indicate support for implicit modifier.
> 
> wlroots-based compositor such as sway appears to always announce
> MOD_INVALID and MOD_LINEAR. However, in reality some hardware driver
> does not render to MOD_LINEAR, so we need to perform this fallback. As
> long as the device selection matches the compositor, driver should know
> about the modifiers internally.
> 
> Add MOD_INVALID to the list to indicate implicit modifier support.
> 
> Bug: 446395287
> Change-Id: I3b9b9e66c17b3968213007d5e1643b59a6987052
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6972623
> Commit-Queue: Kramer Ge <fang...@chromium.org>
> Reviewed-by: Peter McNeeley <peterm...@google.com>
> Cr-Commit-Position: refs/heads/main@{#1521503}

(cherry picked from commit e3790b49494f936a8246f5a991bf05d3d2d44d3a)

Bug: 448392602,446395287

Change-Id: I3b9b9e66c17b3968213007d5e1643b59a6987052

Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/7003064

Commit-Queue: Rubber Stamper <rubber-...@appspot.gserviceaccount.com>

Bot-Commit: Rubber Stamper <rubber-...@appspot.gserviceaccount.com>

Auto-Submit: Chrome Cherry Picker <chrome-che...@chops-service-accounts.iam.gserviceaccount.com>

Cr-Commit-Position: refs/branch-heads/7390@{#2114}

Cr-Branched-From: d481efce5eb300acbb896686676ebd0352a6f1db-refs/heads/main@{#1509326}

Files:

• M ui/ozone/platform/wayland/gpu/gbm_pixmap_wayland.cc
• M ui/ozone/platform/wayland/gpu/wayland_buffer_manager_gpu.cc
• M ui/ozone/platform/wayland/gpu/wayland_buffer_manager_gpu.h
• M ui/ozone/platform/wayland/host/wayland_zwp_linux_dmabuf.cc
• M ui/ozone/platform/wayland/wayland_buffer_manager_unittest.cc

Change size: M

Delta: 5 files changed, 54 insertions(+), 30 deletions(-)

Branch: refs/branch-heads/7390

Submit Requirements:

• Code-Review: Bot-Commit+1 by Rubber Stamper

Open in Gerrit

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

Gerrit-MessageType: merged

Gerrit-Project: chromium/src

Gerrit-Branch: refs/branch-heads/7390

Gerrit-Change-Id: I3b9b9e66c17b3968213007d5e1643b59a6987052

Gerrit-Change-Number: 7003064

Gerrit-PatchSet: 3

Gerrit-Owner: Chrome Cherry Picker <chrome-che...@chops-service-accounts.iam.gserviceaccount.com>

Gerrit-Reviewer: Chrome Cherry Picker <chrome-che...@chops-service-accounts.iam.gserviceaccount.com>

Gerrit-Reviewer: Chromium LUCI CQ <chromiu...@luci-project-accounts.iam.gserviceaccount.com>