ozone/wayland: use wl_output_set_user_data instead of own containers [chromium/src : master]

11 views
Skip to first unread message

Maksim Sisov (Gerrit)

unread,
Mar 19, 2021, 10:02:14 AM3/19/21
to Robert Kroeger, ozone-...@chromium.org

Attention is currently required from: Robert Kroeger.

Maksim Sisov would like Robert Kroeger to review this change.

View Change

ozone/wayland: use wl_output_set_user_data instead of own containers

Having own container and searching for an output adds additional
overhead, which can be avoided with using Wayland's *_set_user_data.

This way, existing Wayland utility is used to associated clients'
objects with Wayland create objects.

Bug: 578890
Change-Id: I8bcd11f9fb13c4802a966e553e5282729aceb9e2
---
M ui/ozone/platform/wayland/host/wayland_output_manager.cc
M ui/ozone/platform/wayland/host/wayland_output_manager.h
M ui/ozone/platform/wayland/host/wayland_window.cc
3 files changed, 11 insertions(+), 17 deletions(-)


To view, visit change 2772993. To unsubscribe, or for help writing mail filters, visit settings.

Gerrit-Project: chromium/src
Gerrit-Branch: master
Gerrit-Change-Id: I8bcd11f9fb13c4802a966e553e5282729aceb9e2
Gerrit-Change-Number: 2772993
Gerrit-PatchSet: 1
Gerrit-Owner: Maksim Sisov <msi...@igalia.com>
Gerrit-Reviewer: Maksim Sisov <msi...@igalia.com>
Gerrit-Reviewer: Robert Kroeger <rjkr...@chromium.org>
Gerrit-CC: Kalyan Kondapally <kalyan.k...@intel.com>
Gerrit-Attention: Robert Kroeger <rjkr...@chromium.org>
Gerrit-MessageType: newchange

Maksim Sisov (Gerrit)

unread,
Mar 19, 2021, 10:02:22 AM3/19/21
to ozone-...@chromium.org, Robert Kroeger, chromium...@chromium.org, Kalyan Kondapally

Attention is currently required from: Robert Kroeger.

Patch set 1:Code-Review +1Commit-Queue +1

View Change

1 comment:

To view, visit change 2772993. To unsubscribe, or for help writing mail filters, visit settings.

Gerrit-Project: chromium/src
Gerrit-Branch: master
Gerrit-Change-Id: I8bcd11f9fb13c4802a966e553e5282729aceb9e2
Gerrit-Change-Number: 2772993
Gerrit-PatchSet: 1
Gerrit-Owner: Maksim Sisov <msi...@igalia.com>
Gerrit-Reviewer: Maksim Sisov <msi...@igalia.com>
Gerrit-Reviewer: Robert Kroeger <rjkr...@chromium.org>
Gerrit-CC: Kalyan Kondapally <kalyan.k...@intel.com>
Gerrit-Attention: Robert Kroeger <rjkr...@chromium.org>
Gerrit-Comment-Date: Fri, 19 Mar 2021 14:02:10 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment

Maksim Sisov (Gerrit)

unread,
Mar 19, 2021, 10:02:34 AM3/19/21
to ozone-...@chromium.org

Attention is currently required from: Robert Kroeger.

Maksim Sisov uploaded patch set #2 to this change.

View Change

ozone/wayland: use wl_output_set_user_data instead of own containers

Having own container and searching for an output adds additional
overhead, which can be avoided with using Wayland's *_set_user_data.

This way, existing Wayland utility methods are used to associate

clients' objects with Wayland create objects.

Bug: 578890
Change-Id: I8bcd11f9fb13c4802a966e553e5282729aceb9e2
---
M ui/ozone/platform/wayland/host/wayland_output_manager.cc
M ui/ozone/platform/wayland/host/wayland_output_manager.h
M ui/ozone/platform/wayland/host/wayland_window.cc
3 files changed, 11 insertions(+), 17 deletions(-)

To view, visit change 2772993. To unsubscribe, or for help writing mail filters, visit settings.

Gerrit-Project: chromium/src
Gerrit-Branch: master
Gerrit-Change-Id: I8bcd11f9fb13c4802a966e553e5282729aceb9e2
Gerrit-Change-Number: 2772993
Gerrit-PatchSet: 2
Gerrit-Owner: Maksim Sisov <msi...@igalia.com>
Gerrit-Reviewer: Maksim Sisov <msi...@igalia.com>
Gerrit-Reviewer: Robert Kroeger <rjkr...@chromium.org>
Gerrit-CC: Kalyan Kondapally <kalyan.k...@intel.com>
Gerrit-Attention: Robert Kroeger <rjkr...@chromium.org>
Gerrit-MessageType: newpatchset

Maksim Sisov (Gerrit)

unread,
Mar 19, 2021, 10:17:34 AM3/19/21
to ozone-...@chromium.org

Attention is currently required from: Robert Kroeger.

Maksim Sisov uploaded patch set #3 to this change.

View Change

ozone/wayland: use wl_output_set_user_data instead of own containers

Having own container and searching for an output adds additional
overhead, which can be avoided with using Wayland's *_set_user_data.

This way, existing Wayland utility methods are used to associate
clients' objects with Wayland create objects.

Bug: 1190141

Change-Id: I8bcd11f9fb13c4802a966e553e5282729aceb9e2
---
M ui/ozone/platform/wayland/host/wayland_output_manager.cc
M ui/ozone/platform/wayland/host/wayland_output_manager.h
M ui/ozone/platform/wayland/host/wayland_window.cc
3 files changed, 11 insertions(+), 17 deletions(-)

To view, visit change 2772993. To unsubscribe, or for help writing mail filters, visit settings.

Gerrit-Project: chromium/src
Gerrit-Branch: master
Gerrit-Change-Id: I8bcd11f9fb13c4802a966e553e5282729aceb9e2
Gerrit-Change-Number: 2772993
Gerrit-PatchSet: 3

Robert Kroeger (Gerrit)

unread,
Mar 19, 2021, 11:52:12 AM3/19/21
to Maksim Sisov, ozone-...@chromium.org, Tricium, Chromium LUCI CQ, chromium...@chromium.org, Kalyan Kondapally

Attention is currently required from: Maksim Sisov.

Patch set 4:Code-Review +1

View Change

    To view, visit change 2772993. To unsubscribe, or for help writing mail filters, visit settings.

    Gerrit-Project: chromium/src
    Gerrit-Branch: master
    Gerrit-Change-Id: I8bcd11f9fb13c4802a966e553e5282729aceb9e2
    Gerrit-Change-Number: 2772993
    Gerrit-PatchSet: 4
    Gerrit-Owner: Maksim Sisov <msi...@igalia.com>
    Gerrit-Reviewer: Maksim Sisov <msi...@igalia.com>
    Gerrit-Reviewer: Robert Kroeger <rjkr...@chromium.org>
    Gerrit-CC: Kalyan Kondapally <kalyan.k...@intel.com>
    Gerrit-Attention: Maksim Sisov <msi...@igalia.com>
    Gerrit-Comment-Date: Fri, 19 Mar 2021 15:51:44 +0000
    Gerrit-HasComments: No
    Gerrit-Has-Labels: Yes
    Gerrit-MessageType: comment

    Maksim Sisov (Gerrit)

    unread,
    Mar 22, 2021, 2:58:12 AM3/22/21
    to ozone-...@chromium.org, Robert Kroeger, Tricium, Chromium LUCI CQ, chromium...@chromium.org, Kalyan Kondapally

    Patch set 4:Commit-Queue +2

    View Change

      To view, visit change 2772993. To unsubscribe, or for help writing mail filters, visit settings.

      Gerrit-Project: chromium/src
      Gerrit-Branch: master
      Gerrit-Change-Id: I8bcd11f9fb13c4802a966e553e5282729aceb9e2
      Gerrit-Change-Number: 2772993
      Gerrit-PatchSet: 4
      Gerrit-Owner: Maksim Sisov <msi...@igalia.com>
      Gerrit-Reviewer: Maksim Sisov <msi...@igalia.com>
      Gerrit-Reviewer: Robert Kroeger <rjkr...@chromium.org>
      Gerrit-CC: Kalyan Kondapally <kalyan.k...@intel.com>
      Gerrit-Comment-Date: Mon, 22 Mar 2021 06:57:54 +0000

      Chromium LUCI CQ (Gerrit)

      unread,
      Mar 22, 2021, 4:19:18 AM3/22/21
      to Maksim Sisov, ozone-...@chromium.org, Robert Kroeger, Tricium, chromium...@chromium.org, Kalyan Kondapally

      Chromium LUCI CQ submitted this change.

      View Change

      Approvals: Robert Kroeger: Looks good to me Maksim Sisov: Looks good to me; Commit
      ozone/wayland: use wl_output_set_user_data instead of own containers

      Having own container and searching for an output adds additional
      overhead, which can be avoided with using Wayland's *_set_user_data.

      This way, existing Wayland utility methods are used to associate
      clients' objects with Wayland create objects.

      Bug: 1190141
      Change-Id: I8bcd11f9fb13c4802a966e553e5282729aceb9e2
      Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2772993
      Reviewed-by: Maksim Sisov <msi...@igalia.com>
      Reviewed-by: Robert Kroeger <rjkr...@chromium.org>
      Commit-Queue: Maksim Sisov <msi...@igalia.com>
      Cr-Commit-Position: refs/heads/master@{#865063}
      ---
      M ui/ozone/platform/wayland/host/wayland_output.cc

      M ui/ozone/platform/wayland/host/wayland_output_manager.cc
      M ui/ozone/platform/wayland/host/wayland_output_manager.h
      M ui/ozone/platform/wayland/host/wayland_window.cc
      4 files changed, 17 insertions(+), 19 deletions(-)


      To view, visit change 2772993. To unsubscribe, or for help writing mail filters, visit settings.

      Gerrit-Project: chromium/src
      Gerrit-Branch: master
      Gerrit-Change-Id: I8bcd11f9fb13c4802a966e553e5282729aceb9e2
      Gerrit-Change-Number: 2772993
      Gerrit-PatchSet: 5
      Gerrit-Owner: Maksim Sisov <msi...@igalia.com>
      Gerrit-Reviewer: Chromium LUCI CQ <chromiu...@luci-project-accounts.iam.gserviceaccount.com>
      Gerrit-Reviewer: Maksim Sisov <msi...@igalia.com>
      Gerrit-Reviewer: Robert Kroeger <rjkr...@chromium.org>
      Gerrit-CC: Kalyan Kondapally <kalyan.k...@intel.com>
      Gerrit-MessageType: merged
      Reply all
      Reply to author
      Forward
      0 new messages