[viz] Optimize SharedImageFormat set usage in Flatland and GL utils [chromium/src : main]
0 views
Skip to first unread message
Andrew Paseltiner (Gerrit)
Mar 19, 2026, 2:29:38 PMMar 19
to Victor Miura, David Song, Chromium LUCI CQ, AyeAye, chromium...@chromium.org, David Worsham, Robert Kroeger, emi...@google.com, fuchsia...@chromium.org, ozone-...@chromium.org, spang...@chromium.org
Attention needed from David Song and Victor Miura
New activity on the change![]( "Open in Gerrit")
Related details
Attention is currently required from:
- David Song
- Victor Miura
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
David Song (Gerrit)
Mar 19, 2026, 2:32:39 PMMar 19
to Andrew Paseltiner, Victor Miura, Chromium LUCI CQ, AyeAye, chromium...@chromium.org, David Worsham, Robert Kroeger, emi...@google.com, fuchsia...@chromium.org, ozone-...@chromium.org, spang...@chromium.org
Attention needed from Andrew Paseltiner and Victor Miura
David Song voted Code-Review+1![]( "Open in Gerrit")
Attention is currently required from:
- Andrew Paseltiner
- Victor Miura
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Victor Miura (Gerrit)
Mar 20, 2026, 11:10:22 AM (13 days ago) Mar 20
to Andrew Paseltiner, David Song, Chromium LUCI CQ, AyeAye, chromium...@chromium.org, David Worsham, Robert Kroeger, emi...@google.com, fuchsia...@chromium.org, ozone-...@chromium.org, spang...@chromium.org
Attention needed from Andrew Paseltiner
Victor Miura voted and added 1 comment![]( "Open in Gerrit")
Related details
Attention is currently required from:
- Andrew Paseltiner
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Andrew Paseltiner (Gerrit)
Mar 20, 2026, 11:10:58 AM (13 days ago) Mar 20
to Victor Miura, David Song, Chromium LUCI CQ, AyeAye, chromium...@chromium.org, David Worsham, Robert Kroeger, emi...@google.com, fuchsia...@chromium.org, ozone-...@chromium.org, spang...@chromium.org
Andrew Paseltiner voted Commit-Queue+2![]( "Open in Gerrit")
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Chromium LUCI CQ (Gerrit)
Mar 20, 2026, 11:13:46 AM (13 days ago) Mar 20
to Andrew Paseltiner, Victor Miura, David Song, AyeAye, chromium...@chromium.org, David Worsham, Robert Kroeger, emi...@google.com, fuchsia...@chromium.org, ozone-...@chromium.org, spang...@chromium.org
Chromium LUCI CQ submitted the change![]( "Open in Gerrit")
Change information
Commit message:
[viz] Optimize SharedImageFormat set usage in Flatland and GL utils
- In gpu/command_buffer/service/gl_utils.cc:
Use the base::flat_set initializer list constructor directly for
mappable_formats instead of through an intermediate vector.
- In FlatlandSurfaceFactory and FlatlandSysmemBufferCollection:
Update the initialization of kSupportedFormats to use the flat_set
initializer list constructor directly.
These sites previously used base::MakeFlatSet with a temporary
std::vector. Since base::MakeFlatSet takes its input container by const
ref, this resulted in an unnecessary vector being created and copied.
Note: Using base::MakeFixedFlatSet for these format lists would be
preferable for performance, but it's currently not possible because
viz::SharedImageFormat lacks constexpr comparison operators.
Bug: 494183505
Change-Id: I798c9a9dd6259afc6964fafe9a56c967b3fcc369
Reviewed-by: David Song <winter...@google.com>
Reviewed-by: Victor Miura <vmi...@chromium.org>
Commit-Queue: Andrew Paseltiner <apase...@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1602621}
Files:
- M gpu/command_buffer/service/gl_utils.cc
- M ui/ozone/platform/flatland/flatland_surface_factory.cc
- M ui/ozone/platform/flatland/flatland_sysmem_buffer_collection.cc
Change size: M
Delta: 3 files changed, 23 insertions(+), 29 deletions(-)
Branch: refs/heads/main
Submit Requirements:
Code-Review: +1 by Victor Miura, +1 by David Song
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Reply all
Reply to author
Forward
0 new messages