Fix NumpadDelete key on Wayland. [chromium/src : main]
0 views
Skip to first unread message
Jamie Walch (Gerrit)
Jul 21, 2026, 6:53:22 PM (2 days ago) Jul 21
to android-bu...@system.gserviceaccount.com, ozone-...@chromium.org
New activity on the change![]( "Open in Gerrit")
Related details
Attention set is empty
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Kevin Schoedel (Gerrit)
Jul 22, 2026, 11:20:47 AM (yesterday) Jul 22
to Jamie Walch, android-bu...@system.gserviceaccount.com, ozone-...@chromium.org
Attention needed from Jamie Walch
Kevin Schoedel added 1 comment![]( "Open in Gerrit")
Patchset-level comments
File-level comment, Patchset 2 (Latest):
Kevin Schoedel . resolved
LGTM but I'm waiting on a @chromium.org 2FA reset. If you're in a hurry, ask spang@ for a rubber stamp.
Related details
Attention is currently required from:
- Jamie Walch
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Michael Spang (Gerrit)
Jul 22, 2026, 2:23:54 PM (yesterday) Jul 22
to Jamie Walch, Chromium LUCI CQ, Kevin Schoedel, android-bu...@system.gserviceaccount.com, ozone-...@chromium.org
Attention needed from Jamie Walch
Michael Spang voted Code-Review+1![]( "Open in Gerrit")
| Code-Review | +1 |
Related details
Attention is currently required from:
- Jamie Walch
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Jamie Walch (Gerrit)
Jul 22, 2026, 2:24:35 PM (yesterday) Jul 22
to Michael Spang, Chromium LUCI CQ, Kevin Schoedel, android-bu...@system.gserviceaccount.com, ozone-...@chromium.org
Jamie Walch voted Commit-Queue+2![]( "Open in Gerrit")
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Chromium LUCI CQ (Gerrit)
Jul 22, 2026, 3:19:19 PM (yesterday) Jul 22
to Jamie Walch, Michael Spang, Kevin Schoedel, android-bu...@system.gserviceaccount.com, ozone-...@chromium.org
Chromium LUCI CQ submitted the change![]( "Open in Gerrit")
Change information
Commit message:
Fix NumpadDelete key on Wayland.
https://chromium-review.git.corp.google.com/c/chromium/src/+/8016999
fixed the DOM code mapping for NumpadDelete with NumLock disabled, but
introduced a bug if NumLock is enabled. The DOM code is correct, but the
key doesn't print anything, either in web pages or in Chrome's UI.
Fixed: 535467237
Change-Id: Ib5c4af18c7e622d6cf32a1aef31ef0b295a04fa7
Reviewed-by: Michael Spang <sp...@chromium.org>
Commit-Queue: Jamie Walch <jamie...@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1666533}
Files:
- M ui/events/ozone/layout/xkb/xkb_keyboard_layout_engine.cc
- M ui/events/ozone/layout/xkb/xkb_keyboard_layout_engine_unittest.cc
Change size: M
Delta: 2 files changed, 86 insertions(+), 2 deletions(-)
Branch: refs/heads/main
Submit Requirements:
Code-Review: +1 by Michael Spang
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Reply all
Reply to author
Forward
0 new messages