[Ozone/Wayland]Remove idle_inhibitor_ object from WaylandScreen [chromium/src : main]
0 views
Skip to first unread message
Kramer Ge (Gerrit)
Sep 24, 2025, 4:41:36 PM (13 days ago) Sep 24
to Chromium LUCI CQ, Thomas Anderson, chromium...@chromium.org, max+watc...@igalia.com, nickdiego+wa...@igalia.com, ozone-...@chromium.org
Attention needed from Thomas Anderson
Kramer Ge voted Auto-Submit+1![]( "Open in Gerrit")
| Auto-Submit | +1 |
Related details
Attention is currently required from:
- Thomas Anderson
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Kramer Ge (Gerrit)
Sep 24, 2025, 5:28:45 PM (13 days ago) Sep 24
to Chromium LUCI CQ, Thomas Anderson, chromium...@chromium.org, max+watc...@igalia.com, nickdiego+wa...@igalia.com, ozone-...@chromium.org
Attention needed from Thomas Anderson
Kramer Ge voted Auto-Submit+0![]( "Open in Gerrit")
| Auto-Submit | +0 |
Related details
Attention is currently required from:
- Thomas Anderson
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Thomas Anderson (Gerrit)
Sep 24, 2025, 5:49:49 PM (13 days ago) Sep 24
to Kramer Ge, Chromium LUCI CQ, chromium...@chromium.org, max+watc...@igalia.com, nickdiego+wa...@igalia.com, ozone-...@chromium.org
Attention needed from Kramer Ge
Thomas Anderson voted Code-Review+1![]( "Open in Gerrit")
Attention is currently required from:
- Kramer Ge
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Kramer Ge (Gerrit)
Sep 24, 2025, 7:17:44 PM (13 days ago) Sep 24
to Thomas Anderson, Chromium LUCI CQ, chromium...@chromium.org, max+watc...@igalia.com, nickdiego+wa...@igalia.com, ozone-...@chromium.org
Kramer Ge voted Commit-Queue+2![]( "Open in Gerrit")
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Chromium LUCI CQ (Gerrit)
Sep 24, 2025, 10:20:52 PM (13 days ago) Sep 24
to Kramer Ge, Thomas Anderson, chromium...@chromium.org, max+watc...@igalia.com, nickdiego+wa...@igalia.com, ozone-...@chromium.org
Chromium LUCI CQ submitted the change![]( "Open in Gerrit")
Change information
Commit message:
[Ozone/Wayland]Remove idle_inhibitor_ object from WaylandScreen
..to prevent UAF on chrome shutdown. Unlike most objects created by
WaylandConnection, WaylandScreen is owned by ChromeBrowserMainExtraParts
and outlives WaylandConnection.
To prevent accessing wl_display internals after destruction of
WaylandConnection, WaylandScreen should either destroy wl::Object when
connection resets, or reference wl::Object indirectly.
Manage inhibitor in zwp_idle_inhibit_manager. Also fix a logic in
IsScreenSaverActive() where `inhibitor` mean screen saver is blocked.
Bug: 433027577, 433643249
Change-Id: If02755ddced08f8cf795ac21ed144387d0aa4077
Commit-Queue: Kramer Ge <fang...@chromium.org>
Reviewed-by: Thomas Anderson <thomasa...@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1520174}
Files:
- M ui/ozone/platform/wayland/host/wayland_screen.cc
- M ui/ozone/platform/wayland/host/wayland_screen.h
- M ui/ozone/platform/wayland/host/zwp_idle_inhibit_manager.cc
- M ui/ozone/platform/wayland/host/zwp_idle_inhibit_manager.h
Change size: M
Delta: 4 files changed, 50 insertions(+), 30 deletions(-)
Branch: refs/heads/main
Submit Requirements:
Code-Review: +1 by Thomas Anderson
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Reply all
Reply to author
Forward
0 new messages