//ui: Make SurfaceFactoryOzone::CreateNativePixmap(BufferFormat) private [chromium/src : main]

0 views

Skip to first unread message

Vasiliy Telezhnikov (Gerrit)

unread,

Oct 31, 2025, 8:34:18 AM (6 days ago) Oct 31

to Colin Blundell, AyeAye, Chromium LUCI CQ, chromium...@chromium.org, David Worsham, Robert Kroeger, emi...@google.com, fuchsia...@chromium.org, headless...@chromium.org, max+watc...@igalia.com, nickdiego+wa...@igalia.com, ozone-...@chromium.org, spang...@chromium.org

Attention needed from Colin Blundell

Vasiliy Telezhnikov voted and added 1 comment

Votes added by Vasiliy Telezhnikov

Code-Review

1 comment

Patchset-level comments

File-level comment, Patchset 1 (Latest):

Vasiliy Telezhnikov . resolved

lgtm, thanks.

Open in Gerrit

Related details

Attention is currently required from:

Colin Blundell

Submit Requirements:

Code-Coverage
Code-Owners
Code-Review
Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

satisfied_requirement

open

diffy

Chromium LUCI CQ (Gerrit)

unread,

Nov 3, 2025, 3:47:27 AM (3 days ago) Nov 3

to Colin Blundell, Vasiliy Telezhnikov, AyeAye, chromium...@chromium.org, David Worsham, Robert Kroeger, emi...@google.com, fuchsia...@chromium.org, headless...@chromium.org, max+watc...@igalia.com, nickdiego+wa...@igalia.com, ozone-...@chromium.org, spang...@chromium.org

Chromium LUCI CQ submitted the change

Change information

Commit message:

//ui: Make SurfaceFactoryOzone::CreateNativePixmap(BufferFormat) private

This method now has no callers other than the wrapper
CreateNativePixmap(SharedImageFormat). Make it private to eliminate any
regressions while we unwind this wrapping.

Bug: 450325664

Change-Id: Ie25aa5a8d8dfeb4f6140a776e398182c508b1b61

Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/7105378

Reviewed-by: Vasiliy Telezhnikov <vas...@chromium.org>

Commit-Queue: Colin Blundell <blun...@chromium.org>

Cr-Commit-Position: refs/heads/main@{#1539210}

Files:

M ui/ozone/platform/drm/gpu/gbm_surface_factory.h
M ui/ozone/platform/flatland/flatland_surface_factory.h
M ui/ozone/platform/headless/headless_surface_factory.h
M ui/ozone/platform/wayland/gpu/wayland_surface_factory.h
M ui/ozone/platform/x11/x11_surface_factory.h
M ui/ozone/public/surface_factory_ozone.h

Change size: M

Delta: 6 files changed, 42 insertions(+), 37 deletions(-)

Branch: refs/heads/main

Submit Requirements:

Code-Review: +1 by Vasiliy Telezhnikov

Open in Gerrit

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

open

diffy

satisfied_requirement

Reply all

Reply to author

Forward

0 new messages