[Viz] Move shared_image_format target to its own BUILD.gn file [chromium/src : main]
0 views
Skip to first unread message
Colin Blundell (Gerrit)
Sep 30, 2025, 8:42:03 AM (7 days ago) Sep 30
to Colin Blundell, Vasiliy Telezhnikov, Antonio Sartori, Kentaro Hara, Chromium LUCI CQ, chromium...@chromium.org, blink-...@chromium.org, cc-...@chromium.org, chromeos-gfx-...@google.com, feature-me...@chromium.org, kinuko...@chromium.org, mac-r...@chromium.org, max+watc...@igalia.com, media-cro...@chromium.org, nickdiego+wa...@igalia.com, oshima...@chromium.org, ozone-...@chromium.org, vaapi-...@chromium.org
Attention needed from Antonio Sartori, Kentaro Hara and Vasiliy Telezhnikov
Colin Blundell added 1 comment![]( "Open in Gerrit")
Patchset-level comments
File-level comment, Patchset 2 (Latest):
Colin Blundell . resolved
Vasiliy: for the CL as a whole
Antonio: for //gpu/ipc/common/BUILD.gn
Kentaro: for //third_party/blink/renderer/platform/BUILD.gn
Thanks!
Related details
Attention is currently required from:
- Antonio Sartori
- Kentaro Hara
- Vasiliy Telezhnikov
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Kentaro Hara (Gerrit)
Sep 30, 2025, 8:43:42 AM (7 days ago) Sep 30
to Colin Blundell, Vasiliy Telezhnikov, Antonio Sartori, Chromium LUCI CQ, chromium...@chromium.org, blink-...@chromium.org, cc-...@chromium.org, chromeos-gfx-...@google.com, feature-me...@chromium.org, kinuko...@chromium.org, mac-r...@chromium.org, max+watc...@igalia.com, media-cro...@chromium.org, nickdiego+wa...@igalia.com, oshima...@chromium.org, ozone-...@chromium.org, vaapi-...@chromium.org
Attention needed from Antonio Sartori, Colin Blundell and Vasiliy Telezhnikov
Kentaro Hara voted and added 1 comment![]( "Open in Gerrit")
Votes added by Kentaro Hara
| Code-Review | +1 |
1 comment
Patchset-level comments
Attention is currently required from:
- Antonio Sartori
- Colin Blundell
- Vasiliy Telezhnikov
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Antonio Sartori (Gerrit)
Sep 30, 2025, 11:27:14 AM (7 days ago) Sep 30
to Colin Blundell, Kentaro Hara, Vasiliy Telezhnikov, Chromium LUCI CQ, chromium...@chromium.org, blink-...@chromium.org, cc-...@chromium.org, chromeos-gfx-...@google.com, feature-me...@chromium.org, kinuko...@chromium.org, mac-r...@chromium.org, max+watc...@igalia.com, media-cro...@chromium.org, nickdiego+wa...@igalia.com, oshima...@chromium.org, ozone-...@chromium.org, vaapi-...@chromium.org
Attention needed from Colin Blundell and Vasiliy Telezhnikov
Antonio Sartori voted Code-Review+1![]( "Open in Gerrit")
Attention is currently required from:
- Colin Blundell
- Vasiliy Telezhnikov
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Vasiliy Telezhnikov (Gerrit)
Sep 30, 2025, 1:10:24 PM (7 days ago) Sep 30
to Colin Blundell, Antonio Sartori, Kentaro Hara, Chromium LUCI CQ, chromium...@chromium.org, blink-...@chromium.org, cc-...@chromium.org, chromeos-gfx-...@google.com, feature-me...@chromium.org, kinuko...@chromium.org, mac-r...@chromium.org, max+watc...@igalia.com, media-cro...@chromium.org, nickdiego+wa...@igalia.com, oshima...@chromium.org, ozone-...@chromium.org, vaapi-...@chromium.org
Attention needed from Colin Blundell
Vasiliy Telezhnikov voted and added 1 comment![]( "Open in Gerrit")
Related details
Attention is currently required from:
- Colin Blundell
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Chromium LUCI CQ (Gerrit)
Oct 1, 2025, 3:00:37 AM (6 days ago) Oct 1
to Colin Blundell, Vasiliy Telezhnikov, Antonio Sartori, Kentaro Hara, chromium...@chromium.org, blink-...@chromium.org, cc-...@chromium.org, chromeos-gfx-...@google.com, feature-me...@chromium.org, kinuko...@chromium.org, mac-r...@chromium.org, max+watc...@igalia.com, media-cro...@chromium.org, nickdiego+wa...@igalia.com, oshima...@chromium.org, ozone-...@chromium.org, vaapi-...@chromium.org
Chromium LUCI CQ submitted the change![]( "Open in Gerrit")
Change information
Commit message:
[Viz] Move shared_image_format target to its own BUILD.gn file
Facilitates an upcoming change that will have //ui/gfx::color_space
depend on SharedImageFormat. //ui/gfx::color_space cannot reference
//components/viz/common/BUILD.gn as //ui/gfx/BUILD.gn is used on iOS
and reading //componetns/viz/common/BUILD.gn transitively results in
reading in Blink BUILD.gn files that trip on assert(use_blink) on iOS.
Bug: 445879532
Change-Id: I901d9d73a5c675c62dab7d412df47c5373ee857e
Reviewed-by: Kentaro Hara <har...@chromium.org>
Reviewed-by: Antonio Sartori <antonio...@chromium.org>
Reviewed-by: Vasiliy Telezhnikov <vas...@chromium.org>
Commit-Queue: Colin Blundell <blun...@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1523347}
Files:
- M components/chromeos_camera/BUILD.gn
- M components/viz/common/BUILD.gn
- A components/viz/common/resources/BUILD.gn
- M gpu/BUILD.gn
- M gpu/command_buffer/client/BUILD.gn
- M gpu/command_buffer/common/BUILD.gn
- M gpu/command_buffer/service/BUILD.gn
- M gpu/ipc/client/BUILD.gn
- M gpu/ipc/common/BUILD.gn
- M gpu/ipc/service/BUILD.gn
- M media/gpu/chromeos/BUILD.gn
- M media/gpu/mac/BUILD.gn
- M media/gpu/vaapi/BUILD.gn
- M services/viz/public/mojom/BUILD.gn
- M third_party/blink/renderer/platform/BUILD.gn
- M ui/gfx/BUILD.gn
- M ui/gfx/linux/BUILD.gn
- M ui/ozone/BUILD.gn
- M ui/ozone/demo/BUILD.gn
- M ui/ozone/platform/drm/BUILD.gn
- M ui/ozone/platform/wayland/BUILD.gn
Change size: M
Delta: 21 files changed, 62 insertions(+), 56 deletions(-)
Branch: refs/heads/main
Submit Requirements:
Code-Review: +1 by Antonio Sartori, +1 by Vasiliy Telezhnikov, +1 by Kentaro Hara
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Reply all
Reply to author
Forward
0 new messages