support NUL with ^@ [chromium/src : main]

0 views

Skip to first unread message

Hyomin Kim (Gerrit)

unread,

Sep 21, 2023, 4:12:28 AMSep 21

to ozone-...@chromium.org

Attention is currently required from: Hyomin Kim, Robert Kroeger.

Hyomin Kim uploaded patch set #4 to this change.

View Change

support NUL with ^@


Return printable character when Ctrl+2 is pressed

When Ctrl+2 is pressed, the return value from XKB is 0,
referring to [0]. So condition [1] has to be skipped
in this case. In order to get [2] to return the printable
character.

[0]
https://github.com/xkbcommon/libxkbcommon/blob/master/src/state.c#L899

[1]
https://source.chromium.org/chromium/chromium/src/+/main:ui/events/ozone/layout/xkb/xkb_keyboard_layout_engine.cc;l=824

[2]
https://source.chromium.org/chromium/chromium/src/+/main:ui/events/ozone/layout/xkb/xkb_keyboard_layout_engine.cc;l=837

Bug: 1410732

Change-Id: I5385ec8d64ad1da27571c4b6f02911e6e27e46f8
---
M ui/events/ozone/layout/xkb/xkb_keyboard_layout_engine.cc
1 file changed, 1 insertion(+), 1 deletion(-)

To view, visit change 4721787. To unsubscribe, or for help writing mail filters, visit settings.

Reply all

Reply to author

Forward

0 new messages