[Ozone/Wayland]gbm_pixmap_wayland fallback to implicit modifier [chromium/src : main]
0 views
Skip to first unread message
Peter McNeeley (Gerrit)
Sep 24, 2025, 5:01:57 PM (13 days ago) Sep 24
to Kramer Ge, Chromium LUCI CQ, chromium...@chromium.org, max+watc...@igalia.com, nickdiego+wa...@igalia.com, ozone-...@chromium.org
Attention needed from Kramer Ge
Peter McNeeley added 1 comment![]( "Open in Gerrit")
File ui/ozone/platform/wayland/gpu/gbm_pixmap_wayland.cc
Related details
Attention is currently required from:
- Kramer Ge
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
No-Unresolved-Comments
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Kramer Ge (Gerrit)
Sep 24, 2025, 5:27:00 PM (13 days ago) Sep 24
to Chromium LUCI CQ, Peter McNeeley, chromium...@chromium.org, max+watc...@igalia.com, nickdiego+wa...@igalia.com, ozone-...@chromium.org
Attention needed from Peter McNeeley
Kramer Ge voted and added 1 comment![]( "Open in Gerrit")
Votes added by Kramer Ge
| Commit-Queue | +1 |
1 comment
File ui/ozone/platform/wayland/gpu/gbm_pixmap_wayland.cc
Line 80, Patchset 1:
if (!gbm_bo_ &&Peter McNeeley . resolved
Comment on fallback as to why?
Attention is currently required from:
- Peter McNeeley
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Peter McNeeley (Gerrit)
Sep 26, 2025, 2:11:43 PM (11 days ago) Sep 26
to Kramer Ge, Chromium LUCI CQ, chromium...@chromium.org, max+watc...@igalia.com, nickdiego+wa...@igalia.com, ozone-...@chromium.org
Attention needed from Kramer Ge
Peter McNeeley added 1 comment![]( "Open in Gerrit")
Attention is currently required from:
- Kramer Ge
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Peter McNeeley (Gerrit)
Sep 26, 2025, 2:12:36 PM (11 days ago) Sep 26
to Kramer Ge, Chromium LUCI CQ, chromium...@chromium.org, max+watc...@igalia.com, nickdiego+wa...@igalia.com, ozone-...@chromium.org
Attention needed from Kramer Ge
Peter McNeeley added 1 comment![]( "Open in Gerrit")
File ui/ozone/platform/wayland/host/wayland_zwp_linux_dmabuf.cc
Line 167, Patchset 7 (Latest):
std::vector<uint64_t> modifiers;Peter McNeeley . resolved
all this code and naming is a bit ugly. I understand why it looks this way because vector vs single value.
Related details
Attention is currently required from:
- Kramer Ge
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Peter McNeeley (Gerrit)
Sep 26, 2025, 2:26:12 PM (11 days ago) Sep 26
to Kramer Ge, Chromium LUCI CQ, chromium...@chromium.org, max+watc...@igalia.com, nickdiego+wa...@igalia.com, ozone-...@chromium.org
Attention needed from Kramer Ge
Peter McNeeley voted Code-Review+1![]( "Open in Gerrit")
| Code-Review | +1 |
Related details
Attention is currently required from:
- Kramer Ge
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Kramer Ge (Gerrit)
Sep 26, 2025, 2:47:58 PM (11 days ago) Sep 26
to Peter McNeeley, Chromium LUCI CQ, chromium...@chromium.org, max+watc...@igalia.com, nickdiego+wa...@igalia.com, ozone-...@chromium.org
Kramer Ge voted Commit-Queue+2![]( "Open in Gerrit")
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Chromium LUCI CQ (Gerrit)
Sep 26, 2025, 3:57:30 PM (11 days ago) Sep 26
to Kramer Ge, Peter McNeeley, chromium...@chromium.org, max+watc...@igalia.com, nickdiego+wa...@igalia.com, ozone-...@chromium.org
Chromium LUCI CQ submitted the change![]( "Open in Gerrit")
Change information
Commit message:
[Ozone/Wayland]gbm_pixmap_wayland fallback to implicit modifier
linux_dmabuf extension specifies that DRM_FORMAT_MOD_INVALID is allowed
for server to indicate support for implicit modifier.
wlroots-based compositor such as sway appears to always announce
MOD_INVALID and MOD_LINEAR. However, in reality some hardware driver
does not render to MOD_LINEAR, so we need to perform this fallback. As
long as the device selection matches the compositor, driver should know
about the modifiers internally.
Add MOD_INVALID to the list to indicate implicit modifier support.
Bug: 446395287
Change-Id: I3b9b9e66c17b3968213007d5e1643b59a6987052
Commit-Queue: Kramer Ge <fang...@chromium.org>
Reviewed-by: Peter McNeeley <peterm...@google.com>
Cr-Commit-Position: refs/heads/main@{#1521503}
Files:
- M ui/ozone/platform/wayland/gpu/gbm_pixmap_wayland.cc
- M ui/ozone/platform/wayland/gpu/wayland_buffer_manager_gpu.cc
- M ui/ozone/platform/wayland/gpu/wayland_buffer_manager_gpu.h
- M ui/ozone/platform/wayland/host/wayland_zwp_linux_dmabuf.cc
- M ui/ozone/platform/wayland/wayland_buffer_manager_unittest.cc
Change size: M
Delta: 5 files changed, 54 insertions(+), 30 deletions(-)
Branch: refs/heads/main
Submit Requirements:
Code-Review: +1 by Peter McNeeley
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Reply all
Reply to author
Forward
0 new messages