[Dev branch] android: Keep rgb565 back buffer for <= 512MB devices [chromium/src : refs/branch-heads/7377]

0 views
Skip to first unread message

Krishna Govind (Gerrit)

unread,
Aug 27, 2025, 1:20:58 PM (11 days ago) Aug 27
to Bo Liu, Rubber Stamper, AyeAye, cc-...@chromium.org, penghu...@chromium.org, ozone-...@chromium.org

Krishna Govind voted

Code-Review+1
Owners-Override+1
Open in Gerrit

Related details

Attention set is empty
Submit Requirements:
  • requirement satisfiedCode-Owners
  • requirement is not satisfiedCode-Review
  • requirement satisfiedLint
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: refs/branch-heads/7377
Gerrit-Change-Id: Ia257ed04c8d2667954a4f5cb9a8b1b23ec0e3367
Gerrit-Change-Number: 6892134
Gerrit-PatchSet: 1
Gerrit-Owner: Krishna Govind <gov...@chromium.org>
Gerrit-Reviewer: Krishna Govind <gov...@chromium.org>
Gerrit-Reviewer: Rubber Stamper <rubber-...@appspot.gserviceaccount.com>
Gerrit-CC: Bo Liu <bo...@chromium.org>
Gerrit-Comment-Date: Wed, 27 Aug 2025 17:20:44 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
satisfied_requirement
unsatisfied_requirement
open
diffy

Rubber Stamper (Gerrit)

unread,
Aug 27, 2025, 1:21:21 PM (11 days ago) Aug 27
to Krishna Govind, Bo Liu, AyeAye, cc-...@chromium.org, penghu...@chromium.org, ozone-...@chromium.org

Rubber Stamper voted Bot-Commit+1

Bot-Commit+1
Open in Gerrit

Related details

Attention set is empty
Submit Requirements:
  • requirement satisfiedCode-Owners
  • requirement satisfiedCode-Review
  • requirement satisfiedLint
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: refs/branch-heads/7377
Gerrit-Change-Id: Ia257ed04c8d2667954a4f5cb9a8b1b23ec0e3367
Gerrit-Change-Number: 6892134
Gerrit-PatchSet: 1
Gerrit-Owner: Krishna Govind <gov...@chromium.org>
Gerrit-Reviewer: Krishna Govind <gov...@chromium.org>
Gerrit-Reviewer: Rubber Stamper <rubber-...@appspot.gserviceaccount.com>
Gerrit-CC: Bo Liu <bo...@chromium.org>
Gerrit-Comment-Date: Wed, 27 Aug 2025 17:21:06 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
satisfied_requirement
open
diffy

Krishna Govind (Gerrit)

unread,
Aug 27, 2025, 1:28:22 PM (11 days ago) Aug 27
to Bo Liu, Rubber Stamper, AyeAye, cc-...@chromium.org, penghu...@chromium.org, ozone-...@chromium.org

Krishna Govind submitted the change

Change information

Commit message:
[Dev branch] android: Keep rgb565 back buffer for <= 512MB devices

Apparently there's at least one device that isn't happy when 565 texture
is enabled.

This effectively reverts the condition for rgb565 from these two CLs:
https://chromium-review.googlesource.com/c/chromium/src/+/6862280
https://chromium-review.googlesource.com/c/chromium/src/+/6824090

(cherry picked from commit 1ce1fa5fac2f4fa96b47ee892635561fce1b3d81)
Bug: 439049202
Change-Id: Ia257ed04c8d2667954a4f5cb9a8b1b23ec0e3367
Reviewed-by: Matthew Jones <mdj...@chromium.org>
Reviewed-by: Vasiliy Telezhnikov <vas...@chromium.org>
Commit-Queue: Bo Liu <bo...@chromium.org>
Reviewed-by: Sunny Sachanandani <sun...@chromium.org>
Cr-Original-Commit-Position: refs/heads/main@{#1506516}
Reviewed-by: Krishna Govind <gov...@chromium.org>
Bot-Commit: Rubber Stamper <rubber-...@appspot.gserviceaccount.com>
Owners-Override: Krishna Govind <gov...@chromium.org>
Cr-Commit-Position: refs/branch-heads/7377@{#9}
Cr-Branched-From: 16320b7a582a9b3cf3efd220570aea656a094ee8-refs/heads/main@{#1506453}
Files:
  • M chrome/android/java/src/org/chromium/chrome/browser/compositor/CompositorView.java
  • M chrome/android/java/src/org/chromium/chrome/browser/compositor/CompositorViewHolder.java
  • M chrome/browser/android/compositor/compositor_view.cc
  • M components/viz/common/viz_utils.cc
  • M components/viz/common/viz_utils.h
  • M components/viz/service/display_embedder/skia_output_surface_impl_on_gpu.cc
  • M ui/gl/gl_surface_egl.cc
Change size: S
Delta: 7 files changed, 25 insertions(+), 18 deletions(-)
Branch: refs/branch-heads/7377
Submit Requirements:
  • requirement satisfiedCode-Review: +1 by Krishna Govind, Bot-Commit+1 by Rubber Stamper
Open in Gerrit
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: merged
Gerrit-Project: chromium/src
Gerrit-Branch: refs/branch-heads/7377
Gerrit-Change-Id: Ia257ed04c8d2667954a4f5cb9a8b1b23ec0e3367
Gerrit-Change-Number: 6892134
Gerrit-PatchSet: 2
open
diffy
satisfied_requirement
Reply all
Reply to author
Forward
0 new messages