Parse multiple URLs from text/uri-list drag data [chromium/src : main]

0 views

Skip to first unread message

Joone Hur (Gerrit)

unread,

Oct 29, 2025, 2:37:35 AM (8 days ago) Oct 29

to Sylvain Defresne, Avi Drissman, Min Qin, Rakina Zata Amni, Daniel Cheng, Sadrul Chowdhury, AyeAye, Chromium LUCI CQ, chromium...@chromium.org, ajwong...@chromium.org, omnibox-...@chromium.org, blink-revie...@chromium.org, blink-...@chromium.org, ozone-...@chromium.org, max+watc...@igalia.com, kinuko+...@chromium.org, nickdiego+wa...@igalia.com, mac-r...@chromium.org, alexmo...@chromium.org, creis...@chromium.org, dcheng+c...@chromium.org, jdonnel...@chromium.org, mahmad...@chromium.org, navigation...@chromium.org, roblia...@chromium.org, sky+...@chromium.org

Attention needed from Daniel Cheng, Min Qin and Sylvain Defresne

Joone Hur added 1 comment

Patchset-level comments

File-level comment, Patchset 87:

Daniel Cheng . unresolved

Please rebase this CL now that the others have landed. That should make this much smaller more reviewable.
The biggest issue that remains to resolve is how exactly to serialize and deserialize a list of urls and titles to/from IDataObject. As I noted in a previous comment, the current serialization doesn't handle the case of embedded `\n` in titles gracefully. Whatever we write should handle that case (and other edge cases) gracefully. I'm not sure if there is a standard convention for serializing structured data to `IDataObject` on Windows; if there is, we should use it. Worst-case scenario, we can use `base::Pickle` though I don't love falling back to that as it's fairly Chrome-specific.

Joone Hur

How about we use JSON for the `Bookmark List` clipboard format? This will correctly handle any special characters in the titles, like newlines, and isn't Chrome-specific.

We can serialize the `std::vector<ClipboardUrlInfo>` into a JSON string and write that to the clipboard as `Bookmark List` format. On the reading side, the JSON can be parsed back into the vector.

Open in Gerrit

Related details

Attention is currently required from:

Daniel Cheng
Min Qin
Sylvain Defresne

Submit Requirements:

Code-Coverage
Code-Owners
Code-Review
No-Unresolved-Comments
Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

satisfied_requirement

unsatisfied_requirement

open

diffy

Daniel Cheng (Gerrit)

unread,

Nov 5, 2025, 6:24:37 PM (14 hours ago) Nov 5

to Joone Hur, Dana Fried, Daniel Cheng, Sylvain Defresne, Avi Drissman, Min Qin, Rakina Zata Amni, Sadrul Chowdhury, AyeAye, Chromium LUCI CQ, chromium...@chromium.org, ajwong...@chromium.org, omnibox-...@chromium.org, blink-revie...@chromium.org, blink-...@chromium.org, ozone-...@chromium.org, max+watc...@igalia.com, kinuko+...@chromium.org, nickdiego+wa...@igalia.com, mac-r...@chromium.org, alexmo...@chromium.org, creis...@chromium.org, dcheng+c...@chromium.org, jdonnel...@chromium.org, mahmad...@chromium.org, navigation...@chromium.org, roblia...@chromium.org, sky+...@chromium.org

Attention needed from Dana Fried, Min Qin and Sylvain Defresne

Daniel Cheng added 1 comment

Patchset-level comments

File-level comment, Patchset 89 (Latest):

Daniel Cheng . resolved

I'm planning on removing myself from clipboard and drag and drop OWNERS. While I have a lot of historical context, I think someone on the desktop team ultimately needs to be involved here.

@dfr...@chromium.org, do you mind helping take over this review for the Windows perspective? Thanks!