Thomas Anderson (Gerrit)

unread,

May 5, 2026, 5:11:56 PMMay 5

to Kramer Ge, chromium...@chromium.org, max+watc...@igalia.com, nickdiego+wa...@igalia.com, ozone-...@chromium.org

Attention needed from Kramer Ge

Thomas Anderson voted

Auto-Submit	+1
Commit-Queue	+1

Open in Gerrit

Related details

Attention is currently required from:

Kramer Ge

Submit Requirements:

Code-Coverage
Code-Owners
Code-Review
Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

satisfied_requirement

unsatisfied_requirement

open

diffy

Kramer Ge (Gerrit)

unread,

May 6, 2026, 11:13:01 AMMay 6

to Thomas Anderson, Chromium LUCI CQ, chromium...@chromium.org, max+watc...@igalia.com, nickdiego+wa...@igalia.com, ozone-...@chromium.org

Attention needed from Thomas Anderson

Kramer Ge voted

Code-Review	+1
Commit-Queue	+2

Open in Gerrit

Related details

Attention is currently required from:

Thomas Anderson

Submit Requirements:

Code-Coverage
Code-Owners
Code-Review
Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

satisfied_requirement

open

diffy

Chromium LUCI CQ (Gerrit)

unread,

May 6, 2026, 11:16:23 AMMay 6

to Thomas Anderson, Kramer Ge, chromium...@chromium.org, max+watc...@igalia.com, nickdiego+wa...@igalia.com, ozone-...@chromium.org

Chromium LUCI CQ submitted the change

Change information

Commit message:

Optimize GbmSurfaceless frame management and fix FenceRetired crash.

This CL fixes a dangling pointer crash in GbmSurfacelessWayland and
GbmSurfaceless (DRM) by using per-surface monotonic frame sequence IDs
instead of raw pointers in callbacks.

Additionally, it optimizes frame management by:
1. Replacing std::vector with base::circular_deque for frame tracking
   to enable O(1) removals from the front of the queue.
2. Implementing O(1) lookup in FenceRetired using index math and
   contiguous frame IDs, replacing the previous linear search.

R=fangzhoug

Fixed: 509443046

Change-Id: I087121c494aaccbf526da29e07c59a81313c3136

Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/7818727

Reviewed-by: Kramer Ge <fang...@chromium.org>

Commit-Queue: Kramer Ge <fang...@chromium.org>

Auto-Submit: Thomas Anderson <thomasa...@chromium.org>

Cr-Commit-Position: refs/heads/main@{#1626193}

Files:

M ui/ozone/platform/drm/gpu/gbm_surfaceless.cc
M ui/ozone/platform/drm/gpu/gbm_surfaceless.h
M ui/ozone/platform/wayland/gpu/gbm_surfaceless_wayland.cc
M ui/ozone/platform/wayland/gpu/gbm_surfaceless_wayland.h

Change size: M

Delta: 4 files changed, 76 insertions(+), 24 deletions(-)

Branch: refs/heads/main

Submit Requirements:

Code-Review: +1 by Kramer Ge

Open in Gerrit

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

open

diffy

satisfied_requirement

Reply all

Reply to author

Forward

Optimize GbmSurfaceless frame management and fix FenceRetired crash. [chromium/src : main]

Thomas Anderson (Gerrit)

Thomas Anderson voted

Related details

Kramer Ge (Gerrit)

Kramer Ge voted

Related details

Chromium LUCI CQ (Gerrit)

Chromium LUCI CQ submitted the change

Change information