ui/gfx/x: Peek X11 responses in GeometryCache::GetBoundsPx() [chromium/src : main]

0 views

Skip to first unread message

Thomas Anderson (Gerrit)

unread,

Jul 20, 2026, 9:18:08 PM (3 days ago) Jul 20

to Lei Zhang, chromium...@chromium.org, ozone-...@chromium.org

Attention needed from Lei Zhang

Thomas Anderson voted Commit-Queue+1

Commit-Queue

Open in Gerrit

Related details

Attention is currently required from:

Lei Zhang

Submit Requirements:

Code-Coverage
Code-Owners
Code-Review
Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

satisfied_requirement

unsatisfied_requirement

open

diffy

Lei Zhang (Gerrit)

unread,

Jul 20, 2026, 9:38:44 PM (3 days ago) Jul 20

to Thomas Anderson, Chromium LUCI CQ, Lei Zhang, chromium...@chromium.org, ozone-...@chromium.org

Attention needed from Thomas Anderson

Lei Zhang added 8 comments

Commit Message

Line 7, Patchset 2 (Latest):ui/gfx/x: Peek X11 responses in GeometryCache::GetBoundsPx()

Lei Zhang . unresolved

"Peek at" ?

File ui/gfx/x/future.h

Line 139, Patchset 2 (Latest): ReadBuffer buf(raw_reply);

Lei Zhang . unresolved

Make line 119 consistent along the way?

Line 126, Patchset 2 (Latest): // Blocks until we receive the response from the server. Returns the response

Lei Zhang . unresolved

go/avoid-we

Line 31, Patchset 2 (Latest): void Peek(RawReply* raw_reply, std::unique_ptr<Error>* error);

Lei Zhang . unresolved

Document how this is different from Sync().

File ui/gfx/x/future.cc

Line 41, Patchset 2 (Latest): DCHECK_CALLED_ON_VALID_SEQUENCE(connection_->sequence_checker_);

Lei Zhang . unresolved

Do this first?

File ui/gfx/x/geometry_cache.cc

Line 37, Patchset 2 (Latest): gfx::Rect geometry = geometry_;

Lei Zhang . unresolved

Should not assign since line 39 does it.

Line 46, Patchset 2 (Latest): if (!have_parent_) {

Lei Zhang . unresolved

The pre-existing code did this check first. Is this flipped around on purpose?

Line 60, Patchset 2 (Latest): return geometry;

Lei Zhang . unresolved

Flip conditional on line 47 and return early?

Open in Gerrit

Related details

Attention is currently required from:

Thomas Anderson

Submit Requirements:

Code-Coverage
Code-Owners
Code-Review

No-Unresolved-Comments

Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

satisfied_requirement

unsatisfied_requirement

open

diffy

Reply all

Reply to author

Forward

0 new messages