ozone/drm: Propagate drm master drop result [chromium/src : main]
0 views
Skip to first unread message
Su Hong Koo (Gerrit)
Sep 25, 2025, 2:15:32 PM (12 days ago) Sep 25
to Gil Dekel, chromium...@chromium.org, ozone-...@chromium.org
Attention needed from Gil Dekel
New activity on the change![]( "Open in Gerrit")
Related details
Attention is currently required from:
- Gil Dekel
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Gil Dekel (Gerrit)
Sep 26, 2025, 4:44:54 PM (11 days ago) Sep 26
to Su Hong Koo, chromium...@chromium.org, ozone-...@chromium.org
Attention needed from Su Hong Koo
Gil Dekel voted Code-Review+1![]( "Open in Gerrit")
Attention is currently required from:
- Su Hong Koo
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Su Hong Koo (Gerrit)
Sep 26, 2025, 4:45:11 PM (11 days ago) Sep 26
to Gil Dekel, chromium...@chromium.org, ozone-...@chromium.org
Su Hong Koo voted Commit-Queue+2![]( "Open in Gerrit")
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Chromium LUCI CQ (Gerrit)
Sep 26, 2025, 5:20:42 PM (11 days ago) Sep 26
to Su Hong Koo, Gil Dekel, chromium...@chromium.org, ozone-...@chromium.org
Chromium LUCI CQ submitted the change![]( "Open in Gerrit")
Change information
Commit message:
ozone/drm: Propagate drm master drop result
For some reason, DrmGpuDisplayManager::RelinquishDisplayControl() does
not return any indication of success (unlike TakeDisplayControl() which
returns a bool). DrmThread just assumes the operation always succeeds
and returns a true for the success arg when invoking the callback.
Routine calls to drop master can fail, so the callback should be made
aware of the actual status of the call. There's already logic in
DisplayConfigurator to handle failure, and propagating this failure
will let the client know of the failure and let them retry (vs right
now where DisplayConfigurator thinks it doesn't have the master and
doesn't even try to drop it).
Bug: b:447219059
Test: New DrmGpuDisplayManager test
Change-Id: I911628fec558b81d43cf65b0e9fe33d6bb513ba5
Reviewed-by: Gil Dekel <gild...@chromium.org>
Commit-Queue: Su Hong Koo <su...@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1521564}
Files:
- M ui/ozone/platform/drm/gpu/drm_gpu_display_manager.cc
- M ui/ozone/platform/drm/gpu/drm_gpu_display_manager.h
- M ui/ozone/platform/drm/gpu/drm_gpu_display_manager_unittest.cc
- M ui/ozone/platform/drm/gpu/drm_thread.cc
- M ui/ozone/platform/drm/gpu/fake_drm_device.cc
- M ui/ozone/platform/drm/gpu/fake_drm_device.h
Change size: M
Delta: 6 files changed, 56 insertions(+), 10 deletions(-)
Branch: refs/heads/main
Submit Requirements:
Code-Review: +1 by Gil Dekel
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Reply all
Reply to author
Forward
0 new messages