[Testing, Linux] Verbose ui_controls error message with instructions [chromium/src : main]

1 view
Skip to first unread message

Dana Fried (Gerrit)

unread,
Jul 31, 2026, 1:11:52 PM (13 days ago) Jul 31
to Thomas Anderson, chromium...@chromium.org, max+watc...@igalia.com, nickdiego+wa...@igalia.com, ozone-...@chromium.org
Attention needed from Thomas Anderson

Dana Fried voted Commit-Queue+1

Commit-Queue+1
Open in Gerrit

Related details

Attention is currently required from:
  • Thomas Anderson
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement is not satisfiedCode-Owners
  • requirement is not satisfiedCode-Review
  • requirement is not satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: I1755a7d86ad365b4bb67d52e7f575867860b3112
Gerrit-Change-Number: 8179205
Gerrit-PatchSet: 3
Gerrit-Owner: Dana Fried <dfr...@chromium.org>
Gerrit-Reviewer: Dana Fried <dfr...@chromium.org>
Gerrit-Reviewer: Thomas Anderson <thomasa...@chromium.org>
Gerrit-Attention: Thomas Anderson <thomasa...@chromium.org>
Gerrit-Comment-Date: Fri, 31 Jul 2026 17:11:41 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
satisfied_requirement
unsatisfied_requirement
open
diffy

Thomas Anderson (Gerrit)

unread,
Jul 31, 2026, 1:24:34 PM (13 days ago) Jul 31
to Dana Fried, Chromium LUCI CQ, chromium...@chromium.org, max+watc...@igalia.com, nickdiego+wa...@igalia.com, ozone-...@chromium.org
Attention needed from Dana Fried

Thomas Anderson voted and added 2 comments

Votes added by Thomas Anderson

Code-Review+1

2 comments

Patchset-level comments
File-level comment, Patchset 4 (Latest):
Thomas Anderson . resolved

lgtm

File ui/ozone/platform/wayland/emulate/wayland_input_emulate.cc
Line 44, Patchset 4 (Latest): * Run with 'testing/xvfb.py --use-mutter --no-xvfb [path to this executable]'
Thomas Anderson . resolved

optional: `--ozone-platform=wayland` (may not be necessary since it's the default now)

Open in Gerrit

Related details

Attention is currently required from:
  • Dana Fried
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement satisfiedCode-Owners
  • requirement satisfiedCode-Review
  • requirement satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: I1755a7d86ad365b4bb67d52e7f575867860b3112
Gerrit-Change-Number: 8179205
Gerrit-PatchSet: 4
Gerrit-Owner: Dana Fried <dfr...@chromium.org>
Gerrit-Reviewer: Dana Fried <dfr...@chromium.org>
Gerrit-Reviewer: Thomas Anderson <thomasa...@chromium.org>
Gerrit-Attention: Dana Fried <dfr...@chromium.org>
Gerrit-Comment-Date: Fri, 31 Jul 2026 17:24:22 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
satisfied_requirement
open
diffy

Dana Fried (Gerrit)

unread,
Aug 4, 2026, 9:03:04 AM (9 days ago) Aug 4
to Thomas Anderson, Chromium LUCI CQ, chromium...@chromium.org, max+watc...@igalia.com, nickdiego+wa...@igalia.com, ozone-...@chromium.org

Dana Fried voted and added 1 comment

Votes added by Dana Fried

Commit-Queue+2

1 comment

File ui/ozone/platform/wayland/emulate/wayland_input_emulate.cc
Line 44, Patchset 4 (Latest): * Run with 'testing/xvfb.py --use-mutter --no-xvfb [path to this executable]'
Thomas Anderson . resolved

optional: `--ozone-platform=wayland` (may not be necessary since it's the default now)

Dana Fried

This would only reproduce if the platform was already defaulting to wayland, so it's not necessary.

Open in Gerrit

Related details

Attention set is empty
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement satisfiedCode-Owners
  • requirement satisfiedCode-Review
  • requirement satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: I1755a7d86ad365b4bb67d52e7f575867860b3112
Gerrit-Change-Number: 8179205
Gerrit-PatchSet: 4
Gerrit-Owner: Dana Fried <dfr...@chromium.org>
Gerrit-Reviewer: Dana Fried <dfr...@chromium.org>
Gerrit-Reviewer: Thomas Anderson <thomasa...@chromium.org>
Gerrit-Comment-Date: Tue, 04 Aug 2026 13:02:51 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Comment-In-Reply-To: Thomas Anderson <thomasa...@chromium.org>
satisfied_requirement
open
diffy

Chromium LUCI CQ (Gerrit)

unread,
Aug 4, 2026, 10:20:39 AM (9 days ago) Aug 4
to Dana Fried, Thomas Anderson, chromium...@chromium.org, max+watc...@igalia.com, nickdiego+wa...@igalia.com, ozone-...@chromium.org

Chromium LUCI CQ submitted the change

Change information

Commit message:
[Testing, Linux] Verbose ui_controls error message with instructions

When e.g. interactive_ui_tests fail due to a wayland incompatibility -
typically on a Linux Cloudtop or other Linux device with Wayland -
print out a detailed error message that specifies how to either run the
test with X11 or with the "bundled Mutter" configuration and xvfb.
Fixed: 540047808
Change-Id: I1755a7d86ad365b4bb67d52e7f575867860b3112
Reviewed-by: Thomas Anderson <thomasa...@chromium.org>
Commit-Queue: Dana Fried <dfr...@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1673313}
Files:
  • M ui/ozone/platform/wayland/emulate/wayland_input_emulate.cc
Change size: S
Delta: 1 file changed, 16 insertions(+), 3 deletions(-)
Branch: refs/heads/main
Submit Requirements:
  • requirement satisfiedCode-Review: +1 by Thomas Anderson
Open in Gerrit
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: merged
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: I1755a7d86ad365b4bb67d52e7f575867860b3112
Gerrit-Change-Number: 8179205
Gerrit-PatchSet: 5
Gerrit-Owner: Dana Fried <dfr...@chromium.org>
Gerrit-Reviewer: Chromium LUCI CQ <chromiu...@luci-project-accounts.iam.gserviceaccount.com>
Gerrit-Reviewer: Dana Fried <dfr...@chromium.org>
Gerrit-Reviewer: Thomas Anderson <thomasa...@chromium.org>
open
diffy
satisfied_requirement
Reply all
Reply to author
Forward
0 new messages