Use per-thread virtualization group for tests [chromium/src : main]
0 views
Skip to first unread message
Vasiliy Telezhnikov (Gerrit)
May 1, 2026, 3:09:28 PMMay 1
to Kyle Charbonneau, Geoff Lang, Chromium LUCI CQ, chromium...@chromium.org, android-bu...@system.gserviceaccount.com, ozone-...@chromium.org
Attention needed from Geoff Lang and Kyle Charbonneau
Vasiliy Telezhnikov added 1 comment![]( "Open in Gerrit")
Patchset-level comments
Related details
Attention is currently required from:
- Geoff Lang
- Kyle Charbonneau
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Kyle Charbonneau (Gerrit)
May 1, 2026, 3:13:12 PMMay 1
to Vasiliy Telezhnikov, Geoff Lang, Chromium LUCI CQ, chromium...@chromium.org, android-bu...@system.gserviceaccount.com, ozone-...@chromium.org
Attention needed from Geoff Lang and Vasiliy Telezhnikov
Kyle Charbonneau voted and added 2 comments![]( "Open in Gerrit")
Votes added by Kyle Charbonneau
| Code-Review | +1 |
2 comments
Patchset-level comments
Kyle Charbonneau . resolved
lgtm
File ui/gl/gl_context_egl.cc
Line 48, Patchset 1 (Latest):
static std::atomic<EGLint> next_group_id = 10000;Kyle Charbonneau . unresolved
Maybe `AngleContextVirtualizationGroup::kMax+1`?
Related details
Attention is currently required from:
- Geoff Lang
- Vasiliy Telezhnikov
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
No-Unresolved-Comments
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Vasiliy Telezhnikov (Gerrit)
May 1, 2026, 3:28:43 PMMay 1
to Kyle Charbonneau, Geoff Lang, Chromium LUCI CQ, chromium...@chromium.org, android-bu...@system.gserviceaccount.com, ozone-...@chromium.org
Attention needed from Geoff Lang
Vasiliy Telezhnikov voted and added 1 comment![]( "Open in Gerrit")
Votes added by Vasiliy Telezhnikov
| Commit-Queue | +1 |
1 comment
File ui/gl/gl_context_egl.cc
Line 48, Patchset 1:
static std::atomic<EGLint> next_group_id = 10000;Kyle Charbonneau . resolved
Vasiliy TelezhnikovMaybe `AngleContextVirtualizationGroup::kMax+1`?
Done
Related details
Attention is currently required from:
- Geoff Lang
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Kyle Charbonneau (Gerrit)
May 1, 2026, 3:37:42 PMMay 1
to Vasiliy Telezhnikov, Geoff Lang, Chromium LUCI CQ, chromium...@chromium.org, android-bu...@system.gserviceaccount.com, ozone-...@chromium.org
Attention needed from Geoff Lang and Vasiliy Telezhnikov
Kyle Charbonneau voted and added 1 comment![]( "Open in Gerrit")
Votes added by Kyle Charbonneau
| Code-Review | +1 |
Kyle Charbonneau . resolved
lgtm
Attention is currently required from:
- Geoff Lang
- Vasiliy Telezhnikov
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Geoff Lang (Gerrit)
May 1, 2026, 5:21:31 PMMay 1
to Vasiliy Telezhnikov, Kyle Charbonneau, Chromium LUCI CQ, chromium...@chromium.org, android-bu...@system.gserviceaccount.com, ozone-...@chromium.org
Attention needed from Vasiliy Telezhnikov
Geoff Lang voted Code-Review+1![]( "Open in Gerrit")
Attention is currently required from:
- Vasiliy Telezhnikov
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Vasiliy Telezhnikov (Gerrit)
May 1, 2026, 6:33:11 PMMay 1
to Geoff Lang, Kyle Charbonneau, Chromium LUCI CQ, chromium...@chromium.org, android-bu...@system.gserviceaccount.com, ozone-...@chromium.org
Vasiliy Telezhnikov voted and added 1 comment![]( "Open in Gerrit")
Votes added by Vasiliy Telezhnikov
| Commit-Queue | +2 |
1 comment
Patchset-level comments
Vasiliy Telezhnikov . resolved
Thanks for the reviews.
Related details
Attention set is empty
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Chromium LUCI CQ (Gerrit)
May 1, 2026, 6:44:04 PMMay 1
to Vasiliy Telezhnikov, Geoff Lang, Kyle Charbonneau, chromium...@chromium.org, android-bu...@system.gserviceaccount.com, ozone-...@chromium.org
Chromium LUCI CQ submitted the change![]( "Open in Gerrit")
Change information
Commit message:
Use per-thread virtualization group for tests
Angle/GL virtualization requires different virtualization groups for
different threads. While in production we have a very controlled
behavior and GL code runs only on specific threads, in unit tests it's
not the case.
To fix this, just assign group based on a thread for tests.
Change-Id: Ia4a0a49ee015b904535beb249865afda68fc32a4
Reviewed-by: Kyle Charbonneau <kyle...@chromium.org>
Commit-Queue: Vasiliy Telezhnikov <vas...@chromium.org>
Reviewed-by: Geoff Lang <geof...@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1624136}
Files:
- M ui/gl/gl_context.h
- M ui/gl/gl_context_egl.cc
- M ui/gl/gl_context_egl.h
- M ui/gl/test/gl_surface_test_support.cc
Change size: S
Delta: 4 files changed, 33 insertions(+), 2 deletions(-)
Branch: refs/heads/main
Submit Requirements:
Code-Review: +1 by Geoff Lang, +1 by Kyle Charbonneau
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Reply all
Reply to author
Forward
0 new messages