Switch WaylandCanvasSurface size function [chromium/src : main]
Kyle Charbonneau (Gerrit)
Kyle Charbonneau voted Commit-Queue+1![]( "Open in Gerrit")
| Commit-Queue | +1 |
Related details
- Colin Blundell
Code-Coverage
Code-Owners
Code-Review
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Colin Blundell (Gerrit)
Colin Blundell added 1 comment![]( "Open in Gerrit")
size_t size_in_bytes = viz::SharedMemorySizeForSharedImageFormat(Thanks! Quick question for my understanding as it's a bit subtle wading through the code: This method is indeed a drop-in replacement for the ResourceSizes one? From your comments on the bug I had thought that it was a drop-in replacement for the BufferFormat utils that Saif is replacing, and that the ResourceSizes methods had some differences? Perhaps those aren't relevant for RGB*8?
Related details
- Kyle Charbonneau
Code-Coverage
Code-Owners
Code-Review
No-Unresolved-Comments
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Kyle Charbonneau (Gerrit)
Kyle Charbonneau voted and added 1 comment![]( "Open in Gerrit")
Votes added by Kyle Charbonneau
| Commit-Queue | +1 |
1 comment
size_t size_in_bytes = viz::SharedMemorySizeForSharedImageFormat(Thanks! Quick question for my understanding as it's a bit subtle wading through the code: This method is indeed a drop-in replacement for the ResourceSizes one? From your comments on the bug I had thought that it was a drop-in replacement for the BufferFormat utils that Saif is replacing, and that the ResourceSizes methods had some differences? Perhaps those aren't relevant for RGB*8?
Right, SharedMemorySizeForSharedImageFormat() [aligns](https://source.chromium.org/chromium/chromium/src/+/main:components/viz/common/resources/shared_image_format_utils.cc;l=283-284;drc=ce651b75de646270fc28ce175bcc951842095309) rows to 4 bytes but ResourceSizes doesn't. For RGBA_8888 that doesn't matter as it's 4 bytes per pixel and thus already 4 byte aligned.
Related details
- Colin Blundell
Code-Coverage
Code-Owners
Code-Review
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Colin Blundell (Gerrit)
Colin Blundell voted and added 1 comment![]( "Open in Gerrit")
Votes added by Colin Blundell
| Code-Review | +1 |
Thanks!
- Kyle Charbonneau
Code-Coverage
Code-Owners
Code-Review
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Kyle Charbonneau (Gerrit)
Kyle Charbonneau voted Commit-Queue+2![]( "Open in Gerrit")
Code-Coverage
Code-Owners
Code-Review
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Chromium LUCI CQ (Gerrit)
Chromium LUCI CQ submitted the change![]( "Open in Gerrit")
Change information
Switch WaylandCanvasSurface size function
Use SharedMemorySizeForSharedImageFormat() to get rid of remaining uses
of viz::ResourceSizes. The new function enforces 4 bytes alignment but
RGBA_8888 is already 4 byte aligned.
- M ui/ozone/platform/wayland/gpu/wayland_canvas_surface.cc
Code-Review: +1 by Colin Blundell
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |