Revert "Revert "[//ui] Have OzonePlatform::IsNativePixmapConfigSupported take SIFormat"" [chromium/src : main]
0 views
Skip to first unread message
luci-bisection@appspot.gserviceaccount.com (Gerrit)
Jan 8, 2026, 7:17:40 AM (3 days ago) Jan 8
to Markus Heintz, Saifuddin Hitawala, Chromium LUCI CQ, Colin Blundell, Gabrielle Lau, Daniel Cheng, AyeAye, David Worsham, chromium...@chromium.org, Robert Kroeger, spang...@chromium.org, fuchsia...@chromium.org, nickdiego+wa...@igalia.com, emi...@google.com, ozone-...@chromium.org, max+watc...@igalia.com
Attention needed from Colin Blundell, Daniel Cheng, Gabrielle Lau and Saifuddin Hitawala
luci-bi...@appspot.gserviceaccount.com voted![]( "Open in Gerrit")
LUCI Bisection is automatically submitting this revert.
| Bot-Commit | +1 |
| Commit-Queue | +2 |
| Owners-Override | +1 |
Related details
Attention is currently required from:
- Colin Blundell
- Daniel Cheng
- Gabrielle Lau
- Saifuddin Hitawala
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Chromium LUCI CQ (Gerrit)
Jan 8, 2026, 7:18:00 AM (3 days ago) Jan 8
to luci-bi...@appspot.gserviceaccount.com, Markus Heintz, Saifuddin Hitawala, Colin Blundell, Gabrielle Lau, Daniel Cheng, AyeAye, David Worsham, chromium...@chromium.org, Robert Kroeger, spang...@chromium.org, fuchsia...@chromium.org, nickdiego+wa...@igalia.com, emi...@google.com, ozone-...@chromium.org, max+watc...@igalia.com
Chromium LUCI CQ submitted the change![]( "Open in Gerrit")
Change information
Commit message:
Revert "Revert "[//ui] Have OzonePlatform::IsNativePixmapConfigSupported take SIFormat""
This reverts commit 47be1ffa7347c1d7f348491990fb61c4f75c2caa.
Reason for revert:
LUCI Bisection has identified this change as the culprit of a build failure. See the analysis: https://ci.chromium.org/ui/p/chromium/bisection/compile-analysis/b/8693244087227240945
Sample failed build: https://ci.chromium.org/b/8693244087227240945
If this is a false positive, please report it at http://b.corp.google.com/createIssue?component=1199205&description=Analysis%3A+https%3A%2F%2Fchromium-review.googlesource.com%2Fc%2Fchromium%2Fsrc%2F%2B%2F7404146&format=PLAIN&priority=P3&title=Wrongly+blamed+https%3A%2F%2Fci.chromium.org%2Fui%2Fp%2Fchromium%2Fbisection%2Fcompile-analysis%2Fb%2F8693244087227240945&type=BUG
Original change's description:
> Revert "[//ui] Have OzonePlatform::IsNativePixmapConfigSupported take SIFormat"
>
> This reverts commit d4e7e03122e4064cf5e9b05c7b07b7d97fe2afa9.
>
> Reason for revert: Suspected culprit found by LUCI bisection for tree closure:
> https://ci.chromium.org/ui/p/chromium/bisection/compile-analysis/b/8693246647954167649
>
> Tree is closed (Automatic: "compile" on https://cr-buildbucket.appspot.com/build/8693246647954167649 linux-cast-x64-rel from a986365bc5ab90b769af70b16f832e7baffd3405)
>
> Original change's description:
> > [//ui] Have OzonePlatform::IsNativePixmapConfigSupported take SIFormat
> >
> > Bug: 356649879
> > Change-Id: Iba8e22f0d800f36a6fab4769df12ccab80374dbc
> > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/7380105
> > Commit-Queue: Colin Blundell <blun...@chromium.org>
> > Reviewed-by: Saifuddin Hitawala <hita...@chromium.org>
> > Reviewed-by: Daniel Cheng <dch...@chromium.org>
> > Cr-Commit-Position: refs/heads/main@{#1566186}
>
> Bug: 356649879
> No-Presubmit: true
> No-Tree-Checks: true
> No-Try: true
> Change-Id: Ia5e7cd8f60e74ccd32b5f0ed8bf03b1786f1dad6
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/7404146
> Reviewed-by: Colin Blundell <blun...@chromium.org>
> Owners-Override: Gabrielle Lau <gabrie...@google.com>
> Commit-Queue: Gabrielle Lau <gabrie...@google.com>
> Cr-Commit-Position: refs/heads/main@{#1566204}
>
Bug: 356649879
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Change-Id: Ib18900c68be1e152237d3a9718469ce19586b7d2
Cr-Commit-Position: refs/heads/main@{#1566211}
Files:
- M gpu/command_buffer/client/internal/mappable_buffer_test_template.h
- M gpu/command_buffer/service/shared_image/ozone_image_backing_factory_unittest.cc
- M gpu/command_buffer/service/shared_image/shared_image_factory.cc
- M ui/ozone/platform/cast/ozone_platform_cast.cc
- M ui/ozone/platform/drm/ozone_platform_drm.cc
- M ui/ozone/platform/flatland/ozone_platform_flatland.cc
- M ui/ozone/platform/wayland/ozone_platform_wayland.cc
- M ui/ozone/platform/x11/ozone_platform_x11.cc
- M ui/ozone/public/ozone_platform.cc
- M ui/ozone/public/ozone_platform.h
Change size: S
Delta: 10 files changed, 23 insertions(+), 26 deletions(-)
Branch: refs/heads/main
Submit Requirements:
Code-Review: Bot-Commit+1 by luci-bi...@appspot.gserviceaccount.com
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
luci-bisection@appspot.gserviceaccount.com (Gerrit)
Jan 8, 2026, 7:35:13 AM (3 days ago) Jan 8
to Chromium LUCI CQ, Markus Heintz, Saifuddin Hitawala, Colin Blundell, Gabrielle Lau, Daniel Cheng, AyeAye, David Worsham, chromium...@chromium.org, Robert Kroeger, spang...@chromium.org, fuchsia...@chromium.org, nickdiego+wa...@igalia.com, emi...@google.com, ozone-...@chromium.org, max+watc...@igalia.com
luci-bi...@appspot.gserviceaccount.com has created a revert of this change![]( "Open in Gerrit")
Related details
Attention set is empty
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Reply all
Reply to author
Forward
0 new messages