[ozone/wayland] Add support for wl_fixes.ack_global_remove [chromium/src : main]

0 views
Skip to first unread message

Vlad Zahorodnii (Gerrit)

unread,
Jul 16, 2026, 5:15:42 PM (7 days ago) Jul 16
to Thomas Anderson, Kramer Ge, Nick Yamane, chromium...@chromium.org, max+watc...@igalia.com, nickdiego+wa...@igalia.com, ozone-...@chromium.org
Attention needed from Kramer Ge, Nick Yamane and Thomas Anderson

New activity on the change

Open in Gerrit

Related details

Attention is currently required from:
  • Kramer Ge
  • Nick Yamane
  • Thomas Anderson
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement is not satisfiedCode-Owners
  • requirement is not satisfiedCode-Review
  • requirement is not satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: Idb30c275721f074568b30869ac9d095cdab27115
Gerrit-Change-Number: 7666143
Gerrit-PatchSet: 2
Gerrit-Owner: Vlad Zahorodnii <vlad.za...@kde.org>
Gerrit-Reviewer: Kramer Ge <fang...@chromium.org>
Gerrit-Reviewer: Nick Yamane <nick...@igalia.com>
Gerrit-Reviewer: Thomas Anderson <thomasa...@chromium.org>
Gerrit-Attention: Thomas Anderson <thomasa...@chromium.org>
Gerrit-Attention: Nick Yamane <nick...@igalia.com>
Gerrit-Attention: Kramer Ge <fang...@chromium.org>
Gerrit-Comment-Date: Thu, 16 Jul 2026 21:15:22 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
satisfied_requirement
unsatisfied_requirement
open
diffy

Vlad Zahorodnii (Gerrit)

unread,
Jul 16, 2026, 5:16:14 PM (7 days ago) Jul 16
to Thomas Anderson, Kramer Ge, Nick Yamane, chromium...@chromium.org, max+watc...@igalia.com, nickdiego+wa...@igalia.com, ozone-...@chromium.org
Attention needed from Kramer Ge, Nick Yamane and Thomas Anderson

Vlad Zahorodnii added 1 comment

Patchset-level comments
Gerrit-Comment-Date: Thu, 16 Jul 2026 21:15:57 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
satisfied_requirement
unsatisfied_requirement
open
diffy

Thomas Anderson (Gerrit)

unread,
Jul 20, 2026, 5:17:05 PM (3 days ago) Jul 20
to Vlad Zahorodnii, Kramer Ge, Nick Yamane, chromium...@chromium.org, max+watc...@igalia.com, nickdiego+wa...@igalia.com, ozone-...@chromium.org
Attention needed from Kramer Ge, Nick Yamane and Vlad Zahorodnii

Thomas Anderson voted and added 2 comments

Votes added by Thomas Anderson

Code-Review+1

2 comments

Patchset-level comments
Thomas Anderson . resolved

lgtm, please wait for Kramer's secondary approval before submitting this change

File ui/ozone/platform/wayland/host/wayland_connection.cc
Line 592, Patchset 2 (Latest): if (self->fixes_ && wl_fixes_get_version(self->fixes_.get()) >=
Thomas Anderson . unresolved

nit: use wl::get_version_of_object:

```
   if (self->fixes_ && wl::get_version_of_object(self->fixes_.get()) >=
                           WL_FIXES_ACK_GLOBAL_REMOVE_SINCE_VERSION) {
```
Open in Gerrit

Related details

Attention is currently required from:
  • Kramer Ge
  • Nick Yamane
  • Vlad Zahorodnii
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement satisfiedCode-Owners
  • requirement is not satisfiedCode-Review
  • requirement is not satisfiedNo-Unresolved-Comments
  • requirement is not satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: Idb30c275721f074568b30869ac9d095cdab27115
Gerrit-Change-Number: 7666143
Gerrit-PatchSet: 2
Gerrit-Owner: Vlad Zahorodnii <vlad.za...@kde.org>
Gerrit-Reviewer: Kramer Ge <fang...@chromium.org>
Gerrit-Reviewer: Nick Yamane <nick...@igalia.com>
Gerrit-Reviewer: Thomas Anderson <thomasa...@chromium.org>
Gerrit-Attention: Vlad Zahorodnii <vlad.za...@kde.org>
Gerrit-Attention: Nick Yamane <nick...@igalia.com>
Gerrit-Attention: Kramer Ge <fang...@chromium.org>
Gerrit-Comment-Date: Mon, 20 Jul 2026 21:16:51 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
satisfied_requirement
unsatisfied_requirement
open
diffy

Vlad Zahorodnii (Gerrit)

unread,
Jul 21, 2026, 1:48:24 AM (2 days ago) Jul 21
to Thomas Anderson, Kramer Ge, Nick Yamane, chromium...@chromium.org, max+watc...@igalia.com, nickdiego+wa...@igalia.com, ozone-...@chromium.org
Attention needed from Kramer Ge, Nick Yamane and Thomas Anderson

Vlad Zahorodnii added 1 comment

File ui/ozone/platform/wayland/host/wayland_connection.cc
Line 592, Patchset 2: if (self->fixes_ && wl_fixes_get_version(self->fixes_.get()) >=
Thomas Anderson . resolved

nit: use wl::get_version_of_object:

```
   if (self->fixes_ && wl::get_version_of_object(self->fixes_.get()) >=
                           WL_FIXES_ACK_GLOBAL_REMOVE_SINCE_VERSION) {
```
Vlad Zahorodnii

Done

Open in Gerrit

Related details

Attention is currently required from:
  • Kramer Ge
  • Nick Yamane
  • Thomas Anderson
Submit Requirements:
    • requirement satisfiedCode-Coverage
    • requirement satisfiedCode-Owners
    • requirement is not satisfiedCode-Review
    • requirement is not satisfiedReview-Enforcement
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: comment
    Gerrit-Project: chromium/src
    Gerrit-Branch: main
    Gerrit-Change-Id: Idb30c275721f074568b30869ac9d095cdab27115
    Gerrit-Change-Number: 7666143
    Gerrit-PatchSet: 2
    Gerrit-Owner: Vlad Zahorodnii <vlad.za...@kde.org>
    Gerrit-Reviewer: Kramer Ge <fang...@chromium.org>
    Gerrit-Reviewer: Nick Yamane <nick...@igalia.com>
    Gerrit-Reviewer: Thomas Anderson <thomasa...@chromium.org>
    Gerrit-Attention: Thomas Anderson <thomasa...@chromium.org>
    Gerrit-Attention: Nick Yamane <nick...@igalia.com>
    Gerrit-Attention: Kramer Ge <fang...@chromium.org>
    Gerrit-Comment-Date: Tue, 21 Jul 2026 05:48:07 +0000
    Gerrit-HasComments: Yes
    Gerrit-Has-Labels: No
    Comment-In-Reply-To: Thomas Anderson <thomasa...@chromium.org>
    satisfied_requirement
    unsatisfied_requirement
    open
    diffy

    Kramer Ge (Gerrit)

    unread,
    Jul 21, 2026, 4:13:26 PM (2 days ago) Jul 21
    to Vlad Zahorodnii, Thomas Anderson, Nick Yamane, chromium...@chromium.org, max+watc...@igalia.com, nickdiego+wa...@igalia.com, ozone-...@chromium.org
    Attention needed from Nick Yamane, Thomas Anderson and Vlad Zahorodnii

    Kramer Ge voted Code-Review+1

    Code-Review+1
    Open in Gerrit

    Related details

    Attention is currently required from:
    • Nick Yamane
    • Thomas Anderson
    • Vlad Zahorodnii
    Submit Requirements:
    • requirement satisfiedCode-Coverage
    • requirement satisfiedCode-Owners
    • requirement is not satisfiedCode-Review
    • requirement is not satisfiedReview-Enforcement
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: comment
    Gerrit-Project: chromium/src
    Gerrit-Branch: main
    Gerrit-Change-Id: Idb30c275721f074568b30869ac9d095cdab27115
    Gerrit-Change-Number: 7666143
    Gerrit-PatchSet: 3
    Gerrit-Owner: Vlad Zahorodnii <vlad.za...@kde.org>
    Gerrit-Reviewer: Kramer Ge <fang...@chromium.org>
    Gerrit-Reviewer: Nick Yamane <nick...@igalia.com>
    Gerrit-Reviewer: Thomas Anderson <thomasa...@chromium.org>
    Gerrit-Attention: Vlad Zahorodnii <vlad.za...@kde.org>
    Gerrit-Attention: Thomas Anderson <thomasa...@chromium.org>
    Gerrit-Attention: Nick Yamane <nick...@igalia.com>
    Gerrit-Comment-Date: Tue, 21 Jul 2026 20:13:19 +0000
    Gerrit-HasComments: No
    Gerrit-Has-Labels: Yes
    satisfied_requirement
    unsatisfied_requirement
    open
    diffy

    Thomas Anderson (Gerrit)

    unread,
    Jul 21, 2026, 6:48:21 PM (2 days ago) Jul 21
    to Vlad Zahorodnii, Nick Yamane, chromium...@chromium.org, max+watc...@igalia.com, nickdiego+wa...@igalia.com, ozone-...@chromium.org
    Attention needed from Nick Yamane and Vlad Zahorodnii

    Thomas Anderson voted

    Code-Review+1
    Commit-Queue+2
    Open in Gerrit

    Related details

    Attention is currently required from:
    • Nick Yamane
    • Vlad Zahorodnii
    Submit Requirements:
      • requirement satisfiedCode-Coverage
      • requirement satisfiedCode-Owners
      • requirement satisfiedCode-Review
      • requirement satisfiedReview-Enforcement
      Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
      Gerrit-MessageType: comment
      Gerrit-Project: chromium/src
      Gerrit-Branch: main
      Gerrit-Change-Id: Idb30c275721f074568b30869ac9d095cdab27115
      Gerrit-Change-Number: 7666143
      Gerrit-PatchSet: 3
      Gerrit-Owner: Vlad Zahorodnii <vlad.za...@kde.org>
      Gerrit-Reviewer: Kramer Ge <fang...@chromium.org>
      Gerrit-Reviewer: Nick Yamane <nick...@igalia.com>
      Gerrit-Reviewer: Thomas Anderson <thomasa...@chromium.org>
      Gerrit-Attention: Vlad Zahorodnii <vlad.za...@kde.org>
      Gerrit-Attention: Nick Yamane <nick...@igalia.com>
      Gerrit-Comment-Date: Tue, 21 Jul 2026 22:48:08 +0000
      Gerrit-HasComments: No
      Gerrit-Has-Labels: Yes
      satisfied_requirement
      open
      diffy

      Thomas Anderson (Gerrit)

      unread,
      Jul 21, 2026, 7:58:36 PM (2 days ago) Jul 21
      to Vlad Zahorodnii, Chromium LUCI CQ, Nick Yamane, chromium...@chromium.org, max+watc...@igalia.com, nickdiego+wa...@igalia.com, ozone-...@chromium.org
      Attention needed from Nick Yamane and Vlad Zahorodnii

      Thomas Anderson voted Commit-Queue+2

      Commit-Queue+2
      Open in Gerrit

      Related details

      Attention is currently required from:
      • Nick Yamane
      • Vlad Zahorodnii
      Submit Requirements:
      • requirement satisfiedCode-Coverage
      • requirement satisfiedCode-Owners
      • requirement satisfiedCode-Review
      • requirement satisfiedReview-Enforcement
      Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
      Gerrit-MessageType: comment
      Gerrit-Project: chromium/src
      Gerrit-Branch: main
      Gerrit-Change-Id: Idb30c275721f074568b30869ac9d095cdab27115
      Gerrit-Change-Number: 7666143
      Gerrit-PatchSet: 3
      Gerrit-Owner: Vlad Zahorodnii <vlad.za...@kde.org>
      Gerrit-Reviewer: Kramer Ge <fang...@chromium.org>
      Gerrit-Reviewer: Nick Yamane <nick...@igalia.com>
      Gerrit-Reviewer: Thomas Anderson <thomasa...@chromium.org>
      Gerrit-Attention: Vlad Zahorodnii <vlad.za...@kde.org>
      Gerrit-Attention: Nick Yamane <nick...@igalia.com>
      Gerrit-Comment-Date: Tue, 21 Jul 2026 23:58:26 +0000
      Gerrit-HasComments: No
      Gerrit-Has-Labels: Yes
      satisfied_requirement
      open
      diffy

      Vlad Zahorodnii (Gerrit)

      unread,
      Jul 22, 2026, 2:02:25 AM (yesterday) Jul 22
      to Chromium LUCI CQ, Thomas Anderson, Nick Yamane, chromium...@chromium.org, max+watc...@igalia.com, nickdiego+wa...@igalia.com, ozone-...@chromium.org
      Attention needed from Nick Yamane and Thomas Anderson

      Vlad Zahorodnii added 1 comment

      Patchset-level comments
      File-level comment, Patchset 3 (Latest):
      Vlad Zahorodnii . resolved

      warp is a new event. Should I add a noop function?

      Open in Gerrit

      Related details

      Attention is currently required from:
      • Nick Yamane
      • Thomas Anderson
      Submit Requirements:
      • requirement satisfiedCode-Coverage
      • requirement satisfiedCode-Owners
      • requirement satisfiedCode-Review
      • requirement satisfiedReview-Enforcement
      Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
      Gerrit-MessageType: comment
      Gerrit-Project: chromium/src
      Gerrit-Branch: main
      Gerrit-Change-Id: Idb30c275721f074568b30869ac9d095cdab27115
      Gerrit-Change-Number: 7666143
      Gerrit-PatchSet: 3
      Gerrit-Owner: Vlad Zahorodnii <vlad.za...@kde.org>
      Gerrit-Reviewer: Kramer Ge <fang...@chromium.org>
      Gerrit-Reviewer: Nick Yamane <nick...@igalia.com>
      Gerrit-Reviewer: Thomas Anderson <thomasa...@chromium.org>
      Gerrit-Attention: Thomas Anderson <thomasa...@chromium.org>
      Gerrit-Attention: Nick Yamane <nick...@igalia.com>
      Gerrit-Comment-Date: Wed, 22 Jul 2026 06:02:06 +0000
      Gerrit-HasComments: Yes
      Gerrit-Has-Labels: No
      satisfied_requirement
      open
      diffy

      Vlad Zahorodnii (Gerrit)

      unread,
      Jul 22, 2026, 2:03:37 AM (yesterday) Jul 22
      to Chromium LUCI CQ, Thomas Anderson, Nick Yamane, chromium...@chromium.org, max+watc...@igalia.com, nickdiego+wa...@igalia.com, ozone-...@chromium.org
      Attention needed from Nick Yamane and Thomas Anderson

      Vlad Zahorodnii added 1 comment

      Patchset-level comments
      Vlad Zahorodnii . resolved

      Alternatively, perhaps the changes can be split so wayland is updated and an OnWarp function is added, then this patch only adds support for the ack_global_remove request.

      Gerrit-Comment-Date: Wed, 22 Jul 2026 06:03:15 +0000
      Gerrit-HasComments: Yes
      Gerrit-Has-Labels: No
      satisfied_requirement
      open
      diffy

      Vlad Zahorodnii (Gerrit)

      unread,
      Jul 22, 2026, 2:19:49 AM (yesterday) Jul 22
      to Chromium LUCI CQ, Thomas Anderson, Nick Yamane, chromium...@chromium.org, max+watc...@igalia.com, nickdiego+wa...@igalia.com, ozone-...@chromium.org
      Attention needed from Nick Yamane and Thomas Anderson

      Vlad Zahorodnii added 1 comment

      Patchset-level comments
      Vlad Zahorodnii . resolved

      Ah, the build failure comes from angle, which is a different repo. We need at least something like this https://invent.kde.org/-/snippets/3847 there.

      Gerrit-Comment-Date: Wed, 22 Jul 2026 06:19:26 +0000
      Gerrit-HasComments: Yes
      Gerrit-Has-Labels: No
      satisfied_requirement
      open
      diffy

      Vlad Zahorodnii (Gerrit)

      unread,
      Jul 22, 2026, 3:32:23 AM (yesterday) Jul 22
      to Chromium LUCI CQ, Thomas Anderson, Nick Yamane, chromium...@chromium.org, max+watc...@igalia.com, nickdiego+wa...@igalia.com, ozone-...@chromium.org
      Attention needed from Nick Yamane and Thomas Anderson

      Vlad Zahorodnii added 1 comment

      Patchset-level comments
      Vlad Zahorodnii . resolved

      `fetch angle` fails for me. Can somebody help me with fixing ANGLE please?

      Gerrit-Comment-Date: Wed, 22 Jul 2026 07:32:06 +0000
      Gerrit-HasComments: Yes
      Gerrit-Has-Labels: No
      satisfied_requirement
      open
      diffy
      Reply all
      Reply to author
      Forward
      0 new messages